teleivo <mrteleivo@gmail.com>: Author Summary
Build | Completed | Code commits | Tests |
---|---|---|---|
DOC › DOC › #13 | 1 year ago | Testless build | |
JAVADOC › TRUNK › #1598 | 1 year ago |
Add readme to openmrs/modules/dtd
to explain what they do, where to find further information and how they are synced to http://resources.openmrs.org/doctype TRUNK-5404 Deprecate unused MigrationHelper
since it is not used within core and not anywhere in the openmrs github organization and has only been updated a few times to keep it from breaking our build and up to our coding standards. TRUNK-5404 Add deprecation javadocs to MigrationHelper
|
Testless build |
SON › OPENMRSCOREMASTER › #1702 | 1 year ago |
TRUNK-5404 Deprecate unused MigrationHelper
since it is not used within core and not anywhere in the openmrs github organization and has only been updated a few times to keep it from breaking our build and up to our coding standards. Add readme to openmrs/modules/dtd
to explain what they do, where to find further information and how they are synced to http://resources.openmrs.org/doctype TRUNK-5404 Add deprecation javadocs to MigrationHelper
|
Testless build |
TRUNK › MASTER › #1937 | 1 year ago |
TRUNK-5404 Add deprecation javadocs to MigrationHelper
|
4070 passed |
TRUNK › MASTER › #1936 | 1 year ago |
Add readme to openmrs/modules/dtd
to explain what they do, where to find further information and how they are synced to http://resources.openmrs.org/doctype |
4070 passed |
TRUNK › MASTER › #1935 | 1 year ago |
TRUNK-5404 Deprecate unused MigrationHelper
since it is not used within core and not anywhere in the openmrs github organization and has only been updated a few times to keep it from breaking our build and up to our coding standards. |
4070 passed |
SON › OPENMRSCOREMASTER › #1696 | 1 year ago |
TRUNK-5401 Do not use PowerMock in PatientServiceImplTest
Fix indentation in PatientServiceImplTest
use tabs instead of spaces |
Testless build |
DOC › DOC › #6 | 1 year ago |
TRUNK-5401 Do not use PowerMock in PatientServiceImplTest
Fix indentation in PatientServiceImplTest
use tabs instead of spaces |
Testless build |
JAVADOC › TRUNK › #1591 | 1 year ago |
TRUNK-5401 Do not use PowerMock in PatientServiceImplTest
Fix indentation in PatientServiceImplTest
use tabs instead of spaces |
Testless build |
TRUNK › MASTER › #1934 | 1 year ago |
TRUNK-5401 Do not use PowerMock in PatientServiceImplTest
Fix indentation in PatientServiceImplTest
use tabs instead of spaces |
4070 passed |
Build | Completed | Code commits | Tests |
---|---|---|---|
SON › OPENMRSCOREMASTER › #1630 | 1 year ago |
Add missing tests for Module.getExtensions()
* add tests to achieve full coverage of getExtensions() * use a more realisitc setup as Module follows in its creation via ModuleFileParser Turn ModuleExtensionsTest into unit tests
ModuleExtensionsTest uses powermock and asserts on private methods which is not needed as we can assert on the resulting List of Extensions whether the extension names are expanded |
Testless build |
TRUNK › MASTER › #1815 | 1 year ago |
TRUNK-5298 Add .editorconfig to force use of tabs in IDEs
IntelliJ, Visual Studio Code and other IDEs/Editors support editorconfig files out of the box, others like Eclipse, Atom, Sublime, Vim need a plugin. should help to reduce the spaces/tabs mess we are currently seeing. http://editorconfig.org/#overview |
2223 passed |
SON › OPENMRSCOREMASTER › #1213 | 2 years ago |
TRUNK-5137 Add custom hamcrest matcher HasGlobalError
Add a custom hamcrest matcher HasGlobalErrors which enables assertThat(errors, hasGlobalErrors()); assertThat(errors, hasGlobalErrors("error.null")); Provide factories which enables the above after static imports of the matcher. Show use of matcher in PersonNameValidatorTest and ConceptValidatorTest |
1 of 3476 failed |
TRUNK › MASTER › #1566 | 2 years ago |
TRUNK-5137 Add custom hamcrest matcher HasGlobalError
Add a custom hamcrest matcher HasGlobalErrors which enables assertThat(errors, hasGlobalErrors()); assertThat(errors, hasGlobalErrors("error.null")); Provide factories which enables the above after static imports of the matcher. Show use of matcher in PersonNameValidatorTest and ConceptValidatorTest |
1 of 3529 failed |
SON › OPENMRSCOREMASTER › #1210 | 2 years ago |
TRUNK-5135 Deprecate @Verifies
all usages of @Verifies and @verifies were removed in TRUNK-5122 and thus @Verifies is deprecated and flagged using checkstyle Cleanup and add tests to ConceptAttributeTypeValidatorTest
* add setUp method preparing variables needed for tests to remove duplication in test setup * split tests for null, empty, whitespace name since they are independent * add assertions for error code so we ensure that when devs refactor the code the user will still get the excpected error message * move happy path tests to the end, which makes side by side reading of code and test easy |
3 of 3452 failed |
JAVADOC › TRUNK › #1167 | 2 years ago |
add instructions to checklist in PR template
as new devs creating PRs seem to have trouble formatting their code, creating a single commit, adding tests, running their changes and tests through the build process I * tried to clarify the language/structure of the PR template * added instructions to the checklist so that if a new devs has doubts directly has the right resource at hand to check the box in the end |
Testless build |
SON › OPENMRSCOREMASTER › #1202 | 2 years ago |
add instructions to checklist in PR template
as new devs creating PRs seem to have trouble formatting their code, creating a single commit, adding tests, running their changes and tests through the build process I * tried to clarify the language/structure of the PR template * added instructions to the checklist so that if a new devs has doubts directly has the right resource at hand to check the box in the end |
Testless build |
TRUNK › MASTER › #1481 | 2 years ago |
TRUNK-5085 Merge checkstyle rules with google's
merged our existing checkstyle.xml with google's * removed their checks for tabs since we use tabs * added NPathComplexity since it was already actived on codacy * added CustomImportOrder rule using the Eclipse defaults * changed the default severity to warning * explicitly set the severity of rules we had before to error * MagicNumber is an error but ignored for annotations * reduced NestedIfDepth to 4 since that smells * reduced NestedTryDepth to 2 since that smells |
3430 passed |
TRUNK › MASTER › #1344 | 3 years ago |
TRUNK-4936 Add ConceptSource.uniqueId
* add ConceptSource.uniqueId * add property to hibernate mapping file ConceptSource.hbm.xml * ensure ConceptSourceValidator validates max conceptId length * add liquibase changeset adding the column concept_source.unique_id with unique constraint (but defaults to null) * add service method to ConceptService with implementation in ConceptServiceImpl * add ConceptDAO method with HibernateDAO implementation * add tests for the service layer * add the official registered OID of "SNOMED CT" into its unique_id column in the standardTestDataset.xml so it can be used in tests |
9 of 3407 failed |
SON › OPENMRSCOREMASTER › #1013 | 3 years ago |
Clarify ModuleUtil javadoc of matching version methods
Add javadoc explanation about the meaning of the allowed required version ranges in methods matchRequiredVersions and checkRequiredVersion TRUNK-4941 Add ModuleUtil.isOpenmrsVersionInVersions()
isOpenmrsVersionInVersions(String ...versions) allows one to check if the current openmrs version matches an array of versions according to ModuleUtil.matchRequiredVersions |
3307 passed |
Build | Completed | Code commits | Tests |
---|---|---|---|
SON › OPENMRSCOREMASTER › #1214 | 2 years ago |
Fix and clean ConceptValidatorTest
* fix failing test validate_shouldFailIfAnyNameIsAnEmptyString had wrong assertion * extract duplicate test setup into setUp method * make conceptService a member and autowire it * make concept cd4Count and weight members since they are used multiple times * arrange tests in arrange, act, assert way so reading is easier * add test for when getNames() returns empty list * fix validate_shouldFailIfTheObjectParameterIsNull which expects an IAE but from the validator. However the call to new BindException(null, "concept"); fails since the target object must not be null |
3468 passed |
TRUNK › MASTER › #1568 | 2 years ago |
Fix and clean ConceptValidatorTest
* fix failing test validate_shouldFailIfAnyNameIsAnEmptyString had wrong assertion * extract duplicate test setup into setUp method * make conceptService a member and autowire it * make concept cd4Count and weight members since they are used multiple times * arrange tests in arrange, act, assert way so reading is easier * add test for when getNames() returns empty list * fix validate_shouldFailIfTheObjectParameterIsNull which expects an IAE but from the validator. However the call to new BindException(null, "concept"); fails since the target object must not be null |
3519 passed |
TRUNK › MASTER › #1482 | 2 years ago |
Fix license header in checkstyle.xml
|
3430 passed |
TRUNK › MASTER › #1347 | 3 years ago |
TRUNK-4936 Fix integration-test on h2 due to liquibase changeset
Some integration-test's failed on h2 due to the introduced liquibase changeset for TRUNK-4936. ALTER TABLE sql statement generated by h2 contains a syntax error. h2 does only seem to handle unique constraints well when creating the table, or on its own and not when adding the column. * remove the nested <constraints> element from the changeset * use addColumn and addUniqueConstraint |
3366 passed |
RAD › RM › #253 | 3 years ago |
Update RadiologyReportFormController and its tests
cleaned RadiologyReportFormController * updated javadocs * remove unnecessary filling of model and view on redirect * remove modelAttribute name if it is same as default |
289 passed |
RAD › RM › #136 | 3 years ago |
RAD-178 Change reporting dependency to 0.9.9
* version 0.9.9 of reporting module was released, snapshot is no longer valid. * fixes failed travis ci builds |
256 passed |
RAD › RM › #14 | 4 years ago |
Fix observationRequestSegment Modality
adapt the hl7 Observation Request Segment population to new Modality enum |
Testless build |
TRUNK › MASTER › #809 | 4 years ago |
OpenMRSFormatter stacks enum elements one per line
instead of putting all elements in one line * improves readability * leads to good diffs, where added/deleted elements can be spotted right away |
3413 passed |
to explain what they do, where to find further information and how they
are synced to http://resources.openmrs.org/doctype
since it is not used within core and not anywhere in the openmrs github
organization and has only been updated a few times to keep it from
breaking our build and up to our coding standards.