teleivo <mrteleivo@gmail.com>: Author Summary

Builds triggered by teleivo <mrteleivo@gmail.com>

Builds triggered by an author are those builds which contains changes committed by the author.
509
26 (5%)
483 (95%)

Breakages and fixes

Broken means the build has failed but the previous build was successful.
Fixed means that the build was successful but the previous build has failed.
15 (3% of all builds triggered)
8 (2% of all builds triggered)
-7
Build Completed Code commits Tests
JAVADOC › TRUNK › #1313 1 month ago
TRUNK-5205 Use java8 Base64 instead of xerces
replaced use of org.apache.xerces.impl.dv.util.Base64
with java8 Base64

added small refactorings TestInstallUtil.getResourceInputStream
* extracted private methods to improve readability
* renamed parameter
* use parametrized log message style and remove if since log.info
already checks for the log level

set checkstyle rule: Import from illegal package - org.apache.xerces
Testless build
SON › OPENMRSCOREMASTER › #1349 1 month ago
TRUNK-5205 Use java8 Base64 instead of xerces
replaced use of org.apache.xerces.impl.dv.util.Base64
with java8 Base64

added small refactorings TestInstallUtil.getResourceInputStream
* extracted private methods to improve readability
* renamed parameter
* use parametrized log message style and remove if since log.info
already checks for the log level

set checkstyle rule: Import from illegal package - org.apache.xerces
3759 passed
TRUNK › MASTER › #1682 1 month ago
TRUNK-5205 Use java8 Base64 instead of xerces
replaced use of org.apache.xerces.impl.dv.util.Base64
with java8 Base64

added small refactorings TestInstallUtil.getResourceInputStream
* extracted private methods to improve readability
* renamed parameter
* use parametrized log message style and remove if since log.info
already checks for the log level

set checkstyle rule: Import from illegal package - org.apache.xerces
3810 passed
JAVADOC › TRUNK › #1312 1 month ago
TRUNK-5206 Extract test strings exceeding property lenghts in variables
Testless build
SON › OPENMRSCOREMASTER › #1348 1 month ago
TRUNK-5206 Extract test strings exceeding property lenghts in variables
3759 passed
TRUNK › MASTER › #1681 1 month ago
TRUNK-5206 Extract test strings exceeding property lenghts in variables
3810 passed
JAVADOC › TRUNK › #1310 1 month ago
TRUNK-5200 Remove unused dependency cglib-nodep
TRUNKT-5199 Remove unused dependencies asm, asm-commons, asm-util
TRUNK-5203 Remove unused dependency xmlunit
Testless build
SON › OPENMRSCOREMASTER › #1346 1 month ago
TRUNK-5203 Remove unused dependency xmlunit
TRUNKT-5199 Remove unused dependencies asm, asm-commons, asm-util
TRUNK-5200 Remove unused dependency cglib-nodep
3759 passed
TRUNK › MASTER › #1680 1 month ago
TRUNK-5203 Remove unused dependency xmlunit
3810 passed
TRUNK › MASTER › #1677 1 month ago
TRUNK-5200 Remove unused dependency cglib-nodep
3809 passed
Build Completed Code commits Tests
SON › OPENMRSCOREMASTER › #1213 5 months ago
TRUNK-5137 Add custom hamcrest matcher HasGlobalError
Add a custom hamcrest matcher HasGlobalErrors which enables

assertThat(errors, hasGlobalErrors());
assertThat(errors, hasGlobalErrors("error.null"));

Provide factories which enables the above after static imports of
the matcher.

Show use of matcher in PersonNameValidatorTest and ConceptValidatorTest
1 of 3476 failed
TRUNK › MASTER › #1566 5 months ago
TRUNK-5137 Add custom hamcrest matcher HasGlobalError
Add a custom hamcrest matcher HasGlobalErrors which enables

assertThat(errors, hasGlobalErrors());
assertThat(errors, hasGlobalErrors("error.null"));

Provide factories which enables the above after static imports of
the matcher.

Show use of matcher in PersonNameValidatorTest and ConceptValidatorTest
1 of 3529 failed
SON › OPENMRSCOREMASTER › #1210 5 months ago
Cleanup and add tests to ConceptAttributeTypeValidatorTest
* add setUp method preparing variables needed for tests to remove
duplication in test setup
* split tests for null, empty, whitespace name since they are
independent
* add assertions for error code so we ensure that when devs refactor
the code the user will still get the excpected error message
* move happy path tests to the end, which makes side by side reading of
code and test easy
TRUNK-5135 Deprecate @Verifies
all usages of @Verifies and @verifies were removed in TRUNK-5122
and thus @Verifies is deprecated and flagged using checkstyle
3 of 3452 failed
JAVADOC › TRUNK › #1167 6 months ago
add instructions to checklist in PR template
as new devs creating PRs seem to have trouble
formatting their code, creating a single commit, adding tests, running
their changes and tests through the build process I

* tried to clarify the language/structure of the PR template
* added instructions to the checklist so that if a new devs has doubts
directly has the right resource at hand to check the box in the end
Testless build
SON › OPENMRSCOREMASTER › #1202 6 months ago
add instructions to checklist in PR template
as new devs creating PRs seem to have trouble
formatting their code, creating a single commit, adding tests, running
their changes and tests through the build process I

* tried to clarify the language/structure of the PR template
* added instructions to the checklist so that if a new devs has doubts
directly has the right resource at hand to check the box in the end
Testless build
TRUNK › MASTER › #1481 6 months ago
TRUNK-5085 Merge checkstyle rules with google's
merged our existing checkstyle.xml with google's

* removed their checks for tabs since we use tabs
* added NPathComplexity since it was already actived on codacy
* added CustomImportOrder rule using the Eclipse defaults
* changed the default severity to warning
* explicitly set the severity of rules we had before to error
* MagicNumber is an error but ignored for annotations
* reduced NestedIfDepth to 4 since that smells
* reduced NestedTryDepth to 2 since that smells
3430 passed
TRUNK › MASTER › #1344 11 months ago
TRUNK-4936 Add ConceptSource.uniqueId
* add ConceptSource.uniqueId
* add property to hibernate mapping file ConceptSource.hbm.xml
* ensure ConceptSourceValidator validates max conceptId length
* add liquibase changeset adding the column concept_source.unique_id
with unique constraint (but defaults to null)
* add service method to ConceptService with implementation in
ConceptServiceImpl
* add ConceptDAO method with HibernateDAO implementation
* add tests for the service layer
* add the official registered OID of "SNOMED CT" into its unique_id
column in the standardTestDataset.xml so it can be used in tests
9 of 3407 failed
SON › OPENMRSCOREMASTER › #1013 1 year ago
Clarify ModuleUtil javadoc of matching version methods
Add javadoc explanation about the meaning of the allowed required version
ranges in methods matchRequiredVersions and checkRequiredVersion
TRUNK-4941 Add ModuleUtil.isOpenmrsVersionInVersions()
isOpenmrsVersionInVersions(String ...versions) allows one to check if the current openmrs version
matches an array of versions according to ModuleUtil.matchRequiredVersions
3307 passed
RAD › RM › #304 1 year ago
Update to openmrs-core and REST
* openmrs-core 2.0.0 has been released so SNAPSHOT isnt available anymore
* and webservices REST 2.15 was released
383 passed
RAD › RM › #251 1 year ago
RAD-173 Prevent empty report body
RadiologyReportValidator prevents an empty report body when completing a
report, so a completed report always has a report body.

* adjusted RadiologyReportValidator to fail on empty report body
* adjusted radiologyReportForm to show error spans properly
* use jquery in tinymce init
* autowire RadiologyReportValidator since its already available as component
* fix error in RadiologyReportFormController, did not make proper use of the
Validator
Testless build
Build Completed Code commits Tests
SON › OPENMRSCOREMASTER › #1214 5 months ago
Fix and clean ConceptValidatorTest
* fix failing test validate_shouldFailIfAnyNameIsAnEmptyString
had wrong assertion
* extract duplicate test setup into setUp method
* make conceptService a member and autowire it
* make concept cd4Count and weight members since they are used multiple
times
* arrange tests in arrange, act, assert way so reading is easier
* add test for when getNames() returns empty list
* fix validate_shouldFailIfTheObjectParameterIsNull
which expects an IAE but from the validator. However the call to
new BindException(null, "concept");

fails since the target object must not be null
3468 passed
TRUNK › MASTER › #1568 5 months ago
Fix and clean ConceptValidatorTest
* fix failing test validate_shouldFailIfAnyNameIsAnEmptyString
had wrong assertion
* extract duplicate test setup into setUp method
* make conceptService a member and autowire it
* make concept cd4Count and weight members since they are used multiple
times
* arrange tests in arrange, act, assert way so reading is easier
* add test for when getNames() returns empty list
* fix validate_shouldFailIfTheObjectParameterIsNull
which expects an IAE but from the validator. However the call to
new BindException(null, "concept");

fails since the target object must not be null
3519 passed
TRUNK › MASTER › #1482 6 months ago
Fix license header in checkstyle.xml
3430 passed
TRUNK › MASTER › #1347 11 months ago
TRUNK-4936 Fix integration-test on h2 due to liquibase changeset
Some integration-test's failed on h2 due to the introduced liquibase changeset
for TRUNK-4936. ALTER TABLE sql statement generated by h2 contains a
syntax error. h2 does only seem to handle unique constraints well when
creating the table, or on its own and not when adding the column.

* remove the nested <constraints> element from the changeset
* use addColumn and addUniqueConstraint
3366 passed
RAD › RM › #253 1 year ago
Update RadiologyReportFormController and its tests
cleaned RadiologyReportFormController

* updated javadocs
* remove unnecessary filling of model and view on redirect
* remove modelAttribute name if it is same as default
289 passed
RAD › RM › #136 1 year ago
RAD-178 Change reporting dependency to 0.9.9
* version 0.9.9 of reporting module was released, snapshot is no longer valid.
* fixes failed travis ci builds
256 passed
RAD › RM › #14 2 years ago
Fix observationRequestSegment Modality
adapt the hl7 Observation Request Segment population to new Modality enum
Testless build
TRUNK › MASTER › #809 2 years ago
OpenMRSFormatter stacks enum elements one per line
instead of putting all elements in one line

* improves readability
* leads to good diffs, where added/deleted elements can be spotted right away
3413 passed