teleivo <mrteleivo@gmail.com>: Author Summary

Builds triggered by teleivo <mrteleivo@gmail.com>

Builds triggered by an author are those builds which contains changes committed by the author.
571
29 (5%)
542 (95%)

Breakages and fixes

Broken means the build has failed but the previous build was successful.
Fixed means that the build was successful but the previous build has failed.
17 (3% of all builds triggered)
9 (2% of all builds triggered)
-8
Build Completed Code commits Tests
JAVADOC › TRUNK › #1214 3 weeks ago
TRUNK-5165 ConceptMapTypeEditor does not get object via uuid
ConceptMapTypeEditor does not try getting the object via uuid after it failed
to get it via its id although the service provides the method.
This is usually done (>30 editors for OpenmrsObjects).
TRUNK-5139 Adapt test of ProviderEditor
* ignore test for when trying to get a Provider of non existing ID
since this is an issue TRUNK-5153
TRUNK-5162 Few PropertyEditor getAsText return null if value is null
ConceptAttributeTypeEditor.java
LocationAttributeTypeEditor.java
LocationEditor.java
LocationTagEditor.java

which where the only ones returning null, in ~37 PropertyEditors
TRUNK-5163 Disable logs during tests
TRUNK-5167 PersonEditor does not throw if Person not found
PersonEditor does not throw an IllegalArgumentException if Person
is not found given text which is different than ~30 PropertyEditors for OpenmrsObjects
TRUNK-5166 ConceptReferenceTermEditorTest does not get object via uuid
ConceptMapTypeEditor does not try getting the object via uuid after it failed to get it via its id
although the service provides the method. This is usually done (>30 editors for OpenmrsObjects).
TRUNK-5164 Add abstract OpenmrsPropertyEditor
Add abstract OpenmrsPropertyEditor for OpenmrsObject's
which tries to get an object via its id and if that fails via its uuid

Let

CohortEditor.java
ConceptAnswerEditor.java
ConceptAttributeTypeEditor.java
ConceptClassEditor.java
ConceptDatatypeEditor.java
ConceptEditor.java
ConceptNameEditor.java
ConceptNumericEditor.java
ConceptSourceEditor.java
DrugEditor.java
EncounterEditor.java
EncounterTypeEditor.java
FormEditor.java
LocationAttributeTypeEditor.java
LocationEditor.java
LocationTagEditor.java
OpenmrsPropertyEditor.java
OrderEditor.java
PatientEditor.java
PatientIdentifierTypeEditor.java
PersonAttributeEditor.java
PersonAttributeTypeEditor.java
ProgramWorkflowEditor.java
ProgramWorkflowStateEditor.java
UserEditor.java
VisitEditor.java
VisitTypeEditor.java

extend OpenmrsPropertyEditor.

The current behavior is not changed as shown by existing tests which
were not changed.
Testless build
SON › OPENMRSCOREMASTER › #1250 3 weeks ago
TRUNK-5139 Adapt test of ProviderEditor
* ignore test for when trying to get a Provider of non existing ID
since this is an issue TRUNK-5153
TRUNK-5163 Disable logs during tests
TRUNK-5165 ConceptMapTypeEditor does not get object via uuid
ConceptMapTypeEditor does not try getting the object via uuid after it failed
to get it via its id although the service provides the method.
This is usually done (>30 editors for OpenmrsObjects).
TRUNK-5167 PersonEditor does not throw if Person not found
PersonEditor does not throw an IllegalArgumentException if Person
is not found given text which is different than ~30 PropertyEditors for OpenmrsObjects
TRUNK-5166 ConceptReferenceTermEditorTest does not get object via uuid
ConceptMapTypeEditor does not try getting the object via uuid after it failed to get it via its id
although the service provides the method. This is usually done (>30 editors for OpenmrsObjects).
TRUNK-5164 Add abstract OpenmrsPropertyEditor
Add abstract OpenmrsPropertyEditor for OpenmrsObject's
which tries to get an object via its id and if that fails via its uuid

Let

CohortEditor.java
ConceptAnswerEditor.java
ConceptAttributeTypeEditor.java
ConceptClassEditor.java
ConceptDatatypeEditor.java
ConceptEditor.java
ConceptNameEditor.java
ConceptNumericEditor.java
ConceptSourceEditor.java
DrugEditor.java
EncounterEditor.java
EncounterTypeEditor.java
FormEditor.java
LocationAttributeTypeEditor.java
LocationEditor.java
LocationTagEditor.java
OpenmrsPropertyEditor.java
OrderEditor.java
PatientEditor.java
PatientIdentifierTypeEditor.java
PersonAttributeEditor.java
PersonAttributeTypeEditor.java
ProgramWorkflowEditor.java
ProgramWorkflowStateEditor.java
UserEditor.java
VisitEditor.java
VisitTypeEditor.java

extend OpenmrsPropertyEditor.

The current behavior is not changed as shown by existing tests which
were not changed.
TRUNK-5162 Few PropertyEditor getAsText return null if value is null
ConceptAttributeTypeEditor.java
LocationAttributeTypeEditor.java
LocationEditor.java
LocationTagEditor.java

which where the only ones returning null, in ~37 PropertyEditors
3738 passed
TRUNK › MASTER › #1645 3 weeks ago
TRUNK-5166 ConceptReferenceTermEditorTest does not get object via uuid
ConceptMapTypeEditor does not try getting the object via uuid after it failed to get it via its id
although the service provides the method. This is usually done (>30 editors for OpenmrsObjects).
TRUNK-5167 PersonEditor does not throw if Person not found
PersonEditor does not throw an IllegalArgumentException if Person
is not found given text which is different than ~30 PropertyEditors for OpenmrsObjects
3789 passed
TRUNK › MWO › #561 3 weeks ago
TRUNK-5167 PersonEditor does not throw if Person not found
PersonEditor does not throw an IllegalArgumentException if Person
is not found given text which is different than ~30 PropertyEditors for OpenmrsObjects
Testless build
TRUNK › MWO › #560 3 weeks ago
TRUNK-5166 ConceptReferenceTermEditorTest does not get object via uuid
ConceptMapTypeEditor does not try getting the object via uuid after it failed to get it via its id
although the service provides the method. This is usually done (>30 editors for OpenmrsObjects).
Testless build
TRUNK › MWO › #559 3 weeks ago
TRUNK-5165 ConceptMapTypeEditor does not get object via uuid
ConceptMapTypeEditor does not try getting the object via uuid after it failed
to get it via its id although the service provides the method.
This is usually done (>30 editors for OpenmrsObjects).
Testless build
TRUNK › MASTER › #1644 3 weeks ago
TRUNK-5165 ConceptMapTypeEditor does not get object via uuid
ConceptMapTypeEditor does not try getting the object via uuid after it failed
to get it via its id although the service provides the method.
This is usually done (>30 editors for OpenmrsObjects).
3788 passed
TRUNK › MWO › #558 3 weeks ago
TRUNK-5164 Add abstract OpenmrsPropertyEditor
Add abstract OpenmrsPropertyEditor for OpenmrsObject's
which tries to get an object via its id and if that fails via its uuid

Let

CohortEditor.java
ConceptAnswerEditor.java
ConceptAttributeTypeEditor.java
ConceptClassEditor.java
ConceptDatatypeEditor.java
ConceptEditor.java
ConceptNameEditor.java
ConceptNumericEditor.java
ConceptSourceEditor.java
DrugEditor.java
EncounterEditor.java
EncounterTypeEditor.java
FormEditor.java
LocationAttributeTypeEditor.java
LocationEditor.java
LocationTagEditor.java
OpenmrsPropertyEditor.java
OrderEditor.java
PatientEditor.java
PatientIdentifierTypeEditor.java
PersonAttributeEditor.java
PersonAttributeTypeEditor.java
ProgramWorkflowEditor.java
ProgramWorkflowStateEditor.java
UserEditor.java
VisitEditor.java
VisitTypeEditor.java

extend OpenmrsPropertyEditor.

The current behavior is not changed as shown by existing tests which
were not changed.
Testless build
TRUNK › MASTER › #1643 3 weeks ago
TRUNK-5164 Add abstract OpenmrsPropertyEditor
Add abstract OpenmrsPropertyEditor for OpenmrsObject's
which tries to get an object via its id and if that fails via its uuid

Let

CohortEditor.java
ConceptAnswerEditor.java
ConceptAttributeTypeEditor.java
ConceptClassEditor.java
ConceptDatatypeEditor.java
ConceptEditor.java
ConceptNameEditor.java
ConceptNumericEditor.java
ConceptSourceEditor.java
DrugEditor.java
EncounterEditor.java
EncounterTypeEditor.java
FormEditor.java
LocationAttributeTypeEditor.java
LocationEditor.java
LocationTagEditor.java
OpenmrsPropertyEditor.java
OrderEditor.java
PatientEditor.java
PatientIdentifierTypeEditor.java
PersonAttributeEditor.java
PersonAttributeTypeEditor.java
ProgramWorkflowEditor.java
ProgramWorkflowStateEditor.java
UserEditor.java
VisitEditor.java
VisitTypeEditor.java

extend OpenmrsPropertyEditor.

The current behavior is not changed as shown by existing tests which
were not changed.
3788 passed
TRUNK › MASTER › #1642 3 weeks ago
TRUNK-5162 Few PropertyEditor getAsText return null if value is null
ConceptAttributeTypeEditor.java
LocationAttributeTypeEditor.java
LocationEditor.java
LocationTagEditor.java

which where the only ones returning null, in ~37 PropertyEditors
3788 passed
Build Completed Code commits Tests
TRUNK › MWO › #487 1 month ago
Fix and clean ConceptValidatorTest
* fix failing test validate_shouldFailIfAnyNameIsAnEmptyString
had wrong assertion
* extract duplicate test setup into setUp method
* make conceptService a member and autowire it
* make concept cd4Count and weight members since they are used multiple
times
* arrange tests in arrange, act, assert way so reading is easier
* add test for when getNames() returns empty list
* fix validate_shouldFailIfTheObjectParameterIsNull
which expects an IAE but from the validator. However the call to
new BindException(null, "concept");

fails since the target object must not be null
Testless build
SON › OPENMRSCOREMASTER › #1213 1 month ago
TRUNK-5137 Add custom hamcrest matcher HasGlobalError
Add a custom hamcrest matcher HasGlobalErrors which enables

assertThat(errors, hasGlobalErrors());
assertThat(errors, hasGlobalErrors("error.null"));

Provide factories which enables the above after static imports of
the matcher.

Show use of matcher in PersonNameValidatorTest and ConceptValidatorTest
1 of 3476 failed
TRUNK › MASTER › #1566 1 month ago
TRUNK-5137 Add custom hamcrest matcher HasGlobalError
Add a custom hamcrest matcher HasGlobalErrors which enables

assertThat(errors, hasGlobalErrors());
assertThat(errors, hasGlobalErrors("error.null"));

Provide factories which enables the above after static imports of
the matcher.

Show use of matcher in PersonNameValidatorTest and ConceptValidatorTest
1 of 3529 failed
SON › OPENMRSCOREMASTER › #1210 1 month ago
Cleanup and add tests to ConceptAttributeTypeValidatorTest
* add setUp method preparing variables needed for tests to remove
duplication in test setup
* split tests for null, empty, whitespace name since they are
independent
* add assertions for error code so we ensure that when devs refactor
the code the user will still get the excpected error message
* move happy path tests to the end, which makes side by side reading of
code and test easy
TRUNK-5135 Deprecate @Verifies
all usages of @Verifies and @verifies were removed in TRUNK-5122
and thus @Verifies is deprecated and flagged using checkstyle
3 of 3452 failed
TRUNK › MWO › #475 2 months ago
Cleanup and add tests to CohortValidatorTest
* add setUp method preparing variables needed for tests to remove
duplication in test setup
* add tests to assert IllegalArgumentException is thrown when
validating null or an instance other than Cohort
Testless build
JAVADOC › TRUNK › #1167 2 months ago
add instructions to checklist in PR template
as new devs creating PRs seem to have trouble
formatting their code, creating a single commit, adding tests, running
their changes and tests through the build process I

* tried to clarify the language/structure of the PR template
* added instructions to the checklist so that if a new devs has doubts
directly has the right resource at hand to check the box in the end
Testless build
SON › OPENMRSCOREMASTER › #1202 2 months ago
add instructions to checklist in PR template
as new devs creating PRs seem to have trouble
formatting their code, creating a single commit, adding tests, running
their changes and tests through the build process I

* tried to clarify the language/structure of the PR template
* added instructions to the checklist so that if a new devs has doubts
directly has the right resource at hand to check the box in the end
Testless build
TRUNK › MASTER › #1481 2 months ago
TRUNK-5085 Merge checkstyle rules with google's
merged our existing checkstyle.xml with google's

* removed their checks for tabs since we use tabs
* added NPathComplexity since it was already actived on codacy
* added CustomImportOrder rule using the Eclipse defaults
* changed the default severity to warning
* explicitly set the severity of rules we had before to error
* MagicNumber is an error but ignored for annotations
* reduced NestedIfDepth to 4 since that smells
* reduced NestedTryDepth to 2 since that smells
3430 passed
TRUNK › MASTER › #1344 7 months ago
TRUNK-4936 Add ConceptSource.uniqueId
* add ConceptSource.uniqueId
* add property to hibernate mapping file ConceptSource.hbm.xml
* ensure ConceptSourceValidator validates max conceptId length
* add liquibase changeset adding the column concept_source.unique_id
with unique constraint (but defaults to null)
* add service method to ConceptService with implementation in
ConceptServiceImpl
* add ConceptDAO method with HibernateDAO implementation
* add tests for the service layer
* add the official registered OID of "SNOMED CT" into its unique_id
column in the standardTestDataset.xml so it can be used in tests
9 of 3407 failed
SON › OPENMRSCOREMASTER › #1013 8 months ago
Clarify ModuleUtil javadoc of matching version methods
Add javadoc explanation about the meaning of the allowed required version
ranges in methods matchRequiredVersions and checkRequiredVersion
TRUNK-4941 Add ModuleUtil.isOpenmrsVersionInVersions()
isOpenmrsVersionInVersions(String ...versions) allows one to check if the current openmrs version
matches an array of versions according to ModuleUtil.matchRequiredVersions
3307 passed
Build Completed Code commits Tests
SON › OPENMRSCOREMASTER › #1214 1 month ago
Fix and clean ConceptValidatorTest
* fix failing test validate_shouldFailIfAnyNameIsAnEmptyString
had wrong assertion
* extract duplicate test setup into setUp method
* make conceptService a member and autowire it
* make concept cd4Count and weight members since they are used multiple
times
* arrange tests in arrange, act, assert way so reading is easier
* add test for when getNames() returns empty list
* fix validate_shouldFailIfTheObjectParameterIsNull
which expects an IAE but from the validator. However the call to
new BindException(null, "concept");

fails since the target object must not be null
3468 passed
TRUNK › MASTER › #1568 1 month ago
Fix and clean ConceptValidatorTest
* fix failing test validate_shouldFailIfAnyNameIsAnEmptyString
had wrong assertion
* extract duplicate test setup into setUp method
* make conceptService a member and autowire it
* make concept cd4Count and weight members since they are used multiple
times
* arrange tests in arrange, act, assert way so reading is easier
* add test for when getNames() returns empty list
* fix validate_shouldFailIfTheObjectParameterIsNull
which expects an IAE but from the validator. However the call to
new BindException(null, "concept");

fails since the target object must not be null
3519 passed
TRUNK › MWO › #476 1 month ago
Cleanup and add tests to ConceptAttributeTypeValidatorTest
* add setUp method preparing variables needed for tests to remove
duplication in test setup
* split tests for null, empty, whitespace name since they are
independent
* add assertions for error code so we ensure that when devs refactor
the code the user will still get the excpected error message
* move happy path tests to the end, which makes side by side reading of
code and test easy
Testless build
TRUNK › MASTER › #1482 2 months ago
Fix license header in checkstyle.xml
3430 passed
TRUNK › MASTER › #1347 7 months ago
TRUNK-4936 Fix integration-test on h2 due to liquibase changeset
Some integration-test's failed on h2 due to the introduced liquibase changeset
for TRUNK-4936. ALTER TABLE sql statement generated by h2 contains a
syntax error. h2 does only seem to handle unique constraints well when
creating the table, or on its own and not when adding the column.

* remove the nested <constraints> element from the changeset
* use addColumn and addUniqueConstraint
3366 passed
RAD › RM › #253 11 months ago
Update RadiologyReportFormController and its tests
cleaned RadiologyReportFormController

* updated javadocs
* remove unnecessary filling of model and view on redirect
* remove modelAttribute name if it is same as default
289 passed
RAD › RM › #136 1 year ago
RAD-178 Change reporting dependency to 0.9.9
* version 0.9.9 of reporting module was released, snapshot is no longer valid.
* fixes failed travis ci builds
256 passed
RAD › RM › #14 1 year ago
Fix observationRequestSegment Modality
adapt the hl7 Observation Request Segment population to new Modality enum
Testless build
TRUNK › MASTER › #809 2 years ago
OpenMRSFormatter stacks enum elements one per line
instead of putting all elements in one line

* improves readability
* leads to good diffs, where added/deleted elements can be spotted right away
3413 passed