TRUNK-5388 Replace deprecated use of ModuleFileParser
with ModuleFileParser(MessageSourceService)

* in ModuleFactory
* in ModuleExtensionsTest

TRUNK-5388 Make ModuleFileParser MessageSourceService dependency explicit
new
* add constructor ModuleFileParser(MessageSourceService) to clearly
state dependencies, which enables easier testing by passing in a mock or
use of a different implementation of a MessageSourceService
* add method ModuleFileParser.parse(File)
* add method ModuleFileparser.parse(InputStream)
which provide the same functionality/use the same implementation
underneath

deprecate
* deprecate all other constructors (3 in total)
* deprecate parse() in favor of parse(File), there is no need to keep
the file as state. This way we can create one parser and reuse it by
just passing in a different file to parse

tests
* move all tests which do not need the Context to be there to the
ModuleFileParserUnitTest which is now BaseContextMockTest and uses mocks
of the MessageSourceService
* one test still needs to stay in the BaseContextSensitive test since
the Context.getLocale() is still called. Did not add Locale as
dependency since I think this specific method getMessage(String key,
Object[] args) should be implementated in the MessageSourceService
as is getMessage(String) which abstracts away the users current locale
for us

TRUNK-5388 Remove duplicate file validation in ModuleFileParser

TRUNK-5388 Replace deprecated use of ModuleFileParser
with ModuleFileParser(MessageSourceService)

* in ModuleFactory
* in ModuleExtensionsTest

TRUNK-5388 Make ModuleFileParser MessageSourceService dependency explicit
new
* add constructor ModuleFileParser(MessageSourceService) to clearly
state dependencies, which enables easier testing by passing in a mock or
use of a different implementation of a MessageSourceService
* add method ModuleFileParser.parse(File)
* add method ModuleFileparser.parse(InputStream)
which provide the same functionality/use the same implementation
underneath

deprecate
* deprecate all other constructors (3 in total)
* deprecate parse() in favor of parse(File), there is no need to keep
the file as state. This way we can create one parser and reuse it by
just passing in a different file to parse

tests
* move all tests which do not need the Context to be there to the
ModuleFileParserUnitTest which is now BaseContextMockTest and uses mocks
of the MessageSourceService
* one test still needs to stay in the BaseContextSensitive test since
the Context.getLocale() is still called. Did not add Locale as
dependency since I think this specific method getMessage(String key,
Object[] args) should be implementated in the MessageSourceService
as is getMessage(String) which abstracts away the users current locale
for us

TRUNK-5388 Remove duplicate file validation in ModuleFileParser

TRUNK-5388 Replace deprecated use of ModuleFileParser
with ModuleFileParser(MessageSourceService)

* in ModuleFactory
* in ModuleExtensionsTest

TRUNK-5388 Make ModuleFileParser MessageSourceService dependency explicit
new
* add constructor ModuleFileParser(MessageSourceService) to clearly
state dependencies, which enables easier testing by passing in a mock or
use of a different implementation of a MessageSourceService
* add method ModuleFileParser.parse(File)
* add method ModuleFileparser.parse(InputStream)
which provide the same functionality/use the same implementation
underneath

deprecate
* deprecate all other constructors (3 in total)
* deprecate parse() in favor of parse(File), there is no need to keep
the file as state. This way we can create one parser and reuse it by
just passing in a different file to parse

tests
* move all tests which do not need the Context to be there to the
ModuleFileParserUnitTest which is now BaseContextMockTest and uses mocks
of the MessageSourceService
* one test still needs to stay in the BaseContextSensitive test since
the Context.getLocale() is still called. Did not add Locale as
dependency since I think this specific method getMessage(String key,
Object[] args) should be implementated in the MessageSourceService
as is getMessage(String) which abstracts away the users current locale
for us

TRUNK-5388 Remove duplicate file validation in ModuleFileParser

Use adminService from test setup in AdminServiceTest
we prepare the adminService in the @Before method for every test so
there is no need to get it from the Context again in each test

Use static imports in AdministrationServiceTest
to improve readability since we use these asserts over and over again
its clearer to read `assertTrue` than `Assert.assertTrue`

TRUNK-5065 Test saving allowed locales without default
add test that shows its not allowed to save a locale list via global
property if the list doesnt contain the default locale currently set.

Set AdminService before each test
let the @Before set the adminService which is under test each time,
tests should be independent

Remove boilerplate javadocs in AdministrationServiceTest
these javadocs are often out of date, just take up space and repeat the
method signature that is under test anyway so navigating to it is easy
already via the test itself

Remove boilerplate javadocs in AdministrationServiceTest
these javadocs are often out of date, just take up space and repeat the
method signature that is under test anyway so navigating to it is easy
already via the test itself

Use static imports in AdministrationServiceTest
to improve readability since we use these asserts over and over again
its clearer to read `assertTrue` than `Assert.assertTrue`

TRUNK-5065 Test saving allowed locales without default
add test that shows its not allowed to save a locale list via global
property if the list doesnt contain the default locale currently set.

Set AdminService before each test
let the @Before set the adminService which is under test each time,
tests should be independent

Use adminService from test setup in AdminServiceTest
we prepare the adminService in the @Before method for every test so
there is no need to get it from the Context again in each test

TRUNK-5065 Test saving allowed locales without default
add test that shows its not allowed to save a locale list via global
property if the list doesnt contain the default locale currently set.

Set AdminService before each test
let the @Before set the adminService which is under test each time,
tests should be independent

Use adminService from test setup in AdminServiceTest
we prepare the adminService in the @Before method for every test so
there is no need to get it from the Context again in each test

Use static imports in AdministrationServiceTest
to improve readability since we use these asserts over and over again
its clearer to read `assertTrue` than `Assert.assertTrue`

Remove boilerplate javadocs in AdministrationServiceTest
these javadocs are often out of date, just take up space and repeat the
method signature that is under test anyway so navigating to it is easy
already via the test itself

Test AdministrationService.addGlobalPropertyListener
by adding a unit test to the AdministrationServiceUnitTest
mocking EventListeners since
AdministrationServiceImpl.addGlobalPropertyListener
simply delegates to the EventListeners which serves its
List<GlobalPropertyListeners> to the public

Test AdministrationService.addGlobalPropertyListener
by adding a unit test to the AdministrationServiceUnitTest
mocking EventListeners since
AdministrationServiceImpl.addGlobalPropertyListener
simply delegates to the EventListeners which serves its
List<GlobalPropertyListeners> to the public

Add missing tests for Module.getExtensions()
* add tests to achieve full coverage of getExtensions()
* use a more realisitc setup as Module follows in its creation
via ModuleFileParser

Turn ModuleExtensionsTest into unit tests
ModuleExtensionsTest uses powermock and asserts on private methods which
is not needed as we can assert on the resulting List of Extensions
whether the extension names are expanded

TRUNK-5298 Add .editorconfig to force use of tabs in IDEs
IntelliJ, Visual Studio Code and other IDEs/Editors support editorconfig
files out of the box, others like Eclipse, Atom, Sublime, Vim need a
plugin.

should help to reduce the spaces/tabs mess we are
currently seeing.

http://editorconfig.org/#overview

TRUNK-5137 Add custom hamcrest matcher HasGlobalError
Add a custom hamcrest matcher HasGlobalErrors which enables

assertThat(errors, hasGlobalErrors());
assertThat(errors, hasGlobalErrors("error.null"));

Provide factories which enables the above after static imports of
the matcher.

Show use of matcher in PersonNameValidatorTest and ConceptValidatorTest

TRUNK-5137 Add custom hamcrest matcher HasGlobalError
Add a custom hamcrest matcher HasGlobalErrors which enables

assertThat(errors, hasGlobalErrors());
assertThat(errors, hasGlobalErrors("error.null"));

Provide factories which enables the above after static imports of
the matcher.

Show use of matcher in PersonNameValidatorTest and ConceptValidatorTest

TRUNK-5135 Deprecate @Verifies
all usages of @Verifies and @verifies were removed in TRUNK-5122
and thus @Verifies is deprecated and flagged using checkstyle

Cleanup and add tests to ConceptAttributeTypeValidatorTest
* add setUp method preparing variables needed for tests to remove
duplication in test setup
* split tests for null, empty, whitespace name since they are
independent
* add assertions for error code so we ensure that when devs refactor
the code the user will still get the excpected error message
* move happy path tests to the end, which makes side by side reading of
code and test easy

add instructions to checklist in PR template
as new devs creating PRs seem to have trouble
formatting their code, creating a single commit, adding tests, running
their changes and tests through the build process I

* tried to clarify the language/structure of the PR template
* added instructions to the checklist so that if a new devs has doubts
directly has the right resource at hand to check the box in the end

add instructions to checklist in PR template
as new devs creating PRs seem to have trouble
formatting their code, creating a single commit, adding tests, running
their changes and tests through the build process I

* tried to clarify the language/structure of the PR template
* added instructions to the checklist so that if a new devs has doubts
directly has the right resource at hand to check the box in the end

TRUNK-5085 Merge checkstyle rules with google's
merged our existing checkstyle.xml with google's

* removed their checks for tabs since we use tabs
* added NPathComplexity since it was already actived on codacy
* added CustomImportOrder rule using the Eclipse defaults
* changed the default severity to warning
* explicitly set the severity of rules we had before to error
* MagicNumber is an error but ignored for annotations
* reduced NestedIfDepth to 4 since that smells
* reduced NestedTryDepth to 2 since that smells

TRUNK-4936 Add ConceptSource.uniqueId
* add ConceptSource.uniqueId
* add property to hibernate mapping file ConceptSource.hbm.xml
* ensure ConceptSourceValidator validates max conceptId length
* add liquibase changeset adding the column concept_source.unique_id
with unique constraint (but defaults to null)
* add service method to ConceptService with implementation in
ConceptServiceImpl
* add ConceptDAO method with HibernateDAO implementation
* add tests for the service layer
* add the official registered OID of "SNOMED CT" into its unique_id
column in the standardTestDataset.xml so it can be used in tests

Clarify ModuleUtil javadoc of matching version methods
Add javadoc explanation about the meaning of the allowed required version
ranges in methods matchRequiredVersions and checkRequiredVersion

TRUNK-4941 Add ModuleUtil.isOpenmrsVersionInVersions()
isOpenmrsVersionInVersions(String ...versions) allows one to check if the current openmrs version
matches an array of versions according to ModuleUtil.matchRequiredVersions

Fix and clean ConceptValidatorTest
* fix failing test validate_shouldFailIfAnyNameIsAnEmptyString
had wrong assertion
* extract duplicate test setup into setUp method
* make conceptService a member and autowire it
* make concept cd4Count and weight members since they are used multiple
times
* arrange tests in arrange, act, assert way so reading is easier
* add test for when getNames() returns empty list
* fix validate_shouldFailIfTheObjectParameterIsNull
which expects an IAE but from the validator. However the call to
new BindException(null, "concept");

fails since the target object must not be null

Fix and clean ConceptValidatorTest
* fix failing test validate_shouldFailIfAnyNameIsAnEmptyString
had wrong assertion
* extract duplicate test setup into setUp method
* make conceptService a member and autowire it
* make concept cd4Count and weight members since they are used multiple
times
* arrange tests in arrange, act, assert way so reading is easier
* add test for when getNames() returns empty list
* fix validate_shouldFailIfTheObjectParameterIsNull
which expects an IAE but from the validator. However the call to
new BindException(null, "concept");

fails since the target object must not be null

Fix license header in checkstyle.xml

TRUNK-4936 Fix integration-test on h2 due to liquibase changeset
Some integration-test's failed on h2 due to the introduced liquibase changeset
for TRUNK-4936. ALTER TABLE sql statement generated by h2 contains a
syntax error. h2 does only seem to handle unique constraints well when
creating the table, or on its own and not when adding the column.

* remove the nested <constraints> element from the changeset
* use addColumn and addUniqueConstraint

Update RadiologyReportFormController and its tests
cleaned RadiologyReportFormController

* updated javadocs
* remove unnecessary filling of model and view on redirect
* remove modelAttribute name if it is same as default

RAD-178 Change reporting dependency to 0.9.9
* version 0.9.9 of reporting module was released, snapshot is no longer valid.
* fixes failed travis ci builds

Fix observationRequestSegment Modality
adapt the hl7 Observation Request Segment population to new Modality enum

OpenMRSFormatter stacks enum elements one per line
instead of putting all elements in one line

* improves readability
* leads to good diffs, where added/deleted elements can be spotted right away