TRUNK-5096 Remove MemoryLeakUtil.shutdownKeepAliveTimer
Remove MemoryLeakUtil.shutdownKeepAliveTimer since its implementation
is based on a non-existing field and throws an exception on its first
line; also thereby remove a dependency on a sun package

Add UpdateFilterModelTest
add UpdateFilterModelTest since it was missing; needed to uses
PowerMockRunner since its calling static methods on DatabaseUpdater

TRUNK-5174 Deprecate PersonNameValidator.validatePersonName
PersonNameValidator implements Validator so client code can call
validate to get the same behavior as calling validatePersonName which
should be made private in a major release

Add StartupErrorFilterTest
add StartupErrorFilterTest since it didnt exist,
use PowerMockRunner as the filter calls static methods

Add UpdateFilterModelTest
add UpdateFilterModelTest since it was missing; needed to uses
PowerMockRunner since its calling static methods on DatabaseUpdater

TRUNK-5174 Deprecate PersonNameValidator.validatePersonName
PersonNameValidator implements Validator so client code can call
validate to get the same behavior as calling validatePersonName which
should be made private in a major release

Add StartupErrorFilterTest
add StartupErrorFilterTest since it didnt exist,
use PowerMockRunner as the filter calls static methods

TRUNK-5096 Remove MemoryLeakUtil.shutdownKeepAliveTimer
Remove MemoryLeakUtil.shutdownKeepAliveTimer since its implementation
is based on a non-existing field and throws an exception on its first
line; also thereby remove a dependency on a sun package

Add StartupErrorFilterTest
add StartupErrorFilterTest since it didnt exist,
use PowerMockRunner as the filter calls static methods

Add StartupErrorFilterTest
add StartupErrorFilterTest since it didnt exist,
use PowerMockRunner as the filter calls static methods

Add UpdateFilterModelTest
add UpdateFilterModelTest since it was missing; needed to uses
PowerMockRunner since its calling static methods on DatabaseUpdater

Add UpdateFilterModelTest
add UpdateFilterModelTest since it was missing; needed to uses
PowerMockRunner since its calling static methods on DatabaseUpdater

TRUNK-5174 Deprecate PersonNameValidator.validatePersonName
use the PersonNameValidator.validate coming from the Validator
interface since validatePersonName is deprecated in core 2.2.0
PersonNameValidator.validate itself calls

validatePersonName(personName, errors, false, true)

the behavior does not change through this change

TRUNK-5174 Deprecate PersonNameValidator.validatePersonName
PersonNameValidator implements Validator so client code can call
validate to get the same behavior as calling validatePersonName which
should be made private in a major release

TRUNK-5174 Deprecate PersonNameValidator.validatePersonName
PersonNameValidator implements Validator so client code can call
validate to get the same behavior as calling validatePersonName which
should be made private in a major release

TRUNK-5096 Remove MemoryLeakUtil.shutdownKeepAliveTimer
Remove MemoryLeakUtil.shutdownKeepAliveTimer since its implementation
is based on a non-existing field and throws an exception on its first
line; also thereby remove a dependency on a sun package

Fix and clean ConceptValidatorTest
* fix failing test validate_shouldFailIfAnyNameIsAnEmptyString
had wrong assertion
* extract duplicate test setup into setUp method
* make conceptService a member and autowire it
* make concept cd4Count and weight members since they are used multiple
times
* arrange tests in arrange, act, assert way so reading is easier
* add test for when getNames() returns empty list
* fix validate_shouldFailIfTheObjectParameterIsNull
which expects an IAE but from the validator. However the call to
new BindException(null, "concept");

fails since the target object must not be null

TRUNK-5137 Add custom hamcrest matcher HasGlobalError
Add a custom hamcrest matcher HasGlobalErrors which enables

assertThat(errors, hasGlobalErrors());
assertThat(errors, hasGlobalErrors("error.null"));

Provide factories which enables the above after static imports of
the matcher.

Show use of matcher in PersonNameValidatorTest and ConceptValidatorTest

TRUNK-5137 Add custom hamcrest matcher HasGlobalError
Add a custom hamcrest matcher HasGlobalErrors which enables

assertThat(errors, hasGlobalErrors());
assertThat(errors, hasGlobalErrors("error.null"));

Provide factories which enables the above after static imports of
the matcher.

Show use of matcher in PersonNameValidatorTest and ConceptValidatorTest

Cleanup and add tests to ConceptAttributeTypeValidatorTest
* add setUp method preparing variables needed for tests to remove
duplication in test setup
* split tests for null, empty, whitespace name since they are
independent
* add assertions for error code so we ensure that when devs refactor
the code the user will still get the excpected error message
* move happy path tests to the end, which makes side by side reading of
code and test easy

TRUNK-5135 Deprecate @Verifies
all usages of @Verifies and @verifies were removed in TRUNK-5122
and thus @Verifies is deprecated and flagged using checkstyle

Cleanup and add tests to CohortValidatorTest
* add setUp method preparing variables needed for tests to remove
duplication in test setup
* add tests to assert IllegalArgumentException is thrown when
validating null or an instance other than Cohort

add instructions to checklist in PR template
as new devs creating PRs seem to have trouble
formatting their code, creating a single commit, adding tests, running
their changes and tests through the build process I

* tried to clarify the language/structure of the PR template
* added instructions to the checklist so that if a new devs has doubts
directly has the right resource at hand to check the box in the end

add instructions to checklist in PR template
as new devs creating PRs seem to have trouble
formatting their code, creating a single commit, adding tests, running
their changes and tests through the build process I

* tried to clarify the language/structure of the PR template
* added instructions to the checklist so that if a new devs has doubts
directly has the right resource at hand to check the box in the end

TRUNK-5085 Merge checkstyle rules with google's
merged our existing checkstyle.xml with google's

* removed their checks for tabs since we use tabs
* added NPathComplexity since it was already actived on codacy
* added CustomImportOrder rule using the Eclipse defaults
* changed the default severity to warning
* explicitly set the severity of rules we had before to error
* MagicNumber is an error but ignored for annotations
* reduced NestedIfDepth to 4 since that smells
* reduced NestedTryDepth to 2 since that smells

TRUNK-4936 Add ConceptSource.uniqueId
* add ConceptSource.uniqueId
* add property to hibernate mapping file ConceptSource.hbm.xml
* ensure ConceptSourceValidator validates max conceptId length
* add liquibase changeset adding the column concept_source.unique_id
with unique constraint (but defaults to null)
* add service method to ConceptService with implementation in
ConceptServiceImpl
* add ConceptDAO method with HibernateDAO implementation
* add tests for the service layer
* add the official registered OID of "SNOMED CT" into its unique_id
column in the standardTestDataset.xml so it can be used in tests

Clarify ModuleUtil javadoc of matching version methods
Add javadoc explanation about the meaning of the allowed required version
ranges in methods matchRequiredVersions and checkRequiredVersion

TRUNK-4941 Add ModuleUtil.isOpenmrsVersionInVersions()
isOpenmrsVersionInVersions(String ...versions) allows one to check if the current openmrs version
matches an array of versions according to ModuleUtil.matchRequiredVersions

Fix and clean ConceptValidatorTest
* fix failing test validate_shouldFailIfAnyNameIsAnEmptyString
had wrong assertion
* extract duplicate test setup into setUp method
* make conceptService a member and autowire it
* make concept cd4Count and weight members since they are used multiple
times
* arrange tests in arrange, act, assert way so reading is easier
* add test for when getNames() returns empty list
* fix validate_shouldFailIfTheObjectParameterIsNull
which expects an IAE but from the validator. However the call to
new BindException(null, "concept");

fails since the target object must not be null

Fix and clean ConceptValidatorTest
* fix failing test validate_shouldFailIfAnyNameIsAnEmptyString
had wrong assertion
* extract duplicate test setup into setUp method
* make conceptService a member and autowire it
* make concept cd4Count and weight members since they are used multiple
times
* arrange tests in arrange, act, assert way so reading is easier
* add test for when getNames() returns empty list
* fix validate_shouldFailIfTheObjectParameterIsNull
which expects an IAE but from the validator. However the call to
new BindException(null, "concept");

fails since the target object must not be null

Cleanup and add tests to ConceptAttributeTypeValidatorTest
* add setUp method preparing variables needed for tests to remove
duplication in test setup
* split tests for null, empty, whitespace name since they are
independent
* add assertions for error code so we ensure that when devs refactor
the code the user will still get the excpected error message
* move happy path tests to the end, which makes side by side reading of
code and test easy

Fix license header in checkstyle.xml

TRUNK-4936 Fix integration-test on h2 due to liquibase changeset
Some integration-test's failed on h2 due to the introduced liquibase changeset
for TRUNK-4936. ALTER TABLE sql statement generated by h2 contains a
syntax error. h2 does only seem to handle unique constraints well when
creating the table, or on its own and not when adding the column.

* remove the nested <constraints> element from the changeset
* use addColumn and addUniqueConstraint

Update RadiologyReportFormController and its tests
cleaned RadiologyReportFormController

* updated javadocs
* remove unnecessary filling of model and view on redirect
* remove modelAttribute name if it is same as default

RAD-178 Change reporting dependency to 0.9.9
* version 0.9.9 of reporting module was released, snapshot is no longer valid.
* fixes failed travis ci builds

Fix observationRequestSegment Modality
adapt the hl7 Observation Request Segment population to new Modality enum

OpenMRSFormatter stacks enum elements one per line
instead of putting all elements in one line

* improves readability
* leads to good diffs, where added/deleted elements can be spotted right away