Build #795

Plan branch:

Build: #795 was successful Scheduled with changes by 7 people

Code commits

openmrs-core master

  • achilep <you@example.com>

    achilep <you@example.com> a8905ca49ba5023e84b25ec4d8416dc3b69274f0

    TRUNK-5816: Migrate api package tests to Junit 5

    • api/src/test/java/liquibase/ext/change/core/InsertWithUuidDataChangeDatabaseIT.java (version a8905ca49ba5023e84b25ec4d8416dc3b69274f0)
    • api/src/test/java/org/openmrs/liquibase/ChangeLogDetectiveDatabaseIT.java (version a8905ca49ba5023e84b25ec4d8416dc3b69274f0)
    • api/src/test/java/org/openmrs/util/H2DatabaseIT.java (version a8905ca49ba5023e84b25ec4d8416dc3b69274f0)
  • teleivo <teleivo@users.noreply.github.com>

    teleivo <teleivo@users.noreply.github.com> 5bdf7a11398f3eaf988f47b1463c247a788ebb6f

    TRUNK-5816 Fix PersonServiceTest compilation
    somehow one Assert. was not replaced

    • api/src/test/java/org/openmrs/api/PersonServiceTest.java (version 5bdf7a11398f3eaf988f47b1463c247a788ebb6f)
  • achilep <39851246+achilep@users.noreply.github.com>

    achilep <39851246+achilep@users.noreply.github.com> 72a584d0a3b07712be7bc4431b997fbafbc1fe28

    TRUNK-5816: Migrate api package tests to Junit5 4 (#3360)
    TRUNK-5816: Migrate api package tests to Junit 5

    Co-authored-by: achilep <you@example.com>
    Co-authored-by: Ivo <teleivo@users.noreply.github.com>

    • api/src/test/java/org/openmrs/api/ConceptServiceTest.java (version 72a584d0a3b07712be7bc4431b997fbafbc1fe28)
    • api/src/test/java/org/openmrs/api/EncounterServiceTest.java (version 72a584d0a3b07712be7bc4431b997fbafbc1fe28)
    • api/src/test/java/org/openmrs/api/LocationServiceTest.java (version 72a584d0a3b07712be7bc4431b997fbafbc1fe28)
    • api/src/test/java/org/openmrs/api/ObsServiceTest.java (version 72a584d0a3b07712be7bc4431b997fbafbc1fe28)
    • api/src/test/java/org/openmrs/api/OrderServiceTest.java (version 72a584d0a3b07712be7bc4431b997fbafbc1fe28)
    • api/src/test/java/org/openmrs/api/OrderSetServiceTest.java (version 72a584d0a3b07712be7bc4431b997fbafbc1fe28)
    • api/src/test/java/org/openmrs/api/PatientServiceAllergyTest.java (version 72a584d0a3b07712be7bc4431b997fbafbc1fe28)
    • api/src/test/java/org/openmrs/api/PersonServiceTest.java (version 72a584d0a3b07712be7bc4431b997fbafbc1fe28)
    • api/src/test/java/org/openmrs/api/ProgramWorkflowServiceTest.java (version 72a584d0a3b07712be7bc4431b997fbafbc1fe28)
    • api/src/test/java/org/openmrs/api/UserServiceTest.java (version 72a584d0a3b07712be7bc4431b997fbafbc1fe28)
    • api/src/test/java/org/openmrs/api/impl/ConceptServiceImplTest.java (version 72a584d0a3b07712be7bc4431b997fbafbc1fe28)
    • api/src/test/java/org/openmrs/hl7/handler/ORUR01HandlerTest.java (version 72a584d0a3b07712be7bc4431b997fbafbc1fe28)
  • achilep <you@example.com>

    achilep <you@example.com> aa598541834154d728256478ad10e1fcc7ecc4f2

    TRUNK-5816: Migrate api package tests to Junit5

    • api/src/test/java/org/openmrs/annotation/OpenmrsProfileExcludeFilterTest.java (version aa598541834154d728256478ad10e1fcc7ecc4f2)
    • api/src/test/java/org/openmrs/annotation/OpenmrsProfileIncludeFilterTest.java (version aa598541834154d728256478ad10e1fcc7ecc4f2)
    • api/src/test/java/org/openmrs/api/db/ContextDAOTest.java (version aa598541834154d728256478ad10e1fcc7ecc4f2)
    • api/src/test/java/org/openmrs/api/db/EncounterDAOTest.java (version aa598541834154d728256478ad10e1fcc7ecc4f2)
    • api/src/test/java/org/openmrs/api/db/PatientDAOTest.java (version aa598541834154d728256478ad10e1fcc7ecc4f2)
    • api/src/test/java/org/openmrs/api/db/PersonDAOTest.java (version aa598541834154d728256478ad10e1fcc7ecc4f2)
    • api/src/test/java/org/openmrs/api/db/ProgramWorkflowDAOTest.java (version aa598541834154d728256478ad10e1fcc7ecc4f2)
    • api/src/test/java/org/openmrs/api/db/SerializedObjectDAOTest.java (version aa598541834154d728256478ad10e1fcc7ecc4f2)
    • api/src/test/java/org/openmrs/api/db/UserDAOTest.java (version aa598541834154d728256478ad10e1fcc7ecc4f2)
  • HerbertYiga <herbertyiga@gmail.com>

    HerbertYiga <herbertyiga@gmail.com> df3b2c17e97529ae88c98a693e74ade180df1f55

    TRUNK-5064:Added untested methods for PersonServiceImpl (#3285)
    Co-authored-by: Ian <52504170+ibacher@users.noreply.github.com>

    • api/src/test/java/org/openmrs/api/PersonServiceTest.java (version df3b2c17e97529ae88c98a693e74ade180df1f55)
  • ?ukasz D?bicki <sacull@gmail.com>

    ?ukasz D?bicki <sacull@gmail.com> a2f8924c6ef5e1680fbf3d9a85af667af7d192ac

    TRUNK-5854: Change of object type to primitive (#3349)

    • api/src/main/java/org/openmrs/module/UpdateFileParser.java (version a2f8924c6ef5e1680fbf3d9a85af667af7d192ac)
  • dkayiwa <kayiwadaniel@gmail.com>

    dkayiwa <kayiwadaniel@gmail.com> c827c54e7e4fc696aa3b818810993b477d31d43f

    TRUNK-5816 Switching expected and actual

    • api/src/test/java/org/openmrs/api/UserServiceTest.java (version c827c54e7e4fc696aa3b818810993b477d31d43f)
  • ?ukasz D?bicki <sacull@gmail.com>

    ?ukasz D?bicki <sacull@gmail.com> bf541f6616d12d60fa3db679e9f57405275a3c98

    TRUNK-5847: Javadoc improvement (#3351)

    • api/src/main/java/org/openmrs/Allergy.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/CohortMembership.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/Drug.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/Obs.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/Order.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/OrderGroup.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/RelationshipType.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/api/ObsService.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/api/OrderService.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/api/UserService.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/api/context/Daemon.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/api/context/DaoAuthenticationScheme.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/api/context/UserContext.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/api/impl/ProgramWorkflowServiceImpl.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/api/impl/UserServiceImpl.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/customdatatype/datatype/BaseMetadataDatatype.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/customdatatype/datatype/ConceptDatatype.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/hl7/db/HL7DAO.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/logic/LogicContext.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/scheduler/db/hibernate/HibernateSchedulerDAO.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/scheduler/tasks/AlertReminderTask.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/util/Graph.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/util/OpenmrsConstants.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/util/OpenmrsUtil.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • api/src/main/java/org/openmrs/util/Security.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • web/src/main/java/org/openmrs/web/filter/initialization/InitializationFilter.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
    • web/src/main/java/org/openmrs/web/filter/update/UpdateFilter.java (version bf541f6616d12d60fa3db679e9f57405275a3c98)
  • teleivo <teleivo@users.noreply.github.com>

    teleivo <teleivo@users.noreply.github.com> ee01136e97c58e6616336f79756ca8d9faaeb7e2

    TRUNK-5816 Make BasePropertyEditorTest package private
    to prevent usages outside the package and convey its only used as a
    helper for PropertyEditorTests in openmrs-core

    • api/src/test/java/org/openmrs/propertyeditor/BasePropertyEditorTest.java (version ee01136e97c58e6616336f79756ca8d9faaeb7e2)
  • teleivo <teleivo@users.noreply.github.com>

    teleivo <teleivo@users.noreply.github.com> 0b16dd5046c6ce70242da2e9f7017dba329af6df

    TRUNK-5816 Support only JUnit 5 BasePropertyEditorTest
    as this class is used internally in openmrs-core only we do not need to
    provide it in JUnit 4 and 5 as long as we migrated all tests using it to
    JUnit 5 which we did

    • api/src/test/java/org/openmrs/propertyeditor/BasePropertyEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/CohortEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/ConceptAnswerEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/ConceptAttributeTypeEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/ConceptClassEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/ConceptDatatypeEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/ConceptEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/ConceptMapTypeEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/ConceptNameEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/ConceptNumericEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/ConceptReferenceTermEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/ConceptSourceEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/DrugEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/EncounterEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/EncounterTypeEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/FormEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/LocationAttributeTypeEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/LocationEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/LocationTagEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/OrderEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/PatientEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/PatientIdentifierTypeEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/PersonAttributeEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/PersonAttributeTypeEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/PersonEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/ProgramWorkflowEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/ProgramWorkflowStateEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/ProviderEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/UserEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/VisitEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/VisitTypeEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
    • api/src/test/java/org/openmrs/propertyeditor/jupiter/BasePropertyEditorTest.java (version 0b16dd5046c6ce70242da2e9f7017dba329af6df)
  • Am-Coder <39997970+Am-Coder@users.noreply.github.com>

    Am-Coder <39997970+Am-Coder@users.noreply.github.com> dca5529e94f56557dce8d651057f319ed5a4c61f

    TRUNK-5864 UUID functions support for PostgreSQL (#3363)

    • api/src/main/resources/org/openmrs/liquibase/updates/liquibase-update-to-latest-2.4.x.xml (version dca5529e94f56557dce8d651057f319ed5a4c61f)
  • teleivo <teleivo@users.noreply.github.com>

    teleivo <teleivo@users.noreply.github.com> 3d65c92aa9449b6e6ada30847d9639d9dfd24990

    Use assertEquals for better error messages
    when the test fails we only get expected true but was false with
    assertTrue. We loose information in these specific cases because knowing
    what the actual value was might help us fix the issue faster. Locally
    but also more importantly on a PR or push to master when looking at the
    CI logs.

    • api/src/test/java/org/openmrs/PatientStateTest.java (version 3d65c92aa9449b6e6ada30847d9639d9dfd24990)
    • api/src/test/java/org/openmrs/PatientTest.java (version 3d65c92aa9449b6e6ada30847d9639d9dfd24990)
    • api/src/test/java/org/openmrs/api/CohortServiceTest.java (version 3d65c92aa9449b6e6ada30847d9639d9dfd24990)
    • api/src/test/java/org/openmrs/api/OrderServiceTest.java (version 3d65c92aa9449b6e6ada30847d9639d9dfd24990)
    • api/src/test/java/org/openmrs/api/context/ContextTest.java (version 3d65c92aa9449b6e6ada30847d9639d9dfd24990)
    • api/src/test/java/org/openmrs/patient/impl/VerhoeffIdentifierValidatorTest.java (version 3d65c92aa9449b6e6ada30847d9639d9dfd24990)
    • api/src/test/java/org/openmrs/serialization/SimpleXStreamSerializerTest.java (version 3d65c92aa9449b6e6ada30847d9639d9dfd24990)
    • api/src/test/java/org/openmrs/util/PersonByNameComparatorTest.java (version 3d65c92aa9449b6e6ada30847d9639d9dfd24990)
    • api/src/test/java/org/openmrs/util/ProviderByPersonNameComparatorTest.java (version 3d65c92aa9449b6e6ada30847d9639d9dfd24990)
  • teleivo <teleivo@users.noreply.github.com>

    teleivo <teleivo@users.noreply.github.com> 66ef7a998c51c5d7b67065d3d7896f82f828e1ec

    assertNull for null checks
    is the appropriate assertion

    • api/src/test/java/org/openmrs/PatientProgramTest.java (version 66ef7a998c51c5d7b67065d3d7896f82f828e1ec)
    • api/src/test/java/org/openmrs/api/OrderServiceTest.java (version 66ef7a998c51c5d7b67065d3d7896f82f828e1ec)
  • achilep <you@example.com>

    achilep <you@example.com> 3a7d59c9e464c09d691bdac61516853ecbfdd862

    TRUNK-5816: Migrate api package tests to Junit 5

    • api/src/test/java/org/openmrs/api/ProgramWorkflowServiceUnitTest.java (version 3a7d59c9e464c09d691bdac61516853ecbfdd862)
    • api/src/test/java/org/openmrs/api/ProviderServiceTest.java (version 3a7d59c9e464c09d691bdac61516853ecbfdd862)
    • api/src/test/java/org/openmrs/api/UserServiceTest.java (version 3a7d59c9e464c09d691bdac61516853ecbfdd862)
    • api/src/test/java/org/openmrs/hl7/HL7ServiceTest.java (version 3a7d59c9e464c09d691bdac61516853ecbfdd862)
    • api/src/test/java/org/openmrs/module/ModuleFileParserTest.java (version 3a7d59c9e464c09d691bdac61516853ecbfdd862)
  • teleivo <teleivo@users.noreply.github.com>

    teleivo <teleivo@users.noreply.github.com> 47e6b20ed9b8730a62851776f3e9be8f550f8b2f

    TRUNK-5140 Fix validator test of obs.value_complex column
    now that its can have 1000 chars we need to provide more than that to
    see that the validation flags this field

    • api/src/test/java/org/openmrs/validator/ObsValidatorTest.java (version 47e6b20ed9b8730a62851776f3e9be8f550f8b2f)