Git

• 

  Paradise Kelechi <paradisekelechi@gmail.com> 09 Apr 2018 f793961fc0ade6b113d2c49d13f8cae3f844c1ae

  TRUNK-5338: make verification_status field nullable for the condition table (#2651)

  • api/src/main/resources/liquibase-update-to-2.2.xml (version f793961fc0ade6b113d2c49d13f8cae3f844c1ae)
• 

  teleivo <mrteleivo@gmail.com> 09 Apr 2018 dc33df6a5a49c2c60002b6e1591fe520ca0daadf

  TRUNK-5065 Test saving allowed locales without default
  add test that shows its not allowed to save a locale list via global
  property if the list doesnt contain the default locale currently set.

  • api/src/test/java/org/openmrs/api/AdministrationServiceTest.java (version dc33df6a5a49c2c60002b6e1591fe520ca0daadf)
• 

  teleivo <mrteleivo@gmail.com> 09 Apr 2018 0ac584076afb0857ab8c678c5bff47b4e70a26e2

  Use adminService from test setup in AdminServiceTest
  we prepare the adminService in the @Before method for every test so
  there is no need to get it from the Context again in each test

  • api/src/test/java/org/openmrs/api/AdministrationServiceTest.java (version 0ac584076afb0857ab8c678c5bff47b4e70a26e2)
• 

  teleivo <mrteleivo@gmail.com> 09 Apr 2018 baa0e6cbe90c3e830aa815581e30791fe6ef61cf

  Set AdminService before each test
  let the @Before set the adminService which is under test each time,
  tests should be independent

  • api/src/test/java/org/openmrs/api/AdministrationServiceTest.java (version baa0e6cbe90c3e830aa815581e30791fe6ef61cf)
• 

  teleivo <mrteleivo@gmail.com> 09 Apr 2018 b021f87163efec4df91e652edcb53f6ec660242f

  Remove boilerplate javadocs in AdministrationServiceTest
  these javadocs are often out of date, just take up space and repeat the
  method signature that is under test anyway so navigating to it is easy
  already via the test itself

  • api/src/test/java/org/openmrs/api/AdministrationServiceTest.java (version b021f87163efec4df91e652edcb53f6ec660242f)
• 

  teleivo <mrteleivo@gmail.com> 09 Apr 2018 2a3c1b7bdd6647d688e497cd3f556ba232c950a0

  Use static imports in AdministrationServiceTest
  to improve readability since we use these asserts over and over again
  its clearer to read `assertTrue` than `Assert.assertTrue`

  • api/src/test/java/org/openmrs/api/AdministrationServiceTest.java (version 2a3c1b7bdd6647d688e497cd3f556ba232c950a0)