Build: #1213 failed
Job: Sonar Full Analysis failed
Code commits
Git
-
Lluis Martinez <lluismf@gmail.com> 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6
More throws Exception removed
- api/src/test/java/org/openmrs/DrugOrderTest.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
- api/src/test/java/org/openmrs/PersonTest.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
- api/src/test/java/org/openmrs/SimpleDosingInstructionsTest.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
- api/src/test/java/org/openmrs/TestOrderTest.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
- api/src/test/java/org/openmrs/api/PersonServiceTest.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
- api/src/test/java/org/openmrs/api/UserServiceTest.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
- api/src/test/java/org/openmrs/api/db/PatientDAOTest.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
- api/src/test/java/org/openmrs/api/db/hibernate/ImmutableEntityInterceptorTest.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
- api/src/test/java/org/openmrs/hl7/HL7ServiceTest.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
- api/src/test/java/org/openmrs/logic/result/ResultTest.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
- api/src/test/java/org/openmrs/order/OrderUtilTest.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
- api/src/test/java/org/openmrs/serialization/JavaSerializationTest.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
- api/src/test/java/org/openmrs/test/BaseContextSensitiveTest.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
- api/src/test/java/org/openmrs/test/TestUtil.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
- api/src/test/java/org/openmrs/validator/DrugOrderValidatorTest.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
- api/src/test/java/org/openmrs/validator/ImplementationIdValidatorTest.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
- api/src/test/java/org/openmrs/validator/RoleValidatorTest.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
- web/src/main/java/org/openmrs/web/filter/update/UpdateFilter.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
- web/src/test/java/org/openmrs/web/filter/update/UpdateFilterTest.java (version 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6)
-
Ivo Ulrich <teleivo@users.noreply.github.com> 88b8255073ba16c1072403462f4736134c3b23c9
Merge pull request #2120 from teleivo/globalerrors-matcher
TRUNK-5137 Add custom hamcrest matcher HasGlobalError -
Ivo Ulrich <teleivo@users.noreply.github.com> e58f93aa310ddce0ab59d481fec48e72391eddfb
Merge pull request #2119 from DataMinerUK/TRUNK-248
TRUNK-248 Add tests for junit TODOs -
teleivo <mrteleivo@gmail.com> ab5b9ac57be9a7935262a0ba62852c957445f1fe
TRUNK-5137 Add custom hamcrest matcher HasGlobalError
Add a custom hamcrest matcher HasGlobalErrors which enables
assertThat(errors, hasGlobalErrors());
assertThat(errors, hasGlobalErrors("error.null"));
Provide factories which enables the above after static imports of
the matcher.
Show use of matcher in PersonNameValidatorTest and ConceptValidatorTest- api/src/test/java/org/openmrs/test/matchers/HasGlobalErrors.java (version ab5b9ac57be9a7935262a0ba62852c957445f1fe)
- api/src/test/java/org/openmrs/test/matchers/HasGlobalErrorsTest.java (version ab5b9ac57be9a7935262a0ba62852c957445f1fe)
- api/src/test/java/org/openmrs/validator/ConceptValidatorTest.java (version ab5b9ac57be9a7935262a0ba62852c957445f1fe)
- api/src/test/java/org/openmrs/validator/PersonNameValidatorTest.java (version ab5b9ac57be9a7935262a0ba62852c957445f1fe)
-
Nicola Hughes <nihughes@thoughtworks.com> 8d9af2c31a96860ca5c3e68acdd461defb0668a2
TRUNK-248 Refactoring LocationEditor to get text if text not null and improving test coverage
Authors: @DataMinerUK @matmoore- api/src/main/java/org/openmrs/propertyeditor/LocationEditor.java (version 8d9af2c31a96860ca5c3e68acdd461defb0668a2)
- api/src/test/java/org/openmrs/propertyeditor/LocationEditorTest.java (version 8d9af2c31a96860ca5c3e68acdd461defb0668a2)
-
Ivo Ulrich <teleivo@users.noreply.github.com> e7fb074c40150458b86795de7dd47fb7d9c78197
Merge pull request #2118 from annashipman/TRUNK-248
TRUNK-248: Remove TODO from deprecated and unused code -
Anna Shipman <anna@annashipman.co.uk> f884591b3ac6ff962add17dc1f2823032d399e73
Remove TODO from deprecated class
The `PatientSearchCriteria` class is deprecated. This TODO is on a private method, called by another private method, called by the helper method `prepareCriteria`. This method is only called in one place, `HibernateEnounterDAO` which doesn't pass in the parameter that would lead to this line of code being executed.
Therefore, we think the code is not used and the test is not required.
@annashipman @davbo @TheDoubleK- api/src/main/java/org/openmrs/api/db/hibernate/PatientSearchCriteria.java (version f884591b3ac6ff962add17dc1f2823032d399e73)
-
Ivo Ulrich <teleivo@users.noreply.github.com> 63447994445a90b09e488372a801630905422025
Merge pull request #2116 from vixus0/trunk-248
TRUNK-248: Add junit tests for HibernatePatientDAO -
Anshul Sirur <anshul.sirur@digital.cabinet-office.gov.uk> c5e5a6c21d5159c43de40ce192dfb382297ed6f9
TRUNK-248: Add junit tests for HibernatePatientDAO
- Add test for getPatientIdentifiers with a list of
PatientIdentifierTypes.
- Add test for getPatientIdentifiers with a list of Patients.
@vixus0 @galund- api/src/main/java/org/openmrs/api/db/hibernate/HibernatePatientDAO.java (version c5e5a6c21d5159c43de40ce192dfb382297ed6f9)
- api/src/test/java/org/openmrs/api/db/hibernate/HibernatePatientDAOTest.java (version c5e5a6c21d5159c43de40ce192dfb382297ed6f9)