OpenMRS Core Master

Stages & jobs

  1. Build and Test

  2. Deploy

  3. Release

    Requires a user to start manually

Build result summary

Details

Completed
Queue duration
1 second
Duration
24 minutes
Labels
None
Revisions
openmrs-core
57d54fb44604e285f360ca315389beb821edd1c6 57d54fb44604e285f360ca315389beb821edd1c6
openmrs-standalone
5b99613f0bffb1ab3ffd50123096c7aa265d6620 5b99613f0bffb1ab3ffd50123096c7aa265d6620
Release scripts
5b416af0a90e6a162755d06d53b81d906ec4ef36 5b416af0a90e6a162755d06d53b81d906ec4ef36
Total tests
4103
Successful since
#1895 ()

Tests

Code commits

openmrs-core
Author Commit Message Commit date
Ivo Ulrich <teleivo@users.noreply.github.com> Ivo Ulrich <teleivo@users.noreply.github.com> 57d54fb44604e285f360ca315389beb821edd1c6 57d54fb44604e285f360ca315389beb821edd1c6 Merge pull request #2655 from teleivo/TRUNK-5388
TRUNK-5388 Make ModuleFileParser MessageSourceService dependency explicit
teleivo <mrteleivo@gmail.com> teleivo <mrteleivo@gmail.com> 81b0aa16a2c897d49d79cd55c122340da40c0386 81b0aa16a2c897d49d79cd55c122340da40c0386 TRUNK-5388 Remove duplicate file validation in ModuleFileParser
teleivo <mrteleivo@gmail.com> teleivo <mrteleivo@gmail.com> 63a076ed890f0a78b8a70e03dace5f1ff1bd9b44 63a076ed890f0a78b8a70e03dace5f1ff1bd9b44 TRUNK-5388 Replace deprecated use of ModuleFileParser
with ModuleFileParser(MessageSourceService)

* in ModuleFactory
* in ModuleExtensionsTest
teleivo <mrteleivo@gmail.com> teleivo <mrteleivo@gmail.com> e4be754bf550acf52361897c7c1ab32ed623e8fb e4be754bf550acf52361897c7c1ab32ed623e8fb TRUNK-5388 Make ModuleFileParser MessageSourceService dependency explicit
new
* add constructor ModuleFileParser(MessageSourceService) to clearly
state dependencies, which enables easier testing by passing in a mock or
use of a different implementation of a MessageSourceService
* add method ModuleFileParser.parse(File)
* add method ModuleFileparser.parse(InputStream)
which provide the same functionality/use the same implementation
underneath

deprecate
* deprecate all other constructors (3 in total)
* deprecate parse() in favor of parse(File), there is no need to keep
the file as state. This way we can create one parser and reuse it by
just passing in a different file to parse

tests
* move all tests which do not need the Context to be there to the
ModuleFileParserUnitTest which is now BaseContextMockTest and uses mocks
of the MessageSourceService
* one test still needs to stay in the BaseContextSensitive test since
the Context.getLocale() is still called. Did not add Locale as
dependency since I think this specific method getMessage(String key,
Object[] args) should be implementated in the MessageSourceService
as is getMessage(String) which abstracts away the users current locale
for us

Configuration changes

Some of the jobs or stages referenced by this result no longer exist.

Manual stage Release cannot be run as it references jobs that no longer exist.

Jira issues

IssueDescriptionStatus
Unknown Issue TypeTRUNK-5388Could not obtain issue details from Jira