TRUNK-5285 Delete boxing of already boxed value (#2514)
Ivo Ulrich <teleivo@users.noreply.github.com>
5e249338e02645fcfd02be28fee85d9a8f978414
Merge pull request #2539 from dilekamadushan/TRUNK-5033 TRUNK-5033 Public static fields should be final
Ivo Ulrich <teleivo@users.noreply.github.com>
dd2767b062459da89763b964d546fdffd2fc31bf
Merge pull request #2540 from teleivo/TRUNK-5147 TRUNK-5147 Refactoring VisitServiceTest
dilekamadushan <dileka.14@cse.mrt.ac.lk>
f6ccfd856ec824acbd90be369015b313ca8daa4c
TRUNK-5033 Public static fields should be final, made the appropriate fields final
teleivo <mrteleivo@gmail.com>
7ccdd102999819e24534c780b9a2ab942329c199
TRUNK-5147 Use java.util.Calendar month constants instead of literals
teleivo <mrteleivo@gmail.com>
b90b7a4c8e0826e78613eeb542a64037bfc3085f
TRUNK-5147 Remove wrong test javadocs
removed javadocs above tests which were wrong since the method signature
of the method they are testing changed.
these javadocs do not provide more information anyway than the test
itself, are just taking up space and are never updated as can be seen.
teleivo <mrteleivo@gmail.com>
8087ea3c5fd3020089262bf86aa62c1c3c7a8988
TRUNK-5147 Extract getting number of all visits in helper
remove duplication in tests by extracting a helper method for getting
all visits including voided
teleivo <mrteleivo@gmail.com>
5a8cb37b647db431b40073ac53a55d012b62e5b2
TRUNK-5147 Split VisitServiceTests for getType/s/ByUuid
Split tests for when something is found for a given argument and when it
is not since they represent different cases.
and add static import for assertNull
teleivo <mrteleivo@gmail.com>
ad24fea21cdcb1a7c253dfa345aa77a0b1bfd58c
TRUNK-5147 Make use of VisitService field in tests
VisitService is declared as field in VisitServiceTest and populated with
Context.getVisitService() before every test but still
Context.getVisitService() is used instead of the field.
use the field to increase readability
Ivo Ulrich <teleivo@users.noreply.github.com>
2d2f17540ed5ef7bada8203e47e0cb430ed5300f
Merge pull request #2538 from BartlomiejRasztabiga/TRUNK-5241
[TRUNK-5241] Possible null pointer dereference due to return value of c…
Ivo Ulrich <teleivo@users.noreply.github.com>
6bab2e570e6c4b9e9f099f2dc7d565bceed63f98
Merge pull request #2537 from BartlomiejRasztabiga/GCI-237
[GCI-237] Possible null pointer dereference due to return value of modu…
Merge pull request #2535 from dilekamadushan/TRUNK-5147 TRUNK-5147 Add tests to VisitService
dilekamadushan <dileka.14@cse.mrt.ac.lk>
1ec8187fe5f15ddd0a020dc3cfa256d35da16baa
TRUNK-5147 Add tests to VisitService, Added test case to check purging of unsaved visitService
teleivo <mrteleivo@gmail.com>
7db5179ee3e12dccdd82d072b19fa5050d53ef17
TRUNK-5298 Prevent editorconfig from trimming trailing whitespaces
we have trailing whitespaces in our code due to our formatter settings
removing those with editorconfig will cause a lot of changes and be in
conflict with our style