Build: #796 was successful Scheduled with changes by 5 people

Code commits

openmrs-core master

  • dkayiwa <kayiwadaniel@gmail.com>

    dkayiwa <kayiwadaniel@gmail.com> 13e58851c7bcad144384ebdfc0c781e62ab93210

    TRUNK-3508 StartModule does not work for StartModuleAnnotationTest

    • api/src/test/java/org/openmrs/test/StartModuleAnnotationTest.java (version 13e58851c7bcad144384ebdfc0c781e62ab93210)
    • api/src/test/java/org/openmrs/test/StartModuleExecutionListener.java (version 13e58851c7bcad144384ebdfc0c781e62ab93210)
  • Am-Coder <39997970+Am-Coder@users.noreply.github.com>

    Am-Coder <39997970+Am-Coder@users.noreply.github.com> f204ebe6a09acae9302bc881ceb0f9507831382f

    TRUNK-5870 Create Wrapper UUID function for PostgreSQL similar to MySQL (#3372)

    • api/src/main/resources/org/openmrs/liquibase/updates/liquibase-update-to-latest-2.4.x.xml (version f204ebe6a09acae9302bc881ceb0f9507831382f)
  • dkayiwa <kayiwadaniel@gmail.com>

    dkayiwa <kayiwadaniel@gmail.com> ceb0dc15b5a6bf7397714dcfc6d7a8b7a8f44a0f

    TRUNK-5651 Fixing failing integration test

    • api/src/test/java/org/openmrs/util/DatabaseUpdaterDatabaseIT.java (version ceb0dc15b5a6bf7397714dcfc6d7a8b7a8f44a0f)
  • teleivo <teleivo@users.noreply.github.com>

    teleivo <teleivo@users.noreply.github.com> a463724c6483dbe510570d99fa74120e1bc48675

    TRUNK-5816 PowerMock not supported on JUnit 5
    We can thus only test the valid case since there is no way for us to
    mock static methods. Mockito does not support that.

    Since JUnit 5 needs at minimum a JRE 8 this test should always pass
    irrespective of the JRE we are using to run our tests

    • api/src/test/java/org/openmrs/util/JavaVersionTest.java (version a463724c6483dbe510570d99fa74120e1bc48675)
  • achilep <you@example.com>

    achilep <you@example.com> 22c5bae9281755303e8b14dcb38c3694a2c7740a

    TRUNK-5816: Migrate api package tests to Junit

    • api/src/test/java/org/openmrs/obs/ImageHandlerTest.java (version 22c5bae9281755303e8b14dcb38c3694a2c7740a)
  • gitcliff <46714226+gitcliff@users.noreply.github.com>

    gitcliff <46714226+gitcliff@users.noreply.github.com> ce1d4055007d4a994cd835fa0afaeb4e1682bda0

    Trunk-5651::Add previous order group to order group (#3309)
    * Trunk-5651:Add previous order group to order group

    * TRUNK-5651:fixing edits from merge conflicts

    * TRUNK-5651:removing the tests

    * TRUNK-5651:fixing previous order group

    * TRUNK-5651:fixing previous order group

    • api/src/main/java/org/openmrs/OrderGroup.java (version ce1d4055007d4a994cd835fa0afaeb4e1682bda0)
    • api/src/main/resources/org/openmrs/api/db/hibernate/OrderGroup.hbm.xml (version ce1d4055007d4a994cd835fa0afaeb4e1682bda0)
    • api/src/main/resources/org/openmrs/liquibase/updates/liquibase-update-to-latest-2.4.x.xml (version ce1d4055007d4a994cd835fa0afaeb4e1682bda0)
    • api/src/test/java/org/openmrs/OrderGroupTest.java (version ce1d4055007d4a994cd835fa0afaeb4e1682bda0)
  • achilep <you@example.com>

    achilep <you@example.com> 12ceeacd4f7b3ff5769855e6b50e8303bc822845

    TRUNK-5816: Migrate api package tests to Junit5 5

    • api/src/test/java/org/openmrs/module/ModuleActivatorTest.java (version 12ceeacd4f7b3ff5769855e6b50e8303bc822845)
    • api/src/test/java/org/openmrs/module/ModuleInteroperabilityTest.java (version 12ceeacd4f7b3ff5769855e6b50e8303bc822845)
    • api/src/test/java/org/openmrs/test/jupiter/BaseModuleActivatorTest.java (version 12ceeacd4f7b3ff5769855e6b50e8303bc822845)
  • teleivo <teleivo@users.noreply.github.com>

    teleivo <teleivo@users.noreply.github.com> d2ba259a93746db7c6d33bc12e13f1134594cbe5

    TRUNK-5816 Migrate MediaHandlerTest to JUnit5
    Since PowerMock is not supported on JUnit 5 we need to convert it to an
    integration test. If the handler would have the AdministrationService as
    a dependency passed like for example the constructor we would enable
    unit testing. Reaching for services via the Context is a bad practice
    that we need to get rid of for exactly such cases.

    • api/src/test/java/org/openmrs/obs/MediaHandlerTest.java (version d2ba259a93746db7c6d33bc12e13f1134594cbe5)
  • teleivo <teleivo@users.noreply.github.com>

    teleivo <teleivo@users.noreply.github.com> 005332432562e1e678b82f0fb9d1e153887e3dfc

    TRUNK-5816 Fix formatting

    • api/src/test/java/org/openmrs/obs/TextHandlerTest.java (version 005332432562e1e678b82f0fb9d1e153887e3dfc)
  • teleivo <teleivo@users.noreply.github.com>

    teleivo <teleivo@users.noreply.github.com> 03db57deff4ee94bc36d5bcef41af115cf22b229

    TRUNK-5816 Migrate TextHandlerTest to JUnit5
    Since PowerMock is not supported on JUnit 5 we need to convert it to an
    integration test. If the handler would have the AdministrationService as
    a dependency passed like for example the constructor we would enable
    unit testing. Reaching for services via the Context is a bad practice
    that we need to get rid of for exactly such cases.

    • api/src/test/java/org/openmrs/obs/TextHandlerTest.java (version 03db57deff4ee94bc36d5bcef41af115cf22b229)
  • achilep <you@example.com>

    achilep <you@example.com> 357e320dce7f237381cd06f604dcf7aeb8304861

    TRUNK-5816: Migrate api package tests to Junit5

    • api/src/test/java/org/openmrs/api/UserServiceTest.java (version 357e320dce7f237381cd06f604dcf7aeb8304861)
  • achilep <you@example.com>

    achilep <you@example.com> b6985ae3b7cb72770aabe350c904b21a73e00c2b

    TRUNK-5816: Migrate api package tests to Junit5

    • api/src/test/java/org/openmrs/api/PatientServiceTest.java (version b6985ae3b7cb72770aabe350c904b21a73e00c2b)
  • teleivo <teleivo@users.noreply.github.com>

    teleivo <teleivo@users.noreply.github.com> de7bfbb8f84ccf82ea5fd4e934c7a9ba9e483f31

    TRUNK-5816 No need for these test javadocs
    as we can easily see the method under test and navigate to its
    implementation. having these javadocs does not provide any benefit.
    we have therefore decided some time ago that these do not have to be
    written.

    • api/src/test/java/org/openmrs/validator/AllergyValidatorTest.java (version de7bfbb8f84ccf82ea5fd4e934c7a9ba9e483f31)
  • teleivo <teleivo@users.noreply.github.com>

    teleivo <teleivo@users.noreply.github.com> 0a754b343f94f01bf6a4abdf6976faec506f0516

    TRUNK-5816 Make AllergyValidator unit testable
    by Autowiring the MessageSourceService instead of reaching for it via
    the Context which is a bad practice since it prevents testing things in
    isolation.

    We also need to do this since PowerMock does not support JUnit 5
    https://github.com/powermock/powermock/issues/929

    • api/src/main/java/org/openmrs/validator/AllergyValidator.java (version 0a754b343f94f01bf6a4abdf6976faec506f0516)
    • api/src/test/java/org/openmrs/validator/AllergyValidatorTest.java (version 0a754b343f94f01bf6a4abdf6976faec506f0516)
  • achilep <you@example.com>

    achilep <you@example.com> 35b8c95a29da288d30d1e6ad4621018e56fbbb83

    TRUNK-5816: Migrate api package tests to Junit 5

    • api/src/test/java/org/openmrs/OrderTest.java (version 35b8c95a29da288d30d1e6ad4621018e56fbbb83)
    • api/src/test/java/org/openmrs/util/OpenmrsUtilTest.java (version 35b8c95a29da288d30d1e6ad4621018e56fbbb83)
    • api/src/test/java/org/openmrs/validator/PatientValidatorTest.java (version 35b8c95a29da288d30d1e6ad4621018e56fbbb83)
    • api/src/test/java/org/openmrs/validator/PersonValidatorTest.java (version 35b8c95a29da288d30d1e6ad4621018e56fbbb83)
  • teleivo <teleivo@users.noreply.github.com>

    teleivo <teleivo@users.noreply.github.com> a1d3424b48118441be545f7517548a13e575d13b

    TRUNK-5816 StartModuleExecutionListener is internal
    so make it package private. At least the JUnit 5 one since its not yet released

    • api/src/test/java/org/openmrs/test/jupiter/StartModuleExecutionListener.java (version a1d3424b48118441be545f7517548a13e575d13b)
  • teleivo <teleivo@users.noreply.github.com>

    teleivo <teleivo@users.noreply.github.com> e23946b15b12f7928fc1cb559c0ad97efeab17f8

    TRUNK-5816 Provide JUnit5 StartModuleExecutionListener

    • api/src/test/java/org/openmrs/test/jupiter/BaseContextSensitiveTest.java (version e23946b15b12f7928fc1cb559c0ad97efeab17f8)
    • api/src/test/java/org/openmrs/test/jupiter/StartModuleExecutionListener.java (version e23946b15b12f7928fc1cb559c0ad97efeab17f8)
  • achilep <you@example.com>

    achilep <you@example.com> e2298ad2106940f5526418ff00dd903b003872f8

    TRUNK-5816: Migrate api package tests to Junit5

    • api/src/test/java/org/openmrs/api/VisitServiceTest.java (version e2298ad2106940f5526418ff00dd903b003872f8)
    • api/src/test/java/org/openmrs/validator/PersonMergeLogValidatorTest.java (version e2298ad2106940f5526418ff00dd903b003872f8)