Build #378

Plan branch:
Build and Release Plan for FHIR2 Module

Build: #378 failed Changes by Ian Bacher

Stages & jobs

  1. Test module

  2. Release

    Requires a user to start manually

Build result summary

Details

Completed
Queue duration
< 1 second
Duration
4 minutes
Labels
None
Revisions
Git
11066788d27c9937540c7256935164410ffe1d9e 11066788d27c9937540c7256935164410ffe1d9e
Release scripts
c4475a9228b197817dce78683d9da8a1e2c4e3a5 c4475a9228b197817dce78683d9da8a1e2c4e3a5
Total tests
4939
Fixed in
#380 (Code changes detected)

Tests

Responsible

Code commits

Git
Author Commit Message Commit date
Ian Bacher Ian Bacher 11066788d27c9937540c7256935164410ffe1d9e 11066788d27c9937540c7256935164410ffe1d9e Set Cache-Control: no-cache for all outgoing responses to READ requests
This should prevent the responses from being cached until we can work out
a strategy supporting ETags.
Ian Bacher Ian Bacher db8da8c022502c0b727c23802894df50dd9079d3 db8da8c022502c0b727c23802894df50dd9079d3 Add support for X-Forwarded- headers
This should enable us to return the "correct" address in common cases
with reverse proxies in front of OpenMRS

Tests

New test failures 1
Status Test View job Duration
Collapse Failed OpenmrsFhirAddressStrategyTest unnecessary Mockito stubbings History
Build and test Module < 1 sec 
org.mockito.exceptions.misusing.UnnecessaryStubbingException: 
Unnecessary stubbings detected in test class: OpenmrsFhirAddressStrategyTest
Clean & maintainable test code requires zero unnecessary code.
Following stubbings are unnecessary (click to navigate to relevant line of code):
  1. -> at org.openmrs.module.fhir2.web.util.OpenmrsFhirAddressStrategyTest.shouldProperlyHandleStandardProxyHeaders(OpenmrsFhirAddressStrategyTest.java:167)
  2. -> at org.openmrs.module.fhir2.web.util.OpenmrsFhirAddressStrategyTest.shouldProperlyHandleStandardProxyHeaders(OpenmrsFhirAddressStrategyTest.java:168)
Please remove unnecessary stubbings or use 'lenient' strictness. More info: javadoc for UnnecessaryStubbingException class.
org.mockito.exceptions.misusing.UnnecessaryStubbingException: 
(7 more lines...)