Build #385

Plan branch:
Builds, runs unit tests and deploys artifacts to nexus repo

Build: #385 was successful Changes by Mark Goodrich <mgoodrich@pih.org>

Stages & jobs

  1. Default Stage

  2. Release

    Requires a user to start manually

Code commits

Git

  • Mark Goodrich <mgoodrich@pih.org>

    Mark Goodrich <mgoodrich@pih.org> 244c46f1bd1641c7e9d8e5d5f6fcfd3db8931996

    Merge pull request #121 from ssmusoke/HTML-647
    HTML-647 : Remove the restriction requiring the need for location and provider tags to be added to forms

  • Stephen Senkomago Musoke

    Stephen Senkomago Musoke 80781cc72c3498d245f80fbb3c7b789097a2dfd7 m

    By default the tags are required, so even when not specified the required value is true

    • api/src/main/java/org/openmrs/module/htmlformentry/element/EncounterDetailSubmissionElement.java (version 80781cc72c3498d245f80fbb3c7b789097a2dfd7)
    • api/src/test/resources/org/openmrs/module/htmlformentry/include/simplestFormLocationAndProviderRequiredByTagAttribute.xml (version 80781cc72c3498d245f80fbb3c7b789097a2dfd7)
    • api/src/test/resources/org/openmrs/module/htmlformentry/include/simplestFormLocationRequiredByTagAttribute.xml (version 80781cc72c3498d245f80fbb3c7b789097a2dfd7)
    • api/src/test/resources/org/openmrs/module/htmlformentry/include/simplestFormProviderRequiredByTagAttribute.xml (version 80781cc72c3498d245f80fbb3c7b789097a2dfd7)
  • Stephen Senkomago Musoke

    Stephen Senkomago Musoke bcc9870618cad64fce7d42e9eb2ca36ce5d13ae9 m

    Test cases for required=true/false tags for location and provider

    • api-tests/src/test/java/org/openmrs/module/htmlformentry/RegressionTest.java (version bcc9870618cad64fce7d42e9eb2ca36ce5d13ae9)
    • api/src/main/java/org/openmrs/module/htmlformentry/FormEntrySession.java (version bcc9870618cad64fce7d42e9eb2ca36ce5d13ae9)
    • api/src/main/java/org/openmrs/module/htmlformentry/FormSubmissionController.java (version bcc9870618cad64fce7d42e9eb2ca36ce5d13ae9)
    • api/src/main/java/org/openmrs/module/htmlformentry/element/EncounterDetailSubmissionElement.java (version bcc9870618cad64fce7d42e9eb2ca36ce5d13ae9)
    • api/src/test/java/org/openmrs/module/htmlformentry/RegressionTestHelper.java (version bcc9870618cad64fce7d42e9eb2ca36ce5d13ae9)
    • api/src/test/java/org/openmrs/module/htmlformentry/element/PatientDetailSubmissionElementTest.java (version bcc9870618cad64fce7d42e9eb2ca36ce5d13ae9)
    • api/src/test/resources/org/openmrs/module/htmlformentry/include/simplestFormLocationAndProviderNotRequiredByTagAttribute.xml (version bcc9870618cad64fce7d42e9eb2ca36ce5d13ae9)
    • api/src/test/resources/org/openmrs/module/htmlformentry/include/simplestFormLocationAndProviderRequiredByTagAttribute.xml (version bcc9870618cad64fce7d42e9eb2ca36ce5d13ae9)
    • api/src/test/resources/org/openmrs/module/htmlformentry/include/simplestFormLocationNotRequiredByTagAttribute.xml (version bcc9870618cad64fce7d42e9eb2ca36ce5d13ae9)
    • api/src/test/resources/org/openmrs/module/htmlformentry/include/simplestFormLocationRequiredByTagAttribute.xml (version bcc9870618cad64fce7d42e9eb2ca36ce5d13ae9)
    • api/src/test/resources/org/openmrs/module/htmlformentry/include/simplestFormNoLocation.xml (version bcc9870618cad64fce7d42e9eb2ca36ce5d13ae9)
    • api/src/test/resources/org/openmrs/module/htmlformentry/include/simplestFormNoLocationNoProvider.xml (version bcc9870618cad64fce7d42e9eb2ca36ce5d13ae9)
    • api/src/test/resources/org/openmrs/module/htmlformentry/include/simplestFormNoProvider.xml (version bcc9870618cad64fce7d42e9eb2ca36ce5d13ae9)
    • api/src/test/resources/org/openmrs/module/htmlformentry/include/simplestFormProviderNotRequiredByTagAttribute.xml (version bcc9870618cad64fce7d42e9eb2ca36ce5d13ae9)
    • api/src/test/resources/org/openmrs/module/htmlformentry/include/simplestFormProviderRequiredByTagAttribute.xml (version bcc9870618cad64fce7d42e9eb2ca36ce5d13ae9)
  • Stephen Senkomago Musoke

    Stephen Senkomago Musoke ad3dd65a60e65e129f153a0fc2ac1a530671f220 m

    Updated assertNoProvider() and assertNoLocation() to match assertProvider() and assertLocation()

    • api-tests/src/test/java/org/openmrs/module/htmlformentry/RegressionTest.java (version ad3dd65a60e65e129f153a0fc2ac1a530671f220)
    • api/src/test/java/org/openmrs/module/htmlformentry/RegressionTestHelper.java (version ad3dd65a60e65e129f153a0fc2ac1a530671f220)
  • Stephen Senkomago Musoke

    Stephen Senkomago Musoke 913761a8a3beeeb8b7b0cef25a1b1b03c9025a59 m

    Added debug message to identify the source of the validation errors

    • api-tests/src/test/java/org/openmrs/module/htmlformentry/RegressionTest.java (version 913761a8a3beeeb8b7b0cef25a1b1b03c9025a59)
    • api/src/main/java/org/openmrs/module/htmlformentry/FormSubmissionController.java (version 913761a8a3beeeb8b7b0cef25a1b1b03c9025a59)
    • api/src/main/java/org/openmrs/module/htmlformentry/element/EncounterDetailSubmissionElement.java (version 913761a8a3beeeb8b7b0cef25a1b1b03c9025a59)
    • api/src/test/java/org/openmrs/module/htmlformentry/RegressionTestHelper.java (version 913761a8a3beeeb8b7b0cef25a1b1b03c9025a59)
    • api/src/test/resources/org/openmrs/module/htmlformentry/include/simplestFormNoLocationNoProvider.xml (version 913761a8a3beeeb8b7b0cef25a1b1b03c9025a59)
  • Stephen Senkomago Musoke

    Stephen Senkomago Musoke 8bea087f0bfeadcd9e0a7c344baa1d37c9345a38 m

    Enable the encounter location and provider tags not to be required by adding a required="false" attribute

    • api-tests/src/test/java/org/openmrs/module/htmlformentry/RegressionTest.java (version 8bea087f0bfeadcd9e0a7c344baa1d37c9345a38)
    • api/src/main/java/org/openmrs/module/htmlformentry/FormEntrySession.java (version 8bea087f0bfeadcd9e0a7c344baa1d37c9345a38)
    • api/src/main/java/org/openmrs/module/htmlformentry/element/EncounterDetailSubmissionElement.java (version 8bea087f0bfeadcd9e0a7c344baa1d37c9345a38)
    • api/src/main/java/org/openmrs/module/htmlformentry/handler/EncounterLocationHandler.java (version 8bea087f0bfeadcd9e0a7c344baa1d37c9345a38)
    • api/src/main/java/org/openmrs/module/htmlformentry/handler/EncounterProviderAndRoleTagHandler.java (version 8bea087f0bfeadcd9e0a7c344baa1d37c9345a38)
    • api/src/main/java/org/openmrs/module/htmlformentry/handler/EncounterProviderHandler.java (version 8bea087f0bfeadcd9e0a7c344baa1d37c9345a38)
    • api/src/test/resources/org/openmrs/module/htmlformentry/include/simplestFormNoLocation.xml (version 8bea087f0bfeadcd9e0a7c344baa1d37c9345a38)
    • api/src/test/resources/org/openmrs/module/htmlformentry/include/simplestFormNoLocationNoProvider.xml (version 8bea087f0bfeadcd9e0a7c344baa1d37c9345a38)
    • api/src/test/resources/org/openmrs/module/htmlformentry/include/simplestFormNoProvider.xml (version 8bea087f0bfeadcd9e0a7c344baa1d37c9345a38)