openmrs-core master

• 

  Ivo <teleivo@users.noreply.github.com> 18 Jul 2020 b6ba388457f38c4f9af77d7fc2bc1ab12354dbb4

  TRUNK-5816 Run action on BinaryStreamHandlerTest
  since its an easier one to assert we can read what we wrote into it

  • .github/workflows/test_windows.yml (version b6ba388457f38c4f9af77d7fc2bc1ab12354dbb4)
• 

  Ivo <teleivo@users.noreply.github.com> 18 Jul 2020 87b67e09cb41f975bcc2472805b8ecacd0eb9519

  TRUNK-5816 Make action name refer to jira task
  so its clear to everyone that we run this action for now to figure out why the MediaHandlerTest and BinaryStreamHandlerTest fail on Windows

  • .github/workflows/test_windows.yml (version 87b67e09cb41f975bcc2472805b8ecacd0eb9519)
• 

  Ivo <teleivo@users.noreply.github.com> 18 Jul 2020 cb02ca1148b8ef5e7ff07583b85f0a6c72979119

  TRUNK-5816 Add caching on GitHub action
  Not sure if ~/.m2 will work on Windows. Most likely not. Lets see

  • .github/workflows/test_windows.yml (version cb02ca1148b8ef5e7ff07583b85f0a6c72979119)
• 

  Ivo <teleivo@users.noreply.github.com> 18 Jul 2020 a439568e4c9dfa1a7ebf98c8aad3d0da8314c47b

  TRUNK-5816 Comma invalid on Windows
  not sure yet how to pass 2 files on windows
  the comma seems invalid

  • .github/workflows/test_windows.yml (version a439568e4c9dfa1a7ebf98c8aad3d0da8314c47b)
• 

  Ivo <teleivo@users.noreply.github.com> 18 Jul 2020 379bf76fae3ee2477c95cd8a2cbc2f6aa9238233

  TRUNK-5816 Reproduce failing tests on Windows
  using GitHub actions which we can run on Windows
  
  see https://talk.openmrs.org/t/junit-5-migration/29273/50

  • .github/workflows/test_windows.yml (version 379bf76fae3ee2477c95cd8a2cbc2f6aa9238233)
• 

  teleivo <teleivo@users.noreply.github.com> 18 Jul 2020 c5928a553593ba2f798fad220b7627519ccbdf71

  Revert "TRUNK-5816 Make StartModuleExecutionListener JUnit independent"
  This reverts commit 117033748d6da65428b485c75952b26c5c8349ee.

  • api/src/test/java/org/openmrs/test/StartModuleExecutionListener.java (version c5928a553593ba2f798fad220b7627519ccbdf71)
  • api/src/test/java/org/openmrs/test/jupiter/BaseContextSensitiveTest.java (version c5928a553593ba2f798fad220b7627519ccbdf71)
  • api/src/test/java/org/openmrs/test/jupiter/StartModuleExecutionListener.java (version c5928a553593ba2f798fad220b7627519ccbdf71)
• 

  teleivo <teleivo@users.noreply.github.com> 18 Jul 2020 b86a624a8c4abc6c87d8cace079768a3644e770e

  Revert "TRUNK-5816 Run StartModuleAnnotationTest"
  This reverts commit 00a3747a41d41e2739fd011058933104f7527b06.
  
  Fails due to java.lang.IllegalStateException: Failed to load ApplicationContext

  • api/src/test/java/org/openmrs/annotation/StartModuleAnnotationTest.java (version b86a624a8c4abc6c87d8cace079768a3644e770e)
  • api/src/test/java/org/openmrs/test/StartModuleAnnotationTest.java (version b86a624a8c4abc6c87d8cace079768a3644e770e)
• 

  teleivo <teleivo@users.noreply.github.com> 18 Jul 2020 00a3747a41d41e2739fd011058933104f7527b06

  TRUNK-5816 Run StartModuleAnnotationTest
  it was not run since all tests in the test folder are excluded from the
  surefire plugin in the api
  
  https://github.com/openmrs/openmrs-core/blob/d5585afd4142a3facb1d12340e0c4588f0db6565/api/pom.xml#L363-L367
  Most likely so that the BaseContext...Test classes dont get picked up.
  Not sure if they would actually run tough since they have no @Test
  annoation. We can double check that.
  
  Moving the test to the annotation package since there is already a
  StartModuleAnnotation test

  • api/src/test/java/org/openmrs/annotation/StartModuleAnnotationTest.java (version 00a3747a41d41e2739fd011058933104f7527b06)
  • api/src/test/java/org/openmrs/test/StartModuleAnnotationTest.java (version 00a3747a41d41e2739fd011058933104f7527b06)
• 

  teleivo <teleivo@users.noreply.github.com> 18 Jul 2020 117033748d6da65428b485c75952b26c5c8349ee

  TRUNK-5816 Make StartModuleExecutionListener JUnit independent
  so it can be reused in JUnit 4 and 5 BaseContextSensitiveTests

  • api/src/test/java/org/openmrs/test/StartModuleExecutionListener.java (version 117033748d6da65428b485c75952b26c5c8349ee)
  • api/src/test/java/org/openmrs/test/jupiter/BaseContextSensitiveTest.java (version 117033748d6da65428b485c75952b26c5c8349ee)
  • api/src/test/java/org/openmrs/test/jupiter/StartModuleExecutionListener.java (version 117033748d6da65428b485c75952b26c5c8349ee)