Build: #1147 was successful
Job: Default Job was successful
Code commits
openmrs-core master
-
Ivo Ulrich <teleivo@users.noreply.github.com> 0b59a781f80265f75ac5c2f33f164414b33d0553
Merge pull request #2031 from teleivo/TRUNK-5085
TRUNK-5085 Add checkstyle rule UnusedImports -
teleivo <mrteleivo@gmail.com> ee5373c0828944857b7b241eda0d491be49b2ff4
TRUNK-5085 Add checkstyle rule UnusedImports
we already flag unused imports using codacy but the rule is currently
manually configured in the codacy UI using the PMD checker.
* add the checkstyle rule which flags introduction of UnusedImports as
error so we keep the style in the repository and do not rely on manual
configurations in codacy- checkstyle.xml (version ee5373c0828944857b7b241eda0d491be49b2ff4)
-
Daniel Kayiwa 42a4d721e52b3e87f6286f02c52d7a738eb42a39
Merge pull request #2030 from teleivo/TRUNK-5085
TRUNK-5085 Fix license header in checkstyle.xml -
teleivo <mrteleivo@gmail.com> 86ca77b1145aab5a24be8e91815d765d0a8a7311
Fix license header in checkstyle.xml
- checkstyle.xml (version 86ca77b1145aab5a24be8e91815d765d0a8a7311)
-
Daniel Kayiwa 5f2ed781b1e88246dbbd50bd65f409f0e6facbb3
Merge pull request #2029 from teleivo/TRUNK-5085
TRUNK-5085 Merge checkstyle rules with google's -
teleivo <mrteleivo@gmail.com> 1684758d8c6ecf0feb3fd94b67107feee0ef6b78
TRUNK-5085 Merge checkstyle rules with google's
merged our existing checkstyle.xml with google's
* removed their checks for tabs since we use tabs
* added NPathComplexity since it was already actived on codacy
* added CustomImportOrder rule using the Eclipse defaults
* changed the default severity to warning
* explicitly set the severity of rules we had before to error
* MagicNumber is an error but ignored for annotations
* reduced NestedIfDepth to 4 since that smells
* reduced NestedTryDepth to 2 since that smells- checkstyle.xml (version 1684758d8c6ecf0feb3fd94b67107feee0ef6b78)
-
Daniel Kayiwa b0390936342e3fe4df9b10333a1ac7cb2fe8b15f
Merge pull request #2025 from mekomsolutions/2.1_TRUNK-5077
TRUNK-5077: AbstractHandler doesn't fail to purge obs with missing file. -
Darius Jazayeri <jazayeri@alum.mit.edu> c09d7dfe8b1c0dd0bc9f150f86ef6d90f12f6790
TRUNK-4925 - (Fix regression introduce in prior commit) Copy patient specific attributes on Patient() constructor
- api/src/main/java/org/openmrs/Person.java (version c09d7dfe8b1c0dd0bc9f150f86ef6d90f12f6790)
- api/src/main/java/org/openmrs/PersonName.java (version c09d7dfe8b1c0dd0bc9f150f86ef6d90f12f6790)
- api/src/test/java/org/openmrs/PersonTest.java (version c09d7dfe8b1c0dd0bc9f150f86ef6d90f12f6790)
-
mks-d <dimitri@mekomsolutions.com> 87b6e4c062fd0f9545c5c34c4200943ce9a2962a m
TRUNK-5077: AbstractHandler doesn't fail to purge obs with missing file.
modified: api/src/main/java/org/openmrs/obs/handler/AbstractHandler.java
This unit test was throwing an APIException prior to the change.
modified: api/src/test/java/org/openmrs/api/ObsServiceTest.java- api/src/main/java/org/openmrs/obs/handler/AbstractHandler.java (version 87b6e4c062fd0f9545c5c34c4200943ce9a2962a)
- api/src/test/java/org/openmrs/api/ObsServiceTest.java (version 87b6e4c062fd0f9545c5c34c4200943ce9a2962a)