Build #235

Plan branch:

Build: #235 was successful

Job: Default Job was successful

Stages & jobs

  1. Default Stage

  2. Release

    Requires a user to start manually

Code commits

Git

  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> 5e375308940978f4d96a9a69a47ccc08f47818e0

    Merge pull request #309 from teleivo/RAD-285
    RAD-285 Rename service methods ByEntityId

  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> 38f7040a6bfb6b175664c959e4469ec83c499899

    RAD-285 Rename service methods ByEntityId
    the openmrs-core convention is that the service get methods which to get the
    entity the service is for by its internal id are simply called
    getEntity(Integer entityId)

    Remove the ByXXX substring from our service and DAO methods
     * RadiologyOrderService.getRadiologyOrderByOrderId()
     * RadiologyReportService.getRadiologyReportByRadiologyReportId()

    • api/src/main/java/org/openmrs/module/radiology/order/HibernateRadiologyOrderDAO.java (version 38f7040a6bfb6b175664c959e4469ec83c499899)
    • api/src/main/java/org/openmrs/module/radiology/order/RadiologyOrderDAO.java (version 38f7040a6bfb6b175664c959e4469ec83c499899)
    • api/src/main/java/org/openmrs/module/radiology/order/RadiologyOrderService.java (version 38f7040a6bfb6b175664c959e4469ec83c499899)
    • api/src/main/java/org/openmrs/module/radiology/order/RadiologyOrderServiceImpl.java (version 38f7040a6bfb6b175664c959e4469ec83c499899)
    • api/src/main/java/org/openmrs/module/radiology/report/HibernateRadiologyReportDAO.java (version 38f7040a6bfb6b175664c959e4469ec83c499899)
    • api/src/main/java/org/openmrs/module/radiology/report/RadiologyReportDAO.java (version 38f7040a6bfb6b175664c959e4469ec83c499899)
    • api/src/main/java/org/openmrs/module/radiology/report/RadiologyReportEditor.java (version 38f7040a6bfb6b175664c959e4469ec83c499899)
    • api/src/main/java/org/openmrs/module/radiology/report/RadiologyReportService.java (version 38f7040a6bfb6b175664c959e4469ec83c499899)
    • api/src/main/java/org/openmrs/module/radiology/report/RadiologyReportServiceImpl.java (version 38f7040a6bfb6b175664c959e4469ec83c499899)
    • api/src/test/java/org/openmrs/module/radiology/order/RadiologyOrderServiceComponentTest.java (version 38f7040a6bfb6b175664c959e4469ec83c499899)
    • api/src/test/java/org/openmrs/module/radiology/report/RadiologyReportEditorComponentTest.java (version 38f7040a6bfb6b175664c959e4469ec83c499899)
    • api/src/test/java/org/openmrs/module/radiology/report/RadiologyReportServiceComponentTest.java (version 38f7040a6bfb6b175664c959e4469ec83c499899)
    • api/src/test/java/org/openmrs/module/radiology/study/RadiologyStudyServiceComponentTest.java (version 38f7040a6bfb6b175664c959e4469ec83c499899)
    • omod/src/main/java/org/openmrs/module/radiology/order/web/RadiologyOrderFormController.java (version 38f7040a6bfb6b175664c959e4469ec83c499899)
    • omod/src/test/java/org/openmrs/module/radiology/order/web/RadiologyOrderFormControllerTest.java (version 38f7040a6bfb6b175664c959e4469ec83c499899)