Sonar metrics for OpenMRS Core Master

Build: #1243 did not start Scheduled with changes by 3 people

Build result summary

Details

Queued
Status
Reason for not building is unknown
Labels
None
Revision
7606d3e69fbf433a9ccb91241408b6124d826610 7606d3e69fbf433a9ccb91241408b6124d826610

Code commits

Author Commit Message Commit date
Ivo Ulrich <teleivo@users.noreply.github.com> Ivo Ulrich <teleivo@users.noreply.github.com> 7606d3e69fbf433a9ccb91241408b6124d826610 7606d3e69fbf433a9ccb91241408b6124d826610 Merge pull request #2180 from teleivo/TRUNK-5157
TRUNK-5157 ProgramWorkflowEditor tries to get state by uuid twice
teleivo <mrteleivo@gmail.com> teleivo <mrteleivo@gmail.com> c1d26c728149614a7c1dce1db7557308a16da46c c1d26c728149614a7c1dce1db7557308a16da46c TRUNK-5157 ProgramWorkflowEditor tries to get state by uuid twice
the catch block will never be reached since getByUuid() just returns
null if nothing is found. The exception in the try block is normally
thrown by Integer.valueOf() if the text is a uuid and not a number

* use getState(Integer) first to try to get the ProgramWorkflow by
its id
* is text is not an Integer, the exception in Integer.valueOf will lead
to the catch block being executed which then tries to fetch by the uuid
* added tests
Ivo Ulrich <teleivo@users.noreply.github.com> Ivo Ulrich <teleivo@users.noreply.github.com> 58bac16a8152307887741c1b2298c3d6581f15a1 58bac16a8152307887741c1b2298c3d6581f15a1 Merge pull request #2179 from teleivo/TRUNK-5154
TRUNK-5154 ProgramWorkflowStateEditor tries to get state by uuid twice
teleivo <mrteleivo@gmail.com> teleivo <mrteleivo@gmail.com> eba7a0a14e2ac86c5e55ab85b5f139ab972066b0 eba7a0a14e2ac86c5e55ab85b5f139ab972066b0 TRUNK-5154 ProgramWorkflowStateEditor tries to get state by uuid twice
the catch block will never be reached since getByUuid() just returns
null if nothing is found. The exception in the try block is normally
thrown by Integer.valueOf() if the text is a uuid and not a number

* use getState(Integer) first to try to get the ProgramWorkflowState by
its id
* is text is not an Integer, the exception in Integer.valueOf will lead
to the catch block being executed which then tries to fetch by the uuid
* added tests
Ivo Ulrich <teleivo@users.noreply.github.com> Ivo Ulrich <teleivo@users.noreply.github.com> 084dde5112e327d75e44494fc182710a434a2e13 084dde5112e327d75e44494fc182710a434a2e13 Merge pull request #2178 from teleivo/TRUNK-5155-real
TRUNK-5155 Add ProgramWorkflowService.getState(Integer)

Jira issues

IssueDescriptionStatus
1 more issue…
Unknown Issue TypeTRUNK-5052Could not obtain issue details from Jira
Unknown Issue TypeTRUNK-5154Could not obtain issue details from Jira
Unknown Issue TypeTRUNK-5155Could not obtain issue details from Jira
Unknown Issue TypeTRUNK-5156Could not obtain issue details from Jira
Unknown Issue TypeTRUNK-5157Could not obtain issue details from Jira