Build #1,560

Plan branch:
Sonar metrics for OpenMRS Core Master

Build: #1560 was successful Scheduled with changes by 5 people

Code commits

Git

  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> 5e249338e02645fcfd02be28fee85d9a8f978414

    Merge pull request #2539 from dilekamadushan/TRUNK-5033
    TRUNK-5033 Public static fields should be final

  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> dd2767b062459da89763b964d546fdffd2fc31bf

    Merge pull request #2540 from teleivo/TRUNK-5147
    TRUNK-5147 Refactoring VisitServiceTest

  • dilekamadushan <dileka.14@cse.mrt.ac.lk>

    dilekamadushan <dileka.14@cse.mrt.ac.lk> f6ccfd856ec824acbd90be369015b313ca8daa4c

    TRUNK-5033 Public static fields should be final, made the appropriate fields final

    • api/src/main/java/org/openmrs/notification/NotificationConstants.java (version f6ccfd856ec824acbd90be369015b313ca8daa4c)
    • api/src/main/java/org/openmrs/scheduler/SchedulerConstants.java (version f6ccfd856ec824acbd90be369015b313ca8daa4c)
    • api/src/main/java/org/openmrs/util/OpenmrsConstants.java (version f6ccfd856ec824acbd90be369015b313ca8daa4c)
    • web/src/main/java/org/openmrs/web/WebConstants.java (version f6ccfd856ec824acbd90be369015b313ca8daa4c)
  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> 7ccdd102999819e24534c780b9a2ab942329c199

    TRUNK-5147 Use java.util.Calendar month constants instead of literals

    • api/src/test/java/org/openmrs/api/VisitServiceTest.java (version 7ccdd102999819e24534c780b9a2ab942329c199)
  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> b90b7a4c8e0826e78613eeb542a64037bfc3085f

    TRUNK-5147 Remove wrong test javadocs
    removed javadocs above tests which were wrong since the method signature
    of the method they are testing changed.

    these javadocs do not provide more information anyway than the test
    itself, are just taking up space and are never updated as can be seen.

    • api/src/test/java/org/openmrs/api/VisitServiceTest.java (version b90b7a4c8e0826e78613eeb542a64037bfc3085f)
  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> 8087ea3c5fd3020089262bf86aa62c1c3c7a8988

    TRUNK-5147 Extract getting number of all visits in helper
    remove duplication in tests by extracting a helper method for getting
    all visits including voided

    • api/src/test/java/org/openmrs/api/VisitServiceTest.java (version 8087ea3c5fd3020089262bf86aa62c1c3c7a8988)
  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> 5a8cb37b647db431b40073ac53a55d012b62e5b2

    TRUNK-5147 Split VisitServiceTests for getType/s/ByUuid
    Split tests for when something is found for a given argument and when it
    is not since they represent different cases.

    and add static import for assertNull

    • api/src/test/java/org/openmrs/api/VisitServiceTest.java (version 5a8cb37b647db431b40073ac53a55d012b62e5b2)
  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> ad24fea21cdcb1a7c253dfa345aa77a0b1bfd58c

    TRUNK-5147 Make use of VisitService field in tests
    VisitService is declared as field in VisitServiceTest and populated with
    Context.getVisitService() before every test but still
    Context.getVisitService() is used instead of the field.

    use the field to increase readability

    • api/src/test/java/org/openmrs/api/VisitServiceTest.java (version ad24fea21cdcb1a7c253dfa345aa77a0b1bfd58c)
  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> 2d2f17540ed5ef7bada8203e47e0cb430ed5300f

    Merge pull request #2538 from BartlomiejRasztabiga/TRUNK-5241
    [TRUNK-5241] Possible null pointer dereference due to return value of c…

  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> 6bab2e570e6c4b9e9f099f2dc7d565bceed63f98

    Merge pull request #2537 from BartlomiejRasztabiga/GCI-237
    [GCI-237] Possible null pointer dereference due to return value of modu…

  • BartlomiejRasztabiga <bartlomiej.rasztabiga.official@gmail.com>

    BartlomiejRasztabiga <bartlomiej.rasztabiga.official@gmail.com> 9052546990c6f03a306b3eded9c543948a1cbdcc

    GCI-237 Possible null pointer dereference due to return value of modulesFolder.listFiles() in ModuleFactory

    • api/src/main/java/org/openmrs/module/ModuleFactory.java (version 9052546990c6f03a306b3eded9c543948a1cbdcc)
  • BartlomiejRasztabiga <bartlomiej.rasztabiga.official@gmail.com>

    BartlomiejRasztabiga <bartlomiej.rasztabiga.official@gmail.com> 0c836fc0b081e928ab405f3876e10502d3dbe848

    TRUNK-5241 Possible null pointer dereference due to return value of called method

    • web/src/main/java/org/openmrs/module/web/WebModuleUtil.java (version 0c836fc0b081e928ab405f3876e10502d3dbe848)
    • web/src/main/java/org/openmrs/web/Listener.java (version 0c836fc0b081e928ab405f3876e10502d3dbe848)
  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> 854e9124cb7b3cf3ae289cf14ab787d7e6cbd868

    Revert "GCI-237 Guarantee moduleFolder.listFiles() to be non-null (#2442)"
    This reverts commit a4160fd13c5633d74a72d1d69cac440e3f0b92b1.

    • api/src/main/java/org/openmrs/module/ModuleFactory.java (version 854e9124cb7b3cf3ae289cf14ab787d7e6cbd868)
  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> 6856bc8d8ab497bdf00c362a8f8779803ef69a36

    Revert "TRUNK-5241 Handle null pointer dereferences (#2440)"
    This reverts commit 06a610e1630e964cc0d574fcd76a726f522f332b.

    • web/src/main/java/org/openmrs/module/web/WebModuleUtil.java (version 6856bc8d8ab497bdf00c362a8f8779803ef69a36)
  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> cff2a2a8d6e9c6b1c16aa6dd30c51b0c53a5e4c4

    Merge pull request #2535 from dilekamadushan/TRUNK-5147
    TRUNK-5147 Add tests to VisitService

  • dilekamadushan <dileka.14@cse.mrt.ac.lk>

    dilekamadushan <dileka.14@cse.mrt.ac.lk> 1ec8187fe5f15ddd0a020dc3cfa256d35da16baa

    TRUNK-5147 Add tests to VisitService, Added test case to check purging of unsaved visitService

    • api/src/test/java/org/openmrs/api/VisitServiceTest.java (version 1ec8187fe5f15ddd0a020dc3cfa256d35da16baa)
  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> 7db5179ee3e12dccdd82d072b19fa5050d53ef17

    TRUNK-5298 Prevent editorconfig from trimming trailing whitespaces
    we have trailing whitespaces in our code due to our formatter settings
    removing those with editorconfig will cause a lot of changes and be in
    conflict with our style

    • .editorconfig (version 7db5179ee3e12dccdd82d072b19fa5050d53ef17)
  • Bartłomiej Rasztabiga <bartlomiej.rasztabiga.official@gmail.com>

    Bartłomiej Rasztabiga <bartlomiej.rasztabiga.official@gmail.com> 40f2dcfc9f5de69af40897a6a6c54d177f016295

    TRUNK-5295 Delete redundant array creation for calling varargs method (#2524)

    • api/src/main/java/org/openmrs/PatientIdentifier.java (version 40f2dcfc9f5de69af40897a6a6c54d177f016295)
    • api/src/main/java/org/openmrs/PersonAttribute.java (version 40f2dcfc9f5de69af40897a6a6c54d177f016295)
    • api/src/test/java/org/openmrs/api/ObsServiceTest.java (version 40f2dcfc9f5de69af40897a6a6c54d177f016295)
    • api/src/test/java/org/openmrs/api/ProgramWorkflowServiceTest.java (version 40f2dcfc9f5de69af40897a6a6c54d177f016295)
    • api/src/test/java/org/openmrs/module/ModuleUtilTest.java (version 40f2dcfc9f5de69af40897a6a6c54d177f016295)
  • Bartłomiej Rasztabiga <bartlomiej.rasztabiga.official@gmail.com>

    Bartłomiej Rasztabiga <bartlomiej.rasztabiga.official@gmail.com> bbe0c038e0a13ae55ec584568f3a524cee737c2c

    TRUNK-5292 Call to toStrring() on array (#2521)

    • api/src/main/java/org/openmrs/api/context/Context.java (version bbe0c038e0a13ae55ec584568f3a524cee737c2c)