Git

• 

  Daniel Kayiwa 26 Feb 2015 8f0736f343cbd24aa97cf36307166cb00079e46a

  Configuring MappingJacksonJsonView to return top-level json object - RA-578

  • web/src/main/resources/openmrs-servlet.xml (version 8f0736f343cbd24aa97cf36307166cb00079e46a)
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 26 Feb 2015 932ada1a73d5180edd53fae5701c750656e5600a

  fixed one more gci issue and ran mvn clean install successfully

  • api/src/main/java/org/openmrs/aop/AuthorizationAdvice.java (version 932ada1a73d5180edd53fae5701c750656e5600a)
  • api/src/main/java/org/openmrs/api/impl/UserServiceImpl.java (version 932ada1a73d5180edd53fae5701c750656e5600a)
  • api/src/main/java/org/openmrs/util/OpenmrsConstants.java (version 932ada1a73d5180edd53fae5701c750656e5600a)
  • web/src/test/java/org/openmrs/module/web/WebModuleUtilTest.java (version 932ada1a73d5180edd53fae5701c750656e5600a)
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 26 Feb 2015 041b4487f2d4758763f82c567a5a4a571c727cca

  Merge pull request #1358 from k-joseph/gci-2014
  Containing all gci-2014 commits
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 26 Feb 2015 9d68994a3d8175d01dc8500b76f5676911313723

  re-renamed logger to log in Cohort.java

  • api/src/main/java/org/openmrs/Cohort.java (version 9d68994a3d8175d01dc8500b76f5676911313723)
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 26 Feb 2015 91c6be799f090fa3b1fe1a9c325cdb4b68da1905

  re-renamed LOGGER to log for consistence for now and cleared other small issues

  • api/src/main/java/org/openmrs/Cohort.java (version 91c6be799f090fa3b1fe1a9c325cdb4b68da1905)
  • api/src/main/java/org/openmrs/Order.java (version 91c6be799f090fa3b1fe1a9c325cdb4b68da1905)
  • api/src/main/java/org/openmrs/api/impl/OrderServiceImpl.java (version 91c6be799f090fa3b1fe1a9c325cdb4b68da1905)
  • api/src/main/java/org/openmrs/util/DatabaseUpdater.java (version 91c6be799f090fa3b1fe1a9c325cdb4b68da1905)
  • api/src/main/java/org/openmrs/util/DrugsByNameComparator.java (version 91c6be799f090fa3b1fe1a9c325cdb4b68da1905)
  • api/src/main/java/org/openmrs/util/OpenmrsConstants.java (version 91c6be799f090fa3b1fe1a9c325cdb4b68da1905)
  • api/src/main/java/org/openmrs/util/UpgradeUtil.java (version 91c6be799f090fa3b1fe1a9c325cdb4b68da1905)
  • web/src/main/java/org/openmrs/scheduler/web/controller/SchedulerFormController.java (version 91c6be799f090fa3b1fe1a9c325cdb4b68da1905)
  • web/src/main/java/org/openmrs/web/controller/concept/ConceptMapTypeFormController.java (version 91c6be799f090fa3b1fe1a9c325cdb4b68da1905)
  • web/src/main/java/org/openmrs/web/controller/layout/NameLayoutPortletController.java (version 91c6be799f090fa3b1fe1a9c325cdb4b68da1905)
  • web/src/main/java/org/openmrs/web/controller/person/PersonFormController.java (version 91c6be799f090fa3b1fe1a9c325cdb4b68da1905)
• 

  Rafal Korytkowski 26 Feb 2015 e72845c86bf3448ccac293f5d1e7931a8c7b7782

  Revert "TRUNK-3675 - Cache results from getSearchLocales()
  This reverts commit cac67ea2baa38d4574ff34ae8d6afc6b2f30e21b.
  
  Conflicts:
          api/src/main/java/org/openmrs/api/impl/UserServiceImpl.java

  • api/src/main/java/org/openmrs/api/AdministrationService.java (version e72845c86bf3448ccac293f5d1e7931a8c7b7782)
  • api/src/main/java/org/openmrs/api/context/Context.java (version e72845c86bf3448ccac293f5d1e7931a8c7b7782)
  • api/src/main/java/org/openmrs/api/impl/AdministrationServiceImpl.java (version e72845c86bf3448ccac293f5d1e7931a8c7b7782)
  • api/src/main/java/org/openmrs/api/impl/UserServiceImpl.java (version e72845c86bf3448ccac293f5d1e7931a8c7b7782)
  • api/src/main/java/org/openmrs/util/OpenmrsConstants.java (version e72845c86bf3448ccac293f5d1e7931a8c7b7782)
  • api/src/main/resources/api-ehcache.xml (version e72845c86bf3448ccac293f5d1e7931a8c7b7782)
  • api/src/main/resources/applicationContext-service.xml (version e72845c86bf3448ccac293f5d1e7931a8c7b7782)
  • api/src/test/java/org/openmrs/api/AdministrationServiceTest.java (version e72845c86bf3448ccac293f5d1e7931a8c7b7782)
  • pom.xml (version e72845c86bf3448ccac293f5d1e7931a8c7b7782)
  • test/pom.xml (version e72845c86bf3448ccac293f5d1e7931a8c7b7782)
  • web/pom.xml (version e72845c86bf3448ccac293f5d1e7931a8c7b7782)
  • web/src/test/java/org/openmrs/module/web/WebModuleUtilTest.java (version e72845c86bf3448ccac293f5d1e7931a8c7b7782)
• 

  Daniel Kayiwa 26 Feb 2015 7d229c866aab64bd272eb3f6744ffc9b81ddf4d7

  Merge pull request #1364 from SandeepRaparthi1/TRUNK-4617
  TRUNK-4617:patient_identifier.patient_id is missing foreign key to patie...
• 

  SandeepRaparthi1 <kmit.sandeep@gmail.com> 26 Feb 2015 f59c51573275e9f46f3e4474a7fd3357beb0fe7e

  TRUNK-4617:patient_identifier.patient_id is missing foreign key to patient
  TRUNK-4617:patient_identifier.patient_id is missing foreign key to patient

  • api/src/main/resources/liquibase-update-to-latest.xml (version f59c51573275e9f46f3e4474a7fd3357beb0fe7e)
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 24 Feb 2015 aac7243f539a932260066a54fbc35b853cc2abb6

  fixed one import issue and successfully ran mvn clean install

  • api/src/main/java/org/openmrs/Obs.java (version aac7243f539a932260066a54fbc35b853cc2abb6)
  • api/src/main/java/org/openmrs/Person.java (version aac7243f539a932260066a54fbc35b853cc2abb6)
  • api/src/main/java/org/openmrs/api/db/hibernate/HibernateContextDAO.java (version aac7243f539a932260066a54fbc35b853cc2abb6)
  • api/src/main/java/org/openmrs/api/impl/ConceptServiceImpl.java (version aac7243f539a932260066a54fbc35b853cc2abb6)
  • api/src/main/java/org/openmrs/api/impl/EncounterServiceImpl.java (version aac7243f539a932260066a54fbc35b853cc2abb6)
  • api/src/main/java/org/openmrs/api/impl/FormServiceImpl.java (version aac7243f539a932260066a54fbc35b853cc2abb6)
  • api/src/main/java/org/openmrs/api/impl/ObsServiceImpl.java (version aac7243f539a932260066a54fbc35b853cc2abb6)
  • api/src/main/java/org/openmrs/api/impl/OrderServiceImpl.java (version aac7243f539a932260066a54fbc35b853cc2abb6)
  • api/src/main/java/org/openmrs/api/impl/PatientServiceImpl.java (version aac7243f539a932260066a54fbc35b853cc2abb6)
  • api/src/main/java/org/openmrs/api/impl/UserServiceImpl.java (version aac7243f539a932260066a54fbc35b853cc2abb6)
  • web/src/main/java/org/openmrs/web/controller/concept/ConceptProposalFormController.java (version aac7243f539a932260066a54fbc35b853cc2abb6)
  • web/src/main/java/org/openmrs/web/controller/person/PersonFormController.java (version aac7243f539a932260066a54fbc35b853cc2abb6)
  • web/src/main/java/org/openmrs/web/controller/provider/ProviderFormController.java (version aac7243f539a932260066a54fbc35b853cc2abb6)
  • web/src/main/java/org/openmrs/web/dwr/DWRConceptService.java (version aac7243f539a932260066a54fbc35b853cc2abb6)
  • web/src/main/java/org/openmrs/web/dwr/DWREncounterService.java (version aac7243f539a932260066a54fbc35b853cc2abb6)
  • web/src/main/java/org/openmrs/web/dwr/DWRVisitService.java (version aac7243f539a932260066a54fbc35b853cc2abb6)
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 24 Feb 2015 1cda3c287ed042690d67ab53bee54e41beb301fe

  resolved all conflicts from upstream/gci-2014 branch
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 24 Feb 2015 855bf8c0a756a91d15ba5f9b44bf85759fd0f063

  Merge pull request #1356 from k-joseph/gci-2014-resolve
  Resolved all conflicts with the remaining 9 GCI Pull requests
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 24 Feb 2015 20865f2230f1dcc8a18649b56ba3bdba0ea4c895

  formatted every thing with mvn clean install and cleared introduced issues by previous PRs

  • api/src/main/java/org/openmrs/Concept.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/ConceptName.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/ConceptReferenceTerm.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/Person.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/SimpleDosingInstructions.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/annotation/OpenmrsProfileExcludeFilter.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/aop/AuthorizationAdvice.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/api/context/UserContext.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/api/db/hibernate/AuditableInterceptor.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/api/db/hibernate/ChainingInterceptor.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/api/db/hibernate/HibernatePatientSetDAO.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/api/db/hibernate/HibernatePersonDAO.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/api/db/hibernate/HibernateUserDAO.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/api/db/hibernate/PersonSearchCriteria.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/api/handler/BaseUnretireHandler.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/api/handler/BaseUnvoidHandler.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/api/handler/OpenmrsObjectSaveHandler.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/api/handler/PersonUnvoidHandler.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/api/impl/ConceptServiceImpl.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/api/impl/EncounterServiceImpl.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/api/impl/OrderServiceImpl.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/api/impl/PatientServiceImpl.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/api/impl/PersonServiceImpl.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/hl7/handler/ORUR01Handler.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/layout/web/LayoutSupport.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/layout/web/LayoutTemplate.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/logic/result/Result.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/module/ModuleClassLoader.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/module/ModuleConditionalResource.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/module/ModuleFactory.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/reporting/DrugOrderFilter.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/reporting/PatientSearch.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/util/DatabaseUpdater.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/util/FormUtil.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/util/HandlerUtil.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/util/LocaleUtility.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/util/OpenmrsClassLoader.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/util/databasechange/ConceptValidatorChangeSet.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/validator/BaseAttributeTypeValidator.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/validator/BaseCustomizableValidator.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/validator/ConceptMapTypeValidator.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/validator/ConceptReferenceTermValidator.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/validator/ConceptValidator.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/validator/DrugOrderValidator.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/validator/EncounterRoleValidator.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/validator/EncounterTypeValidator.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/validator/LocationValidator.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/validator/PatientIdentifierValidator.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/validator/PatientValidator.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/validator/RelationshipValidator.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • api/src/main/java/org/openmrs/xml/OpenmrsLabelLogic.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/module/web/WebModuleUtil.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/scheduler/web/controller/SchedulerFormController.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/OpenmrsCookieLocaleResolver.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/controller/ConceptFormController.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/controller/OptionsFormController.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/controller/PortletController.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/controller/concept/ConceptDrugFormController.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/controller/encounter/EncounterRoleFormController.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/controller/hl7/HL7SourceFormController.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/controller/patient/PatientFormController.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/controller/patient/PatientGraphData.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/controller/patient/ShortPatientFormController.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/controller/person/AddPersonController.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/controller/person/PersonFormController.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/controller/provider/ProviderFormController.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/controller/user/RoleFormController.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/controller/user/UserFormController.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/controller/visit/VisitListController.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/dwr/ConceptListItem.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/dwr/DWREncounterService.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/dwr/DWRFormService.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/dwr/DWRPatientService.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/dwr/DWRPatientSetService.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/dwr/DWRPersonService.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/filter/GZIPResponseWrapper.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/filter/util/FilterUtil.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/servlet/AbstractGraphServlet.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/servlet/LoginServlet.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/servlet/QuickReportServlet.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/taglib/FieldGenTag.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/taglib/HtmlIncludeTag.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/taglib/ObsTableWidget.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/taglib/SummaryTest.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/taglib/fieldgen/AbstractFieldGenHandler.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/main/java/org/openmrs/web/taglib/fieldgen/ProgramWorkflowHandler.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
  • web/src/test/java/org/openmrs/web/controller/patient/ShortPatientFormControllerTest.java (version 20865f2230f1dcc8a18649b56ba3bdba0ea4c895)
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 24 Feb 2015 f0a18987d7ea83935e28e7443b0af9bd3f0b4809

  re-created commits in https://github.com/openmrs/openmrs-core/pull/1219 since itatriev deleted his openmrs-core fork

  • api/src/main/java/org/openmrs/Cohort.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • api/src/main/java/org/openmrs/Patient.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • api/src/main/java/org/openmrs/reporting/CompoundPatientFilter.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • api/src/main/java/org/openmrs/reporting/DrugOrderPatientFilter.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • api/src/main/java/org/openmrs/reporting/ReportObjectXMLDecoder.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • api/src/main/java/org/openmrs/reporting/export/DataExportReportObject.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • api/src/main/java/org/openmrs/util/DatabaseUpdater.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • api/src/main/java/org/openmrs/util/DrugsByNameComparator.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • api/src/main/java/org/openmrs/util/Format.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • api/src/main/java/org/openmrs/util/OpenmrsConstants.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • web/src/main/java/org/openmrs/scheduler/web/controller/SchedulerFormController.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • web/src/main/java/org/openmrs/web/controller/concept/ConceptDrugFormController.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • web/src/main/java/org/openmrs/web/controller/concept/ConceptMapTypeFormController.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • web/src/main/java/org/openmrs/web/controller/encounter/LocationFormController.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • web/src/main/java/org/openmrs/web/controller/form/FieldFormController.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • web/src/main/java/org/openmrs/web/controller/hl7/HL7SourceFormController.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • web/src/main/java/org/openmrs/web/controller/layout/NameLayoutPortletController.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • web/src/main/java/org/openmrs/web/controller/person/PersonFormController.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • web/src/main/java/org/openmrs/web/controller/user/RoleFormController.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
  • web/src/main/java/org/openmrs/web/taglib/fieldgen/DrugHandler.java (version f0a18987d7ea83935e28e7443b0af9bd3f0b4809)
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 24 Feb 2015 cb5fa3e022ef2f593430ac9d35a46149155890ca

  resolved conflicts from https://github.com/openmrs/openmrs-core/pull/1208
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 24 Feb 2015 97c7f07176499e70d2a86fb33f80435ee6d4c210

  resolved conflicts from https://github.com/openmrs/openmrs-core/pull/1209
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 24 Feb 2015 9a3a0aa6148de59e66aa4293d480454056203c99

  Merge branch 'gci-9-10' of https://github.com/Izaron/openmrs-core into gci-2014-resolve
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 24 Feb 2015 388f9687afe086f95072d7d4028815d51e4ebc74

  resolved conflicts from https://github.com/openmrs/openmrs-core/pull/1212
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 23 Feb 2015 abc1e3646a994114c53aee7fcf1c97a6ed7529f2

  resolved conflicts from https://github.com/openmrs/openmrs-core/pull/1233
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 23 Feb 2015 c630522b404701d4d7c83c2c391a9558d097008f

  resolved conflicts from https://github.com/openmrs/openmrs-core/pull/1235
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 21 Feb 2015 3f74f2d1fddeb425f7224ce80db81c6da85ace4f

  Merge pull request #1234 from Undo1/GCI-9
  GCI-9: Useless parentheses around expressions should be removed to prevent any misunderstanding
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 21 Feb 2015 419a8fa4e66a14cac93f9c565d864ac0eca0c4ac

  Merge pull request #1211 from Izaron/gci-9-11
  Array designators "[]" should be on the type, not the variable
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 21 Feb 2015 4370eb0853d3caba583a6ecef215a28ffa7adfb8

  Merge pull request #1204 from Izaron/gci-new-2
  Switch statements should end with a default case
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 21 Feb 2015 7e6eeb9ce35ab06be2420c489e5980d87be7372d

  Merge pull request #1202 from chaityabshah/GCI-9-2
  Moved left curly braces to the ends of lines of code
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 21 Feb 2015 f1120107f8fe5997ad8e2d736c272ae60bc7be98

  Merge pull request #1201 from chaityabshah/GCI-9
  Merged collapsible if statements
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 21 Feb 2015 e9e4a2aa3435129487998cd4a64475ff8be0cfe2

  Merge pull request #1200 from Izaron/gci-9-new
  Constants should be declared 'final static' rather than merely 'final'
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 21 Feb 2015 8ab039cd19e7e41f9c1dfa5b7e087e450fa4a092

  Merge pull request #1197 from Izaron/gci-2014
  Classes from com.sun.* and sun.* packages should not be used, Unused local variables should be removed, Correctness - Suspicious reference comparison of Boolean values
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 21 Feb 2015 ecd34bc1a08827fa06b4477cb2df100a2f05ce3a

  Merge pull request #1192 from azuro/gci-9-4
  GCI-9 #4
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 13 Feb 2015 a6485c2f191168498a2a5048e47e5ce421d67ddc

  Merge pull request #1338 from openmrs/revert-1186-gci-9
  Revert "GCI - 9 #1"
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 13 Feb 2015 b818792734a37367e3f58ae5705eff3fe77b941b

  Revert "GCI - 9 #1"

  • api/src/main/java/org/openmrs/PersonName.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • api/src/main/java/org/openmrs/api/context/Context.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • api/src/main/java/org/openmrs/api/context/Daemon.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • api/src/main/java/org/openmrs/api/context/ServiceContext.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • api/src/main/java/org/openmrs/hl7/handler/ORUR01Handler.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • api/src/main/java/org/openmrs/module/ModuleFactory.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • api/src/main/java/org/openmrs/reporting/export/DataExportFunctions.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • api/src/main/java/org/openmrs/reporting/export/DataExportUtil.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • api/src/main/java/org/openmrs/reporting/export/RowPerObsDataExportReportObject.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • api/src/main/java/org/openmrs/util/DatabaseUpdater.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • api/src/main/java/org/openmrs/util/MemoryLeakUtil.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • web/src/main/java/org/openmrs/web/Listener.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • web/src/main/java/org/openmrs/web/controller/concept/ConceptClassListController.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • web/src/main/java/org/openmrs/web/controller/concept/ConceptDatatypeListController.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • web/src/main/java/org/openmrs/web/controller/encounter/LocationListController.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • web/src/main/java/org/openmrs/web/controller/form/FormListController.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • web/src/main/java/org/openmrs/web/controller/patient/MergePatientsFormController.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • web/src/main/java/org/openmrs/web/controller/program/StateConversionListController.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • web/src/main/java/org/openmrs/web/controller/user/PrivilegeListController.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
  • web/src/main/java/org/openmrs/web/taglib/FieldGenTag.java (version b818792734a37367e3f58ae5705eff3fe77b941b)
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 13 Feb 2015 ae54d9470534fa3f65c45b9f298f03d2334d1d27

  Merge pull request #1186 from azuro/gci-9
  GCI - 9 #1
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 13 Feb 2015 11e90f2b3e4798751c02dad64e4aefdfa5ee7556

  Merge pull request #1183 from Izaron/gci-9-1
  GCI-9 - Collections.emptyList(),emptyMap() and emptySet() should be used instead and Empty statements should be removed
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 13 Feb 2015 e932a44816ff272b43e983be19dd4b3a6948b425

  Merge pull request #1181 from chaityabshah/randomGenerator
  Using Random nextInt() instead of Math.random()
• 

  k-joseph <kaweesi.joseph2012@gmail.com> 13 Feb 2015 51fdcb2c5b11993ed44cd624e17892105c363ead

  Merge pull request #1180 from chaityabshah/valueOf_string
  Changed String constructor to valueOf
• 

  Imran Tatriev <itatriev@gmail.com> 05 Jan 2015 01ee8d7c7abb61fa77b2597590a19e0e3a4a87e3

  Right curly braces should be located at the beginning of lines of code

  • api/src/main/java/org/openmrs/api/db/hibernate/HibernateUserDAO.java (version 01ee8d7c7abb61fa77b2597590a19e0e3a4a87e3)
  • api/src/main/java/org/openmrs/api/impl/PatientServiceImpl.java (version 01ee8d7c7abb61fa77b2597590a19e0e3a4a87e3)
  • api/src/main/java/org/openmrs/logic/result/Result.java (version 01ee8d7c7abb61fa77b2597590a19e0e3a4a87e3)
  • api/src/main/java/org/openmrs/propertyeditor/WorkflowCollectionEditor.java (version 01ee8d7c7abb61fa77b2597590a19e0e3a4a87e3)
  • api/src/main/java/org/openmrs/util/Reflect.java (version 01ee8d7c7abb61fa77b2597590a19e0e3a4a87e3)
  • api/src/main/java/org/openmrs/validator/RequireNameValidator.java (version 01ee8d7c7abb61fa77b2597590a19e0e3a4a87e3)
  • web/src/main/java/org/openmrs/web/controller/PortletController.java (version 01ee8d7c7abb61fa77b2597590a19e0e3a4a87e3)
  • web/src/main/java/org/openmrs/web/controller/user/UserFormController.java (version 01ee8d7c7abb61fa77b2597590a19e0e3a4a87e3)
  • web/src/main/java/org/openmrs/web/dwr/DWRFormService.java (version 01ee8d7c7abb61fa77b2597590a19e0e3a4a87e3)
  • web/src/main/java/org/openmrs/web/filter/GZIPResponseWrapper.java (version 01ee8d7c7abb61fa77b2597590a19e0e3a4a87e3)
• 

  Imran Tatriev <itatriev@gmail.com> 05 Jan 2015 8f1be70f033e21d138b0be92d43e780378282437

  Synchronized classes Vector, Hashtable, Stack and StringBuffer should not be used

  • api/src/main/java/org/openmrs/api/db/hibernate/PatientSearchCriteria.java (version 8f1be70f033e21d138b0be92d43e780378282437)
  • api/src/main/java/org/openmrs/notification/Message.java (version 8f1be70f033e21d138b0be92d43e780378282437)
  • api/src/main/java/org/openmrs/notification/impl/AlertServiceImpl.java (version 8f1be70f033e21d138b0be92d43e780378282437)
  • api/src/main/java/org/openmrs/util/HttpClient.java (version 8f1be70f033e21d138b0be92d43e780378282437)
  • web/src/main/java/org/openmrs/web/WebUtil.java (version 8f1be70f033e21d138b0be92d43e780378282437)
  • web/src/main/java/org/openmrs/web/filter/initialization/TestInstallUtil.java (version 8f1be70f033e21d138b0be92d43e780378282437)
  • web/src/main/java/org/openmrs/web/servlet/SampleFlowsheetServlet.java (version 8f1be70f033e21d138b0be92d43e780378282437)
  • web/src/main/java/org/openmrs/web/taglib/HtmlIncludeTag.java (version 8f1be70f033e21d138b0be92d43e780378282437)
• 

  Undo1 <parker@erwaysoftware.com> 03 Jan 2015 58af2665cba0fe5ed8812f2c29839a8f968e8d0c

  Literal boolean values should not be used in condition expressions

  • api/src/main/java/org/openmrs/Concept.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/Encounter.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/Obs.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/Patient.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/Person.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/Program.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/User.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/aop/AuthorizationAdvice.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/aop/LoggingAdvice.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/api/context/ServiceContext.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/api/db/hibernate/HibernateFormDAO.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/api/db/hibernate/HibernatePatientSetDAO.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/api/db/hibernate/HibernatePersonDAO.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/api/db/hibernate/PersonSearchCriteria.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/api/impl/ConceptServiceImpl.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/api/impl/FormServiceImpl.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/api/impl/ObsServiceImpl.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/api/impl/PatientServiceImpl.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/api/impl/UserServiceImpl.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/module/ModuleFactory.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/module/ModuleUtil.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/scheduler/tasks/CheckInternetConnectivityTask.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • api/src/main/java/org/openmrs/util/DatabaseUtil.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • web/src/main/java/org/openmrs/module/web/taglib/ExtensionPointTag.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • web/src/main/java/org/openmrs/notification/web/controller/AlertFormController.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • web/src/main/java/org/openmrs/web/controller/patient/ShortPatientFormController.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • web/src/main/java/org/openmrs/web/dwr/DWRConceptService.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • web/src/main/java/org/openmrs/web/dwr/DWREncounterService.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • web/src/main/java/org/openmrs/web/dwr/FieldListItem.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • web/src/main/java/org/openmrs/web/dwr/FormFieldListItem.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • web/src/main/java/org/openmrs/web/servlet/QuickReportServlet.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • web/src/main/java/org/openmrs/web/servlet/SampleFlowsheetServlet.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • web/src/main/java/org/openmrs/web/taglib/ForEachRecordTag.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • web/src/main/java/org/openmrs/web/taglib/FormatDateTag.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
  • web/src/main/java/org/openmrs/web/taglib/RequireTag.java (version 58af2665cba0fe5ed8812f2c29839a8f968e8d0c)
• 

  Undo1 <parker@erwaysoftware.com> 02 Jan 2015 33e22112649fd2a5c05c175221aa777402050e25

  Useless parentheses around expressions should be removed to prevent any misunderstanding

  • api/src/main/java/org/openmrs/ConceptNumeric.java (version 33e22112649fd2a5c05c175221aa777402050e25)
  • api/src/main/java/org/openmrs/ConceptReferenceTermMap.java (version 33e22112649fd2a5c05c175221aa777402050e25)
  • api/src/main/java/org/openmrs/ConceptStateConversion.java (version 33e22112649fd2a5c05c175221aa777402050e25)
  • api/src/main/java/org/openmrs/FormField.java (version 33e22112649fd2a5c05c175221aa777402050e25)
  • api/src/main/java/org/openmrs/Obs.java (version 33e22112649fd2a5c05c175221aa777402050e25)
  • api/src/main/java/org/openmrs/PersonAddress.java (version 33e22112649fd2a5c05c175221aa777402050e25)
  • api/src/main/java/org/openmrs/ProgramWorkflowState.java (version 33e22112649fd2a5c05c175221aa777402050e25)
  • api/src/main/java/org/openmrs/Role.java (version 33e22112649fd2a5c05c175221aa777402050e25)
  • api/src/main/java/org/openmrs/Tribe.java (version 33e22112649fd2a5c05c175221aa777402050e25)
  • api/src/main/java/org/openmrs/module/ModuleConditionalResource.java (version 33e22112649fd2a5c05c175221aa777402050e25)
• 

  Alvis <pwmvx1289@hotmail.com> 15 Dec 2014 afe4a1222b9047d3417398fd8aba7d6b17cd9340

  Deprecated elements should have both the annotation and the Javadoc tag
  Put else in same line with last curly braces
  
  Deprecated elements should have both the annotation and the Javadoc tag

  • api/src/main/java/org/openmrs/Cohort.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/Concept.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/ConceptSource.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/Drug.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/Encounter.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/Obs.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/Order.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/PatientIdentifierType.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/PatientProgram.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/Person.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/PersonName.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/Relationship.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/RelationshipType.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/Tribe.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/api/db/hibernate/HibernatePersonDAO.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/api/db/hibernate/search/ConceptNameSimilarity.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/api/impl/CohortServiceImpl.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/api/impl/ConceptServiceImpl.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/api/impl/LocationServiceImpl.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/api/impl/PatientSetServiceImpl.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/module/Module.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/module/ModuleFactory.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/reporting/ProgramPatientFilter.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/util/DatabaseUtil.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/util/InsertedOrderComparator.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/util/OpenmrsClassLoader.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/util/OpenmrsUtil.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • api/src/main/java/org/openmrs/validator/OrderValidator.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • web/src/main/java/org/openmrs/web/controller/PortletController.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • web/src/main/java/org/openmrs/web/controller/patient/PatientGraphData.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • web/src/main/java/org/openmrs/web/controller/user/UserFormController.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • web/src/main/java/org/openmrs/web/dwr/DWRFormService.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • web/src/main/java/org/openmrs/web/dwr/DWRPatientService.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • web/src/main/java/org/openmrs/web/dwr/DWRPatientSetService.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • web/src/main/java/org/openmrs/web/dwr/DWRPersonService.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • web/src/main/java/org/openmrs/web/filter/GZIPResponseWrapper.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • web/src/main/java/org/openmrs/web/servlet/AbstractGraphServlet.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
  • web/src/main/java/org/openmrs/web/taglib/ObsTableWidget.java (version afe4a1222b9047d3417398fd8aba7d6b17cd9340)
• 

  Izaron <izarizar@mail.ru> 14 Dec 2014 e7ed1046850d957fe4305c296073053a439e8bc5

  Array designators "[]" should be on the type, not the variable
  Ticket: https://issues.openmrs.org/browse/GCI-9

  • api/src/main/java/org/openmrs/util/OpenmrsUtil.java (version e7ed1046850d957fe4305c296073053a439e8bc5)
• 

  Izaron <izarizar@mail.ru> 14 Dec 2014 5593d75779ca148f655b09385be3b54f1df32b74

  Useless imports should be removed
  Ticket: https://issues.openmrs.org/browse/GCI-9

  • api/src/main/java/org/openmrs/Form.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/PersonAddress.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/PersonName.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/api/db/PatientSetDAO.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/api/db/hibernate/HibernateContextDAO.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/api/db/hibernate/HibernateOrderDAO.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/api/db/hibernate/NativeIfNotAssignedIdentityGenerator.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/api/impl/CohortServiceImpl.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/api/impl/EncounterServiceImpl.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/customdatatype/DownloadableDatatypeHandler.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/customdatatype/datatype/SpecifiedTextOptionsDatatype.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/hl7/db/hibernate/HibernateHL7DAO.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/logic/Rule.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/obs/handler/ImageHandler.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/propertyeditor/LocationAttributeTypeEditor.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/propertyeditor/ProgramEditor.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/reporting/ProgramPatientFilter.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/reporting/ReportObjectFactory.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/scheduler/tasks/AutoCloseVisitsTask.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/scheduler/tasks/HelloWorldTask.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/util/Reflect.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/util/Security.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/util/databasechange/ConceptValidatorChangeSet.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/validator/BaseAttributeTypeValidator.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/validator/ConceptSourceValidator.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/validator/ConceptValidator.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/validator/EncounterRoleValidator.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/validator/PatientValidator.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • api/src/main/java/org/openmrs/validator/ProgramValidator.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/hl7/web/controller/Hl7InArchiveMigrationController.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/module/web/WebModuleUtil.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/module/web/filter/ForcePasswordChangeFilter.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/attribute/WebAttributeUtil.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/controller/concept/ConceptProposalFormController.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/controller/concept/ConceptSourceListController.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/controller/concept/ConceptStopWordFormController.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/controller/encounter/EncounterTypeListController.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/controller/hl7/HL7SourceFormController.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/controller/observation/handler/WebHandlerUtils.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/controller/patient/PatientIdentifierTypeListController.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/controller/patient/ShortPatientFormValidator.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/controller/person/PersonAttributeTypeListController.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/controller/person/RelationshipTypeListController.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/controller/program/PatientProgramFormController.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/controller/program/WorkflowFormController.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/controller/visit/VisitFormController.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/dwr/DWRVisitService.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/dwr/PersonListItem.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/filter/OpenmrsFilter.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/servlet/ComplexObsServlet.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/taglib/ShowGraphTag.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
  • web/src/main/java/org/openmrs/web/taglib/functions/Sort.java (version 5593d75779ca148f655b09385be3b54f1df32b74)
• 

  Izaron <izarizar@mail.ru> 14 Dec 2014 81af284b87c0224e335d9c1d7b2c16cf0c711347

  if/else/for/while/do statements should always use curly braces
  Ticket: https://issues.openmrs.org/browse/GCI-9

  • api/src/main/java/org/openmrs/Duration.java (version 81af284b87c0224e335d9c1d7b2c16cf0c711347)
  • api/src/main/java/org/openmrs/Obs.java (version 81af284b87c0224e335d9c1d7b2c16cf0c711347)
  • api/src/main/java/org/openmrs/Order.java (version 81af284b87c0224e335d9c1d7b2c16cf0c711347)
  • api/src/main/java/org/openmrs/PersonName.java (version 81af284b87c0224e335d9c1d7b2c16cf0c711347)
  • api/src/main/java/org/openmrs/api/db/hibernate/HibernateOrderDAO.java (version 81af284b87c0224e335d9c1d7b2c16cf0c711347)
  • api/src/main/java/org/openmrs/api/db/hibernate/HibernatePersonDAO.java (version 81af284b87c0224e335d9c1d7b2c16cf0c711347)
  • api/src/main/java/org/openmrs/api/db/hibernate/PersonSearchCriteria.java (version 81af284b87c0224e335d9c1d7b2c16cf0c711347)
  • api/src/main/java/org/openmrs/api/db/hibernate/search/ConceptNameSimilarity.java (version 81af284b87c0224e335d9c1d7b2c16cf0c711347)
  • api/src/main/java/org/openmrs/reporting/DrugOrderFilter.java (version 81af284b87c0224e335d9c1d7b2c16cf0c711347)
  • api/src/main/java/org/openmrs/reporting/ProgramPatientFilter.java (version 81af284b87c0224e335d9c1d7b2c16cf0c711347)
  • api/src/main/java/org/openmrs/util/HandlerUtil.java (version 81af284b87c0224e335d9c1d7b2c16cf0c711347)
  • api/src/main/java/org/openmrs/util/OpenmrsClassLoader.java (version 81af284b87c0224e335d9c1d7b2c16cf0c711347)
  • api/src/main/java/org/openmrs/validator/OrderValidator.java (version 81af284b87c0224e335d9c1d7b2c16cf0c711347)
  • web/src/main/java/org/openmrs/module/web/WebModuleUtil.java (version 81af284b87c0224e335d9c1d7b2c16cf0c711347)
  • web/src/main/java/org/openmrs/web/controller/OptionsFormController.java (version 81af284b87c0224e335d9c1d7b2c16cf0c711347)
  • web/src/main/java/org/openmrs/web/controller/user/UserFormController.java (version 81af284b87c0224e335d9c1d7b2c16cf0c711347)
• 

  Izaron <izarizar@mail.ru> 14 Dec 2014 2e44f20e3f7675235ce4dac08befec894a742bc3

  Left curly braces should be located at the end of lines of code
  Ticket: http://issues.openmrs.org/browse/GCI-9

  • api/src/main/java/org/openmrs/api/db/hibernate/ChainingInterceptor.java (version 2e44f20e3f7675235ce4dac08befec894a742bc3)
  • api/src/main/java/org/openmrs/module/ModuleFactory.java (version 2e44f20e3f7675235ce4dac08befec894a742bc3)
  • api/src/main/java/org/openmrs/propertyeditor/ConceptAnswersEditor.java (version 2e44f20e3f7675235ce4dac08befec894a742bc3)
  • api/src/main/java/org/openmrs/propertyeditor/ConceptSetsEditor.java (version 2e44f20e3f7675235ce4dac08befec894a742bc3)
  • web/src/main/java/org/openmrs/web/attribute/WebAttributeUtil.java (version 2e44f20e3f7675235ce4dac08befec894a742bc3)
• 

  Izaron <izarizar@mail.ru> 11 Dec 2014 71b3205c6dc2dcb6d4435154099244175d03c863

  Switch statements should end with a default case

  • api/src/main/java/org/openmrs/api/db/hibernate/PatientSearchCriteria.java (version 71b3205c6dc2dcb6d4435154099244175d03c863)
• 

  Chaitya Shah <chaityabshah@verizon.net> 10 Dec 2014 3e244a2993152cf19fde6a3a1aebe17e83bae447

  Breaking lines that are too long

  • api/src/main/java/org/openmrs/Concept.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • api/src/main/java/org/openmrs/ConceptName.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • api/src/main/java/org/openmrs/ConceptReferenceTerm.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • api/src/main/java/org/openmrs/SimpleDosingInstructions.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • api/src/main/java/org/openmrs/annotation/OpenmrsProfileExcludeFilter.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • api/src/main/java/org/openmrs/api/context/UserContext.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • api/src/main/java/org/openmrs/api/handler/BaseUnretireHandler.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • api/src/main/java/org/openmrs/api/handler/BaseUnvoidHandler.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • api/src/main/java/org/openmrs/api/handler/PersonUnvoidHandler.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • api/src/main/java/org/openmrs/util/LocaleUtility.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • api/src/main/java/org/openmrs/util/databasechange/ConceptValidatorChangeSet.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • api/src/main/java/org/openmrs/validator/ConceptReferenceTermValidator.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • api/src/main/java/org/openmrs/validator/DrugOrderValidator.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • api/src/main/java/org/openmrs/validator/EncounterRoleValidator.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • api/src/main/java/org/openmrs/validator/EncounterTypeValidator.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • api/src/main/java/org/openmrs/validator/OrderValidator.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • api/src/main/java/org/openmrs/validator/PatientIdentifierValidator.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • web/src/main/java/org/openmrs/web/controller/OptionsFormController.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • web/src/main/java/org/openmrs/web/dwr/DWREncounterService.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
  • web/src/main/java/org/openmrs/web/taglib/fieldgen/AbstractFieldGenHandler.java (version 3e244a2993152cf19fde6a3a1aebe17e83bae447)
• 

  Anish Basu <anishbasu.pr@gmail.com> 10 Dec 2014 67d72b7af708e99c70d0358cf482a23d58df09ad

  Fixed naming of argument

  • api/src/main/java/org/openmrs/api/impl/OrderServiceImpl.java (version 67d72b7af708e99c70d0358cf482a23d58df09ad)
• 

  Chaitya Shah <chaityabshah@verizon.net> 10 Dec 2014 1cf3b5d75e77eaf5d9d424741b4c6d6c38e96c99

  Moved left curly braces to the ends of lines of code

  • api/src/main/java/org/openmrs/api/db/hibernate/ChainingInterceptor.java (version 1cf3b5d75e77eaf5d9d424741b4c6d6c38e96c99)
  • api/src/main/java/org/openmrs/module/ModuleFactory.java (version 1cf3b5d75e77eaf5d9d424741b4c6d6c38e96c99)
  • api/src/main/java/org/openmrs/propertyeditor/ConceptAnswersEditor.java (version 1cf3b5d75e77eaf5d9d424741b4c6d6c38e96c99)
  • api/src/main/java/org/openmrs/propertyeditor/ConceptSetsEditor.java (version 1cf3b5d75e77eaf5d9d424741b4c6d6c38e96c99)
  • web/src/main/java/org/openmrs/web/attribute/WebAttributeUtil.java (version 1cf3b5d75e77eaf5d9d424741b4c6d6c38e96c99)
• 

  Chaitya Shah <chaityabshah@verizon.net> 10 Dec 2014 5beff5e3ef832bc1ceadec383e0ff98971ae5afa

  Merged collapsible if statements

  • api/src/main/java/org/openmrs/Concept.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/ConceptName.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/ConceptReferenceTerm.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/Person.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/SimpleDosingInstructions.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/User.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/annotation/OpenmrsProfileExcludeFilter.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/aop/AuthorizationAdvice.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/api/context/UserContext.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/api/db/hibernate/AuditableInterceptor.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/api/db/hibernate/HibernatePatientSetDAO.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/api/handler/BaseUnretireHandler.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/api/handler/BaseUnvoidHandler.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/api/handler/OpenmrsObjectSaveHandler.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/api/handler/PersonUnvoidHandler.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/api/impl/ConceptServiceImpl.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/api/impl/EncounterServiceImpl.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/api/impl/OrderServiceImpl.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/api/impl/PersonServiceImpl.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/hl7/handler/ORUR01Handler.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/layout/web/LayoutSupport.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/layout/web/LayoutTemplate.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/module/ModuleClassLoader.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/reporting/DrugOrderFilter.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/reporting/PatientSearch.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/util/DatabaseUpdater.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/util/FormUtil.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/util/LocaleUtility.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/util/OpenmrsClassLoader.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/util/databasechange/ConceptValidatorChangeSet.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/validator/BaseAttributeTypeValidator.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/validator/BaseCustomizableValidator.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/validator/ConceptMapTypeValidator.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/validator/ConceptReferenceTermValidator.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/validator/ConceptValidator.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/validator/DrugOrderValidator.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/validator/EncounterRoleValidator.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/validator/EncounterTypeValidator.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/validator/LocationValidator.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/validator/OrderValidator.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/validator/PatientIdentifierValidator.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/validator/PatientValidator.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/validator/RelationshipValidator.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • api/src/main/java/org/openmrs/xml/OpenmrsLabelLogic.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/module/web/WebModuleUtil.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/OpenmrsCookieLocaleResolver.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/controller/ConceptFormController.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/controller/OptionsFormController.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/controller/PortletController.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/controller/encounter/EncounterRoleFormController.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/controller/patient/PatientFormController.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/controller/patient/ShortPatientFormController.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/controller/person/AddPersonController.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/controller/person/PersonFormController.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/controller/provider/ProviderFormController.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/controller/visit/VisitListController.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/dwr/ConceptListItem.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/dwr/DWREncounterService.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/filter/util/FilterUtil.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/servlet/LoginServlet.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/servlet/QuickReportServlet.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/taglib/FieldGenTag.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/taglib/HtmlIncludeTag.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/taglib/SummaryTest.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/taglib/fieldgen/AbstractFieldGenHandler.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/taglib/fieldgen/DrugHandler.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
  • web/src/main/java/org/openmrs/web/taglib/fieldgen/ProgramWorkflowHandler.java (version 5beff5e3ef832bc1ceadec383e0ff98971ae5afa)
• 

  Anish Basu <anishbasu.pr@gmail.com> 10 Dec 2014 d974937c5357520b7ce23b6d243be9462a767db6

  Fixed the static setter to comply with code guidelines

  • api/src/main/java/org/openmrs/api/impl/OrderServiceImpl.java (version d974937c5357520b7ce23b6d243be9462a767db6)
• 

  Izaron <izarizar@mail.ru> 10 Dec 2014 6286adf98d057421969738d43fa08f9e9effb43b

  Constants should be declared 'final static' rather than merely 'final'

  • api/src/main/java/org/openmrs/layout/web/LayoutTemplate.java (version 6286adf98d057421969738d43fa08f9e9effb43b)
  • api/src/main/java/org/openmrs/scheduler/Schedule.java (version 6286adf98d057421969738d43fa08f9e9effb43b)
  • api/src/main/java/org/openmrs/util/AttributableDate.java (version 6286adf98d057421969738d43fa08f9e9effb43b)
  • web/src/main/java/org/openmrs/module/web/ModuleResourcesServlet.java (version 6286adf98d057421969738d43fa08f9e9effb43b)
  • web/src/main/java/org/openmrs/web/OpenmrsCookieThemeResolver.java (version 6286adf98d057421969738d43fa08f9e9effb43b)
  • web/src/main/java/org/openmrs/web/controller/customdatatype/CustomValueController.java (version 6286adf98d057421969738d43fa08f9e9effb43b)
  • web/src/main/java/org/openmrs/web/controller/person/AddPersonController.java (version 6286adf98d057421969738d43fa08f9e9effb43b)
  • web/src/main/java/org/openmrs/web/filter/initialization/InitializationFilter.java (version 6286adf98d057421969738d43fa08f9e9effb43b)
  • web/src/main/java/org/openmrs/web/filter/startuperror/StartupErrorFilter.java (version 6286adf98d057421969738d43fa08f9e9effb43b)
  • web/src/main/java/org/openmrs/web/filter/update/UpdateFilter.java (version 6286adf98d057421969738d43fa08f9e9effb43b)
  • web/src/main/java/org/openmrs/web/taglib/ForEachDrugOrderTag.java (version 6286adf98d057421969738d43fa08f9e9effb43b)
• 

  Izaron <izarizar@mail.ru> 09 Dec 2014 b8a12c851c8d4d202d4231f9a55612dc1b571b7e

  Classes from com.sun.* and sun.* packages should not be used - Fixed

  • api/src/main/java/org/openmrs/util/MemoryLeakUtil.java (version b8a12c851c8d4d202d4231f9a55612dc1b571b7e)
  • tools/src/main/java/org/openmrs/tools/doclet/ShouldTaglet.java (version b8a12c851c8d4d202d4231f9a55612dc1b571b7e)
• 

  Izaron <izarizar@mail.ru> 09 Dec 2014 28b44d5e97de03106d451c6c437b7d30badb07c9

  Correctness - Suspicious reference comparison of Boolean values

  • api/src/main/java/org/openmrs/PatientProgram.java (version 28b44d5e97de03106d451c6c437b7d30badb07c9)
  • api/src/main/java/org/openmrs/api/db/hibernate/HibernateSerializedObjectDAO.java (version 28b44d5e97de03106d451c6c437b7d30badb07c9)
• 

  Izaron <izarizar@mail.ru> 09 Dec 2014 fd3e3daefc03760951938a679fa5dbac7219ec04

  Unused local variables should be removed

  • api/src/main/java/org/openmrs/api/impl/PatientServiceImpl.java (version fd3e3daefc03760951938a679fa5dbac7219ec04)
  • web/src/main/java/org/openmrs/web/controller/encounter/AddressTemplateController.java (version fd3e3daefc03760951938a679fa5dbac7219ec04)
  • web/src/main/java/org/openmrs/web/controller/form/FormFormController.java (version fd3e3daefc03760951938a679fa5dbac7219ec04)
  • web/src/main/java/org/openmrs/web/controller/program/WorkflowFormController.java (version fd3e3daefc03760951938a679fa5dbac7219ec04)
  • web/src/main/java/org/openmrs/web/servlet/DownloadDictionaryServlet.java (version fd3e3daefc03760951938a679fa5dbac7219ec04)
  • web/src/main/java/org/openmrs/web/taglib/ActiveListWidget.java (version fd3e3daefc03760951938a679fa5dbac7219ec04)
• 

  Izaron <izarizar@mail.ru> 09 Dec 2014 7a61d2b09de69dd01f1fe0a01ce36103ad7ab55a

  Classes from com.sun.* and sun.* packages should not be used

  • api/src/main/java/org/openmrs/util/MemoryLeakUtil.java (version 7a61d2b09de69dd01f1fe0a01ce36103ad7ab55a)
  • tools/src/main/java/org/openmrs/tools/doclet/ShouldTaglet.java (version 7a61d2b09de69dd01f1fe0a01ce36103ad7ab55a)
• 

  Anish Basu <anishbasu.pr@gmail.com> 08 Dec 2014 220649cf40ae2053d6bcd67477f1473f894a775b

  Added static method to prevent instance methods from setting static fields.

  • api/src/main/java/org/openmrs/api/impl/OrderServiceImpl.java (version 220649cf40ae2053d6bcd67477f1473f894a775b)
• 

  Anish Basu <anishbasu.pr@gmail.com> 08 Dec 2014 e882d0fff973bd8a417a66a8fff258d999f581e9

  Fixed the non closing of IputStreams after a successful/unsuccessful read.

  • api/src/main/java/org/openmrs/obs/handler/TextHandler.java (version e882d0fff973bd8a417a66a8fff258d999f581e9)
  • api/src/main/java/org/openmrs/util/OpenmrsUtil.java (version e882d0fff973bd8a417a66a8fff258d999f581e9)
  • api/src/main/java/org/openmrs/util/UpgradeUtil.java (version e882d0fff973bd8a417a66a8fff258d999f581e9)
• 

  Anish Basu <anishbasu.pr@gmail.com> 07 Dec 2014 5a58a4ac4be0bee7c3ab573f6bf325f68cb3df85

  Fixed inconsistent synchronization among class fields

  • api/src/main/java/org/openmrs/api/impl/DatatypeServiceImpl.java (version 5a58a4ac4be0bee7c3ab573f6bf325f68cb3df85)
  • web/src/main/java/org/openmrs/web/filter/update/UpdateFilter.java (version 5a58a4ac4be0bee7c3ab573f6bf325f68cb3df85)
• 

  Anish Basu <anishbasu.pr@gmail.com> 07 Dec 2014 35a8cf85bbb25e323719b695469c09905aa2b202

  Added appropriate handling for passing null values to non-null agruments.

  • api/src/main/java/org/openmrs/api/impl/ObsServiceImpl.java (version 35a8cf85bbb25e323719b695469c09905aa2b202)
  • api/src/main/java/org/openmrs/api/impl/PatientServiceImpl.java (version 35a8cf85bbb25e323719b695469c09905aa2b202)
  • api/src/main/java/org/openmrs/report/impl/DataSetServiceImpl.java (version 35a8cf85bbb25e323719b695469c09905aa2b202)
  • api/src/main/java/org/openmrs/report/impl/ReportServiceImpl.java (version 35a8cf85bbb25e323719b695469c09905aa2b202)
• 

  Anish Basu <anishbasu.pr@gmail.com> 07 Dec 2014 e1327981b7940be423db22cbfdef0af18506a1e6

  Fixed: compareTo methods now have equivalent equals methods and Database connections and statements are closed properly, reducing access times and memory footprints.

  • api/src/main/java/org/openmrs/ConceptAnswer.java (version e1327981b7940be423db22cbfdef0af18506a1e6)
  • api/src/main/java/org/openmrs/ConceptSet.java (version e1327981b7940be423db22cbfdef0af18506a1e6)
  • api/src/main/java/org/openmrs/FormField.java (version e1327981b7940be423db22cbfdef0af18506a1e6)
  • api/src/main/java/org/openmrs/PatientIdentifier.java (version e1327981b7940be423db22cbfdef0af18506a1e6)
  • api/src/main/java/org/openmrs/PatientState.java (version e1327981b7940be423db22cbfdef0af18506a1e6)
  • api/src/main/java/org/openmrs/PersonAttribute.java (version e1327981b7940be423db22cbfdef0af18506a1e6)
  • api/src/main/java/org/openmrs/PersonAttributeType.java (version e1327981b7940be423db22cbfdef0af18506a1e6)
  • api/src/main/java/org/openmrs/activelist/Problem.java (version e1327981b7940be423db22cbfdef0af18506a1e6)
  • api/src/main/java/org/openmrs/attribute/BaseAttribute.java (version e1327981b7940be423db22cbfdef0af18506a1e6)
  • api/src/main/java/org/openmrs/report/RenderingMode.java (version e1327981b7940be423db22cbfdef0af18506a1e6)
  • api/src/main/java/org/openmrs/reporting/DrugOrderPatientFilter.java (version e1327981b7940be423db22cbfdef0af18506a1e6)
  • api/src/main/java/org/openmrs/reporting/PatientCharacteristicFilter.java (version e1327981b7940be423db22cbfdef0af18506a1e6)
  • web/src/main/java/org/openmrs/web/controller/encounter/EncounterDisplayController.java (version e1327981b7940be423db22cbfdef0af18506a1e6)
  • web/src/main/java/org/openmrs/web/filter/initialization/InitializationFilter.java (version e1327981b7940be423db22cbfdef0af18506a1e6)
  • web/src/main/java/org/openmrs/web/filter/update/UpdateFilter.java (version e1327981b7940be423db22cbfdef0af18506a1e6)
  • web/src/main/java/org/openmrs/web/filter/util/FilterUtil.java (version e1327981b7940be423db22cbfdef0af18506a1e6)
• 

  azuro <azuro@github.com> 06 Dec 2014 f2e6002be940e5280136cb1a70d79eb32168c701

  Added System.gc() back and changed log.warn -> log.error for selected logs

  • api/src/main/java/org/openmrs/api/context/Daemon.java (version f2e6002be940e5280136cb1a70d79eb32168c701)
  • api/src/main/java/org/openmrs/reporting/export/DataExportFunctions.java (version f2e6002be940e5280136cb1a70d79eb32168c701)
  • api/src/main/java/org/openmrs/reporting/export/DataExportUtil.java (version f2e6002be940e5280136cb1a70d79eb32168c701)
  • api/src/main/java/org/openmrs/util/MemoryLeakUtil.java (version f2e6002be940e5280136cb1a70d79eb32168c701)
  • web/src/main/java/org/openmrs/web/Listener.java (version f2e6002be940e5280136cb1a70d79eb32168c701)
• 

  azuro <azuro@github.com> 05 Dec 2014 ab841baa9b55bde22bf9c3eb290e5be0e9388868

  Fixed: Invocation of toString on an array

  • api/src/main/java/org/openmrs/api/context/Context.java (version ab841baa9b55bde22bf9c3eb290e5be0e9388868)
  • web/src/main/java/org/openmrs/web/controller/patient/MergePatientsFormController.java (version ab841baa9b55bde22bf9c3eb290e5be0e9388868)
• 

  azuro <azuro@github.com> 05 Dec 2014 e01f75ff488c4243158a451a18c8028d9a12ee7c

  Corrected improper equals() operations.

  • api/src/main/java/org/openmrs/hl7/handler/ORUR01Handler.java (version e01f75ff488c4243158a451a18c8028d9a12ee7c)
  • api/src/main/java/org/openmrs/reporting/export/RowPerObsDataExportReportObject.java (version e01f75ff488c4243158a451a18c8028d9a12ee7c)
  • web/src/main/java/org/openmrs/web/controller/concept/ConceptClassListController.java (version e01f75ff488c4243158a451a18c8028d9a12ee7c)
  • web/src/main/java/org/openmrs/web/controller/concept/ConceptDatatypeListController.java (version e01f75ff488c4243158a451a18c8028d9a12ee7c)
  • web/src/main/java/org/openmrs/web/controller/encounter/LocationListController.java (version e01f75ff488c4243158a451a18c8028d9a12ee7c)
  • web/src/main/java/org/openmrs/web/controller/form/FormListController.java (version e01f75ff488c4243158a451a18c8028d9a12ee7c)
  • web/src/main/java/org/openmrs/web/controller/program/StateConversionListController.java (version e01f75ff488c4243158a451a18c8028d9a12ee7c)
  • web/src/main/java/org/openmrs/web/controller/user/PrivilegeListController.java (version e01f75ff488c4243158a451a18c8028d9a12ee7c)
• 

  azuro <azuro@github.com> 05 Dec 2014 c842d0a1d0bbecf3fe8c53d7b8c0bcbe1802b539

  Eradicated race conditions on lazy static initializations.

  • api/src/main/java/org/openmrs/api/context/ServiceContext.java (version c842d0a1d0bbecf3fe8c53d7b8c0bcbe1802b539)
  • api/src/main/java/org/openmrs/module/ModuleFactory.java (version c842d0a1d0bbecf3fe8c53d7b8c0bcbe1802b539)
  • api/src/main/java/org/openmrs/util/DatabaseUpdater.java (version c842d0a1d0bbecf3fe8c53d7b8c0bcbe1802b539)
• 

  azuro <azuro@github.com> 05 Dec 2014 ec424d641f7c41f83158c25e7188c86111407003

  Removed redundant null checks and used the logger utility instead of Throwable.printStackTrace()

  • api/src/main/java/org/openmrs/PersonName.java (version ec424d641f7c41f83158c25e7188c86111407003)
  • api/src/main/java/org/openmrs/api/context/Daemon.java (version ec424d641f7c41f83158c25e7188c86111407003)
  • api/src/main/java/org/openmrs/hl7/handler/ORUR01Handler.java (version ec424d641f7c41f83158c25e7188c86111407003)
  • api/src/main/java/org/openmrs/reporting/export/DataExportFunctions.java (version ec424d641f7c41f83158c25e7188c86111407003)
  • api/src/main/java/org/openmrs/reporting/export/DataExportUtil.java (version ec424d641f7c41f83158c25e7188c86111407003)
  • api/src/main/java/org/openmrs/util/MemoryLeakUtil.java (version ec424d641f7c41f83158c25e7188c86111407003)
  • web/src/main/java/org/openmrs/web/Listener.java (version ec424d641f7c41f83158c25e7188c86111407003)
  • web/src/main/java/org/openmrs/web/taglib/FieldGenTag.java (version ec424d641f7c41f83158c25e7188c86111407003)
• 

  Izaron <izarizar@mail.ru> 05 Dec 2014 c68a856577a6b0a57af70a8fd485aa23e960e05d

  Empty statements should be removed
  GCI-9
  Empty statements should be removed

  • api/src/main/java/org/openmrs/api/impl/ConceptServiceImpl.java (version c68a856577a6b0a57af70a8fd485aa23e960e05d)
  • api/src/main/java/org/openmrs/api/impl/PatientServiceImpl.java (version c68a856577a6b0a57af70a8fd485aa23e960e05d)
  • api/src/main/java/org/openmrs/module/ModuleMustStartException.java (version c68a856577a6b0a57af70a8fd485aa23e960e05d)
  • api/src/main/java/org/openmrs/reporting/export/DataExportFunctions.java (version c68a856577a6b0a57af70a8fd485aa23e960e05d)
  • api/src/main/java/org/openmrs/util/Format.java (version c68a856577a6b0a57af70a8fd485aa23e960e05d)
  • web/src/main/java/org/openmrs/web/controller/form/FormFormController.java (version c68a856577a6b0a57af70a8fd485aa23e960e05d)
  • web/src/main/java/org/openmrs/web/filter/StartupFilter.java (version c68a856577a6b0a57af70a8fd485aa23e960e05d)
• 

  Izaron <izarizar@mail.ru> 05 Dec 2014 29278cb691a3f8ac43f69e8b8537e3c3e128db98

  Collections.emptyList(),emptyMap() and emptySet() should be used instead of Collections.EMPTY_LIST, EMPTY_MAP and EMPTY_SET
  GCI-9
  Collections.emptyList(),emptyMap() and emptySet() should be used instead
  of Collections.EMPTY_LIST, EMPTY_MAP and EMPTY_SET

  • api/src/main/java/org/openmrs/api/context/ServiceContext.java (version 29278cb691a3f8ac43f69e8b8537e3c3e128db98)
  • api/src/main/java/org/openmrs/api/impl/ConceptServiceImpl.java (version 29278cb691a3f8ac43f69e8b8537e3c3e128db98)
  • api/src/main/java/org/openmrs/api/impl/VisitServiceImpl.java (version 29278cb691a3f8ac43f69e8b8537e3c3e128db98)
  • web/src/main/java/org/openmrs/web/controller/user/RoleFormController.java (version 29278cb691a3f8ac43f69e8b8537e3c3e128db98)
• 

  Chaitya Shah <chaityabshah@verizon.net> 03 Dec 2014 99dd84f9ed5c4125d6f7b3137f16a155f673a83e

  Using Random nextInt() instead of Math.random()

  • api/src/main/java/org/openmrs/util/OpenmrsUtil.java (version 99dd84f9ed5c4125d6f7b3137f16a155f673a83e)
  • web/src/main/java/org/openmrs/module/web/taglib/ExtensionPopupMenuTag.java (version 99dd84f9ed5c4125d6f7b3137f16a155f673a83e)
  • web/src/main/java/org/openmrs/web/taglib/ListPickerTag.java (version 99dd84f9ed5c4125d6f7b3137f16a155f673a83e)
• 

  Chaitya Shah <chaityabshah@verizon.net> 03 Dec 2014 2103e9fb1ca2e8bdd4b7e97687cab8a7744ed74e

  Changed String constructor to valueOf

  • api/src/main/java/org/openmrs/PersonName.java (version 2103e9fb1ca2e8bdd4b7e97687cab8a7744ed74e)
  • api/src/main/java/org/openmrs/obs/handler/AbstractHandler.java (version 2103e9fb1ca2e8bdd4b7e97687cab8a7744ed74e)
  • web/src/main/java/org/openmrs/web/dwr/DWRPersonService.java (version 2103e9fb1ca2e8bdd4b7e97687cab8a7744ed74e)