Build #563

Plan branch:
Sonar metrics for OpenMRS Core Master

Build: #563 failed Scheduled with changes by Wyclif Luyima

Build result summary

Details

Completed
Queue duration
12 seconds
Duration
19 minutes
Labels
None
Revision
dd8f405fe87b7242a4a97f1faa99f99a9b565359 dd8f405fe87b7242a4a97f1faa99f99a9b565359
Total tests
3417
Failing since
#524 (Scheduled with changes by Daniel Kayiwa – )
Fixed in
#675 (Manual run by Rafal Korytkowski)

Tests

Responsible

Code commits

Author Commit Message Commit date
Wyclif Luyima Wyclif Luyima dd8f405fe87b7242a4a97f1faa99f99a9b565359 dd8f405fe87b7242a4a97f1faa99f99a9b565359 Merge pull request #1517 from suniala/TRUNK-4711
TRUNK-4711: Fix javadoc compilation errors
Mikko Suniala <mikko.suniala@iki.fi> Mikko Suniala <mikko.suniala@iki.fi> 3f867cf590a4ee4bfbc5a82a0c6bc307c16aeb93 m 3f867cf590a4ee4bfbc5a82a0c6bc307c16aeb93 TRUNK-4711: Fix javadoc compilation errors
Fix all the errors that cause the javadoc generation to fail. Leave the
problems that only cause a warning to be reported. Remove the previously
added javadoc error suppression now that all errors are fixed.

Note that javadocs in test classes were not fixed as javadoc generation
does not cover test resources.

Summary of the types of problems fixed:

 * @link usage in @see tags

 * @return descriptions missing - The new @return descriptions not just
   fix the validation issues byt try to be meaningful (to the extent that
   the method contract could be easily figured out from the implementation
   or method description).

 * invalid @link or @see references - Some of the references were not
   meaningful any more and were just removed. Others were fixed to point at
   a most likely intended target.

 * invalid @param parameter names

 * javadoc tags in invalid case

 * unknown javadoc tags

 * invalid html markup

 * exceptions that are not actually thrown

Tests

New test failures 8
Status Test View job Duration
Collapse Failed SchedulerFormControllerTest onSubmit_shouldNotRescheduleATaskThatIsNotCurrentlyScheduled History
Sonar Full Analysis < 1 sec 
org.hibernate.NonUniqueResultException: query did not return a unique result: 2
	at org.hibernate.internal.AbstractQueryImpl.uniqueElement(AbstractQueryImpl.java:975)
	at org.hibernate.internal.CriteriaImpl.uniqueResult(CriteriaImpl.java:402)
	at org.openmrs.scheduler.db.hibernate.HibernateSchedulerDAO.getTaskByName(HibernateSchedulerDAO.java:93)
	at org.openmrs.scheduler.timer.TimerSchedulerServiceImpl.getTaskByName(TimerSchedulerServiceImpl.java:390)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
(28 more lines...)
Collapse Failed SchedulerFormControllerTest onSubmit_shouldNotRescheduleAnExecutingTask History
Sonar Full Analysis < 1 sec 
org.hibernate.NonUniqueResultException: query did not return a unique result: 2
	at org.hibernate.internal.AbstractQueryImpl.uniqueElement(AbstractQueryImpl.java:975)
	at org.hibernate.internal.CriteriaImpl.uniqueResult(CriteriaImpl.java:402)
	at org.openmrs.scheduler.db.hibernate.HibernateSchedulerDAO.getTaskByName(HibernateSchedulerDAO.java:93)
	at org.openmrs.scheduler.timer.TimerSchedulerServiceImpl.getTaskByName(TimerSchedulerServiceImpl.java:390)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
(28 more lines...)
Collapse Failed ConceptFormControllerTest shouldAddConceptWithAllNamingSpecified History
Sonar Full Analysis < 1 sec 
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertNotNull(Assert.java:621)
	at org.junit.Assert.assertNotNull(Assert.java:631)
	at org.openmrs.web.controller.ConceptFormControllerTest.shouldAddConceptWithAllNamingSpecified(ConceptFormControllerTest.java:345)
Collapse Failed ConceptFormControllerTest shouldUpdateConceptWithShortNameAlreadyInSynonymList History
Sonar Full Analysis < 1 sec 
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertNotNull(Assert.java:621)
	at org.junit.Assert.assertNotNull(Assert.java:631)
	at org.openmrs.web.controller.ConceptFormControllerTest.shouldUpdateConceptWithShortNameAlreadyInSynonymList(ConceptFormControllerTest.java:446)
Collapse Failed ConceptFormControllerTest shouldAddConceptWithNameAndShortNameAndDescriptionSpecifiedToNumericConcepts History
Sonar Full Analysis < 1 sec 
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertNotNull(Assert.java:621)
	at org.junit.Assert.assertNotNull(Assert.java:631)
	at org.openmrs.web.controller.ConceptFormControllerTest.shouldAddConceptWithNameAndShortNameAndDescriptionSpecifiedToNumericConcepts(ConceptFormControllerTest.java:294)
Collapse Failed ConceptFormControllerTest shouldAddConceptWithNameAndShortNameSpecified History
Sonar Full Analysis < 1 sec 
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertNotNull(Assert.java:621)
	at org.junit.Assert.assertNotNull(Assert.java:631)
	at org.openmrs.web.controller.ConceptFormControllerTest.shouldAddConceptWithNameAndShortNameSpecified(ConceptFormControllerTest.java:206)
Collapse Failed ConceptFormControllerTest shouldUpdateConceptWithNameAlreadyInSynonymList History
Sonar Full Analysis < 1 sec 
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertNotNull(Assert.java:621)
	at org.junit.Assert.assertNotNull(Assert.java:631)
	at org.openmrs.web.controller.ConceptFormControllerTest.shouldUpdateConceptWithNameAlreadyInSynonymList(ConceptFormControllerTest.java:397)
Collapse Failed ConceptFormControllerTest shouldAddConceptWithNameAndShortNameAndDescriptionSpecifiedToCodeConcepts History
Sonar Full Analysis < 1 sec 
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertNotNull(Assert.java:621)
	at org.junit.Assert.assertNotNull(Assert.java:631)
	at org.openmrs.web.controller.ConceptFormControllerTest.shouldAddConceptWithNameAndShortNameAndDescriptionSpecifiedToCodeConcepts(ConceptFormControllerTest.java:249)

Jira issues

IssueDescriptionStatus
Unknown Issue TypeTRUNK-4711Could not obtain issue details from Jira