Build: #1029 was successful
Job: Sonar Full Analysis was successful
Code commits
Git
-
Wyclif Luyima 72995397dd95fc197515c77a0b317b07fb566435
Merge pull request #1848 from teleivo/TRUNK-4953
ConceptSourceValidator doesnt fail on empty description - TRUNK-4953 -
teleivo <mrteleivo@gmail.com> 904d65a85cc01d6f9bc117ca86886a803ed34cac
TRUNK-4953 ConceptSourceValidator doesnt fail on empty description
Fixes ConceptSourceValidator which does not fail if "description" is
empty altough the description column is required.
* add not-null="true" to name and description fields in ConceptSource.hbm.xml
* Validator now fails on empty "description"
* add description in a ConceptServiceTest so it doesnt fail- api/src/main/java/org/openmrs/validator/ConceptSourceValidator.java (version 904d65a85cc01d6f9bc117ca86886a803ed34cac)
- api/src/main/resources/org/openmrs/api/db/hibernate/ConceptSource.hbm.xml (version 904d65a85cc01d6f9bc117ca86886a803ed34cac)
- api/src/test/java/org/openmrs/api/ConceptServiceTest.java (version 904d65a85cc01d6f9bc117ca86886a803ed34cac)
- api/src/test/java/org/openmrs/validator/ConceptSourceValidatorTest.java (version 904d65a85cc01d6f9bc117ca86886a803ed34cac)
-
Daniel Kayiwa 5e9af8a2819987d4c75a774d6c3159cbd70dce08
Merge pull request #1847 from teleivo/TRUNK-4936
TRUNK-4936 Add precondition for addcolumn changeset -
teleivo <mrteleivo@gmail.com> b3ea04004e7d9ec688605f15ea4abdfbae5b51c2
TRUNK-4936 Add precondition for addcolumn changeset
Only add new column uniqueId if it doesnt already exist in table
concept_reference_source- api/src/main/resources/liquibase-update-to-latest.xml (version b3ea04004e7d9ec688605f15ea4abdfbae5b51c2)
-
Daniel Kayiwa e1c3f7896e91a34c3130b45d6d03d5cb9aa92f82
Merge pull request #1846 from teleivo/TRUNK-4936
TRUNK-4936 Add ConceptSource.uniqueId -
teleivo <mrteleivo@gmail.com> 4b9ca17a19a6d1486384333ab978365e7465bfc8
TRUNK-4936 Add ConceptSource.uniqueId
* add ConceptSource.uniqueId
* add property to hibernate mapping file ConceptSource.hbm.xml
* ensure ConceptSourceValidator validates max conceptId length
* add liquibase changeset adding the column concept_source.unique_id
with unique constraint (but defaults to null)
* add service method to ConceptService with implementation in
ConceptServiceImpl
* add ConceptDAO method with HibernateDAO implementation
* add tests for the service layer
* add the official registered OID of "SNOMED CT" into its unique_id
column in the standardTestDataset.xml so it can be used in tests- api/src/main/java/org/openmrs/ConceptSource.java (version 4b9ca17a19a6d1486384333ab978365e7465bfc8)
- api/src/main/java/org/openmrs/api/ConceptService.java (version 4b9ca17a19a6d1486384333ab978365e7465bfc8)
- api/src/main/java/org/openmrs/api/db/ConceptDAO.java (version 4b9ca17a19a6d1486384333ab978365e7465bfc8)
- api/src/main/java/org/openmrs/api/db/hibernate/HibernateConceptDAO.java (version 4b9ca17a19a6d1486384333ab978365e7465bfc8)
- api/src/main/java/org/openmrs/api/impl/ConceptServiceImpl.java (version 4b9ca17a19a6d1486384333ab978365e7465bfc8)
- api/src/main/java/org/openmrs/validator/ConceptSourceValidator.java (version 4b9ca17a19a6d1486384333ab978365e7465bfc8)
- api/src/main/resources/liquibase-update-to-latest.xml (version 4b9ca17a19a6d1486384333ab978365e7465bfc8)
- api/src/main/resources/org/openmrs/api/db/hibernate/ConceptSource.hbm.xml (version 4b9ca17a19a6d1486384333ab978365e7465bfc8)
- api/src/test/java/org/openmrs/api/ConceptServiceTest.java (version 4b9ca17a19a6d1486384333ab978365e7465bfc8)
- api/src/test/java/org/openmrs/validator/ConceptSourceValidatorTest.java (version 4b9ca17a19a6d1486384333ab978365e7465bfc8)
- api/src/test/resources/org/openmrs/include/standardTestDataset.xml (version 4b9ca17a19a6d1486384333ab978365e7465bfc8)