Build #1,250

Plan branch:
Sonar metrics for OpenMRS Core Master

Build: #1250 was successful

Job: Sonar Full Analysis was successful

Stages & jobs

  1. Sonar Analysis

Code commits

Git

  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> 8c88e1e0e2018ffa5a78b06d8a9eb511d8da7371

    Merge pull request #2193 from teleivo/TRUNK-5167
    TRUNK-5167 PersonEditor does not throw if Person not found

  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> 68755f31a1f50df79fad31409a085fe31da00078

    Merge pull request #2191 from teleivo/TRUNK-5166
    TRUNK-5166 ConceptReferenceTermEditorTest does not get object via uuid

  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> 98c55a7a2cfb2c3c174184b86bc6f9ce6c226193

    Merge pull request #2192 from teleivo/TRUNK-5165
    TRUNK-5165 ConceptMapTypeEditor does not get object via uuid

  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> a648272062ee1d3ab75f20049216979653e542c4

    TRUNK-5167 PersonEditor does not throw if Person not found
    PersonEditor does not throw an IllegalArgumentException if Person
    is not found given text which is different than ~30 PropertyEditors for OpenmrsObjects

    • api/src/main/java/org/openmrs/propertyeditor/PersonEditor.java (version a648272062ee1d3ab75f20049216979653e542c4)
    • api/src/test/java/org/openmrs/propertyeditor/PersonEditorTest.java (version a648272062ee1d3ab75f20049216979653e542c4)
  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> c136144c7fbfb143012116bc2cb6fb6b84f0ca3c

    TRUNK-5165 ConceptMapTypeEditor does not get object via uuid
    ConceptMapTypeEditor does not try getting the object via uuid after it failed
    to get it via its id although the service provides the method.
    This is usually done (>30 editors for OpenmrsObjects).

    • api/src/main/java/org/openmrs/propertyeditor/ConceptMapTypeEditor.java (version c136144c7fbfb143012116bc2cb6fb6b84f0ca3c)
    • api/src/test/java/org/openmrs/propertyeditor/ConceptMapTypeEditorTest.java (version c136144c7fbfb143012116bc2cb6fb6b84f0ca3c)
  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> 834d9dec88773e41a4a723bb4a0b1a3606e2e8a9

    TRUNK-5166 ConceptReferenceTermEditorTest does not get object via uuid
    ConceptMapTypeEditor does not try getting the object via uuid after it failed to get it via its id
    although the service provides the method. This is usually done (>30 editors for OpenmrsObjects).

    • api/src/main/java/org/openmrs/propertyeditor/ConceptReferenceTermEditor.java (version 834d9dec88773e41a4a723bb4a0b1a3606e2e8a9)
    • api/src/test/java/org/openmrs/propertyeditor/ConceptReferenceTermEditorTest.java (version 834d9dec88773e41a4a723bb4a0b1a3606e2e8a9)
  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> de422c21dcb86298caf174f73199fc7123430676

    Merge pull request #2190 from teleivo/TRUNK-5164
    TRUNK-5164 Add abstract OpenmrsPropertyEditor

  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> a1ae660023bb40ffe56cebb6791be5528a39fec7

    TRUNK-5164 Add abstract OpenmrsPropertyEditor
    Add abstract OpenmrsPropertyEditor for OpenmrsObject's
    which tries to get an object via its id and if that fails via its uuid

    Let

    CohortEditor.java
    ConceptAnswerEditor.java
    ConceptAttributeTypeEditor.java
    ConceptClassEditor.java
    ConceptDatatypeEditor.java
    ConceptEditor.java
    ConceptNameEditor.java
    ConceptNumericEditor.java
    ConceptSourceEditor.java
    DrugEditor.java
    EncounterEditor.java
    EncounterTypeEditor.java
    FormEditor.java
    LocationAttributeTypeEditor.java
    LocationEditor.java
    LocationTagEditor.java
    OpenmrsPropertyEditor.java
    OrderEditor.java
    PatientEditor.java
    PatientIdentifierTypeEditor.java
    PersonAttributeEditor.java
    PersonAttributeTypeEditor.java
    ProgramWorkflowEditor.java
    ProgramWorkflowStateEditor.java
    UserEditor.java
    VisitEditor.java
    VisitTypeEditor.java

    extend OpenmrsPropertyEditor.

    The current behavior is not changed as shown by existing tests which
    were not changed.

    • api/src/main/java/org/openmrs/propertyeditor/CohortEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/ConceptAnswerEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/ConceptAttributeTypeEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/ConceptClassEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/ConceptDatatypeEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/ConceptEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/ConceptNameEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/ConceptNumericEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/ConceptSourceEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/DrugEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/EncounterEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/EncounterTypeEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/FormEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/LocationAttributeTypeEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/LocationEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/LocationTagEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/OpenmrsPropertyEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/OrderEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/PatientEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/PatientIdentifierTypeEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/PersonAttributeEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/PersonAttributeTypeEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/ProgramWorkflowEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/ProgramWorkflowStateEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/UserEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/VisitEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
    • api/src/main/java/org/openmrs/propertyeditor/VisitTypeEditor.java (version a1ae660023bb40ffe56cebb6791be5528a39fec7)
  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> 455e45234790a876299a1fefb79acd937559fb17

    Merge pull request #2189 from teleivo/TRUNK-5162
    TRUNK-5162 Few PropertyEditor getAsText return null if value is null

  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> af1722d946b9a2dae3134ece062fabaf2a305218

    Merge pull request #2188 from teleivo/TRUNK-5163
    TRUNK-5163 Disable logs during tests

  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> fbdce639b8e4bf8ca15ec151959cdd79f0918ba7

    TRUNK-5162 Few PropertyEditor getAsText return null if value is null
    ConceptAttributeTypeEditor.java
    LocationAttributeTypeEditor.java
    LocationEditor.java
    LocationTagEditor.java

    which where the only ones returning null, in ~37 PropertyEditors

    • api/src/main/java/org/openmrs/propertyeditor/ConceptAttributeTypeEditor.java (version fbdce639b8e4bf8ca15ec151959cdd79f0918ba7)
    • api/src/main/java/org/openmrs/propertyeditor/LocationAttributeTypeEditor.java (version fbdce639b8e4bf8ca15ec151959cdd79f0918ba7)
    • api/src/main/java/org/openmrs/propertyeditor/LocationEditor.java (version fbdce639b8e4bf8ca15ec151959cdd79f0918ba7)
    • api/src/main/java/org/openmrs/propertyeditor/LocationTagEditor.java (version fbdce639b8e4bf8ca15ec151959cdd79f0918ba7)
    • api/src/test/java/org/openmrs/propertyeditor/ConceptAttributeTypeEditorTest.java (version fbdce639b8e4bf8ca15ec151959cdd79f0918ba7)
    • api/src/test/java/org/openmrs/propertyeditor/LocationAttributeTypeEditorTest.java (version fbdce639b8e4bf8ca15ec151959cdd79f0918ba7)
    • api/src/test/java/org/openmrs/propertyeditor/LocationEditorTest.java (version fbdce639b8e4bf8ca15ec151959cdd79f0918ba7)
    • api/src/test/java/org/openmrs/propertyeditor/LocationTagEditorTest.java (version fbdce639b8e4bf8ca15ec151959cdd79f0918ba7)
  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> 4fc4d6f0e0a97ee187274501af1f7ca2afa798fa

    TRUNK-5163 Disable logs during tests

    • api/src/test/resources/log4j.xml (version 4fc4d6f0e0a97ee187274501af1f7ca2afa798fa)
  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> 724be5f9b6b5e362da5e034f15707f944dc72c3d

    Merge pull request #2187 from teleivo/TRUNK-5139
    TRUNK-5139 Adapt test of ProviderEditor

  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> 1c3542d361899b5fe5bb63b7f59b67ac58843799

    TRUNK-5139 Adapt test of ProviderEditor
    * ignore test for when trying to get a Provider of non existing ID
    since this is an issue TRUNK-5153

    • api/src/test/java/org/openmrs/propertyeditor/ProviderEditorTest.java (version 1c3542d361899b5fe5bb63b7f59b67ac58843799)
  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> 4f9b513a8f73c86a37af9322666e10a932fd9257

    Merge pull request #2186 from jsmitha9/rTRUNK-5043
    TRUNK-5043

  • Justin Smith <justinsmith00@bears.upike.edu>

    Justin Smith <justinsmith00@bears.upike.edu> a6f51abfb616e4e672192901b65b31817b4dc60b

    TRUNK-5043
    Remove unused temp variables, shown to us by sonar. One was removed and
    the other was used in an if statement, therefore was in use.

    • api/src/main/java/org/openmrs/hl7/handler/ORUR01Handler.java (version a6f51abfb616e4e672192901b65b31817b4dc60b)