Build #2,274

Plan branch:
OpenMRS Core Master

Build: #2274 was successful Changes by teleivo <teleivo@users.noreply.github.com>

Stages & jobs

  1. Build and Test

  2. Deploy

  3. Release

    Requires a user to start manually

Build result summary

Details

Completed
Queue duration
1 second
Duration
17 minutes
Labels
None
Revisions
openmrs-core
68f17d66bdf2849978e09d69a0570b88b69f0c9d 68f17d66bdf2849978e09d69a0570b88b69f0c9d
openmrs-standalone
8af748fdb6fe93f74ebb4b89e03b262fcd37b5c0 8af748fdb6fe93f74ebb4b89e03b262fcd37b5c0
Release scripts
1969d1c2650fc66ab14f5edb4052a329a196f370 1969d1c2650fc66ab14f5edb4052a329a196f370
Total tests
4406
Successful since
#2258 ()

Tests

Included in deployment project

Deploy Trunk Nightly

No release with the artifacts of this build exists.
The next release containing these commits is release openmrs-trunk-2277 created from build #2277

Code commits

openmrs-core
Author Commit Message Commit date
teleivo <teleivo@users.noreply.github.com> teleivo <teleivo@users.noreply.github.com> 68f17d66bdf2849978e09d69a0570b88b69f0c9d 68f17d66bdf2849978e09d69a0570b88b69f0c9d TRUNK-5816 Use MockitoExtension
Extensions are the Junit 5 way of extending its capabilities.
MockitoExtension is setup strict by default which is very useful in that
it shows us unnecessary stubs like

org.mockito.exceptions.misusing.UnnecessaryStubbingException:
Unnecessary stubbings detected.
Clean & maintainable test code requires zero unnecessary code.
Following stubbings are unnecessary (click to navigate to relevant line of code):
  1. -> at org.openmrs.api.impl.PatientServiceImplTest.checkPatientIdentifiers_shouldThrowDuplicateIdentifierGivenDuplicateIdentifiers(PatientServiceImplTest.java:165)
Please remove unnecessary stubbings or use 'lenient' strictness. More info: javadoc for UnnecessaryStubbingException class.

this helps us clean up our tests that have had mocks added over time but
not removed once not needed anymore.

MockitoExtension also allows us to inject mocks in constructor/test
methods

Note that we did setup the mocked
userContext.getAuthenticatedUser() in the ContextHelper as lenient so
that this mock that all

BaseContextSensitiveTest
BaseContextMockTest
BaseContextMockJunit5Test

get does not cause such errors if not used

Configuration changes

Some of the jobs or stages referenced by this result no longer exist.

Manual stage Release cannot be run as it references jobs that no longer exist.

Jira issues

IssueDescriptionStatus
Unknown Issue TypeTRUNK-5816Could not obtain issue details from Jira