Build #2,295

Plan branch:
OpenMRS Core Master

Build: #2295 was successful Changes by teleivo <teleivo@users.noreply.github.com>

Stages & jobs

  1. Build and Test

  2. Deploy

  3. Release

    Requires a user to start manually

Code commits

openmrs-core

  • teleivo <teleivo@users.noreply.github.com>

    teleivo <teleivo@users.noreply.github.com> 99a8057e52a899169d2a731111217eea11cff5a7

    Use assertThrows instead of try/catch in tests
    this idiom seems to stem from the JUnit 3 times
    https://github.com/junit-team/junit4/wiki/Exception-testing#trycatch-idiom
    now with JUnit 4/5 the preferred approach is assertThrows
    https://github.com/junit-team/junit4/wiki/Exception-testing#using-assertthrows-method

    • api/src/test/java/org/openmrs/ObsTest.java (version 99a8057e52a899169d2a731111217eea11cff5a7)
    • api/src/test/java/org/openmrs/api/AdministrationServiceTest.java (version 99a8057e52a899169d2a731111217eea11cff5a7)
    • api/src/test/java/org/openmrs/api/CohortServiceTest.java (version 99a8057e52a899169d2a731111217eea11cff5a7)
    • api/src/test/java/org/openmrs/attribute/AttributeIntegrationTest.java (version 99a8057e52a899169d2a731111217eea11cff5a7)
    • api/src/test/java/org/openmrs/patient/impl/LuhnIdentifierValidatorTest.java (version 99a8057e52a899169d2a731111217eea11cff5a7)
    • api/src/test/java/org/openmrs/patient/impl/VerhoeffIdentifierValidatorTest.java (version 99a8057e52a899169d2a731111217eea11cff5a7)
    • api/src/test/java/org/openmrs/validator/PatientIdentifierValidatorTest.java (version 99a8057e52a899169d2a731111217eea11cff5a7)
  • teleivo <teleivo@users.noreply.github.com>

    teleivo <teleivo@users.noreply.github.com> da4854a7a671d3add241e87787e4563953c3396e

    Use assertFalse instead of assertEquals(true, expression)
    since assertTrue/assertFalse are specifically written for these assertions

    • api/src/test/java/org/openmrs/ConceptTest.java (version da4854a7a671d3add241e87787e4563953c3396e)
    • api/src/test/java/org/openmrs/ObsTest.java (version da4854a7a671d3add241e87787e4563953c3396e)
    • api/src/test/java/org/openmrs/api/ConceptServiceTest.java (version da4854a7a671d3add241e87787e4563953c3396e)
    • api/src/test/java/org/openmrs/api/PatientServiceTest.java (version da4854a7a671d3add241e87787e4563953c3396e)
    • api/src/test/java/org/openmrs/api/db/hibernate/DropMillisecondsHibernateInterceptorTest.java (version da4854a7a671d3add241e87787e4563953c3396e)
    • api/src/test/java/org/openmrs/hl7/handler/ORUR01HandlerTest.java (version da4854a7a671d3add241e87787e4563953c3396e)
    • api/src/test/java/org/openmrs/validator/ConceptMapTypeValidatorTest.java (version da4854a7a671d3add241e87787e4563953c3396e)
    • api/src/test/java/org/openmrs/validator/ConceptNameTagValidatorTest.java (version da4854a7a671d3add241e87787e4563953c3396e)
    • api/src/test/java/org/openmrs/validator/ConceptReferenceTermValidatorTest.java (version da4854a7a671d3add241e87787e4563953c3396e)
    • api/src/test/java/org/openmrs/validator/ConceptValidatorTest.java (version da4854a7a671d3add241e87787e4563953c3396e)
    • api/src/test/java/org/openmrs/validator/PatientProgramValidatorTest.java (version da4854a7a671d3add241e87787e4563953c3396e)
    • api/src/test/java/org/openmrs/validator/PersonAddressValidatorTest.java (version da4854a7a671d3add241e87787e4563953c3396e)
    • api/src/test/java/org/openmrs/validator/VisitValidatorTest.java (version da4854a7a671d3add241e87787e4563953c3396e)