Plan for OpenMRS Core 1.11.x

Build: #270 failed Changes by Rafal Korytkowski

Stages & jobs

  1. Build and Test

  2. Deploy

  3. Release

    Requires a user to start manually

Build result summary

Details

Completed
Queue duration
4 seconds
Duration
8 minutes
Labels
None
Revisions
Git
7b59e1e07ba02e5353d58fae0fedb62cc95af145 7b59e1e07ba02e5353d58fae0fedb62cc95af145
Release scripts
a9c6b4741f415820e397e9b150cf80baca7f9368 a9c6b4741f415820e397e9b150cf80baca7f9368
Total tests
3039
Fixed in
#271 (Changes by Rafal Korytkowski)

Tests

Responsible

Code commits

Git
Author Commit Message Commit date
Rafal Korytkowski Rafal Korytkowski 7b59e1e07ba02e5353d58fae0fedb62cc95af145 7b59e1e07ba02e5353d58fae0fedb62cc95af145 TRUNK-4771 Authorization checks are slow when running as Daemon
(cherry picked from commit 3b62f48ccf8b3c9fe7a175bb4044babfc60f3534)

Conflicts:
        api/src/main/java/org/openmrs/aop/AuthorizationAdvice.java
Rafal Korytkowski Rafal Korytkowski 1c48646495cf9abab6108a253db32f812e8ebffe 1c48646495cf9abab6108a253db32f812e8ebffe Speed ups:
Rafal Korytkowski Rafal Korytkowski ad3a47a4fc67cd924a12f293baa755d49cf8f57e ad3a47a4fc67cd924a12f293baa755d49cf8f57e TRUNK-4758 Enable Hibernate second level cache
(cherry picked from commit 623e03d3bf8ce6e4fd3462abda56ac5c293636fd)

Conflicts:
        api/src/main/java/org/openmrs/api/db/AdministrationDAO.java
        api/src/main/resources/hibernate.default.properties
        api/src/main/resources/org/openmrs/api/db/hibernate/GlobalProperty.hbm.xml
        api/src/main/resources/org/openmrs/api/db/hibernate/Person.hbm.xml
        api/src/main/resources/org/openmrs/api/db/hibernate/PersonAddress.hbm.xml
        api/src/main/resources/org/openmrs/api/db/hibernate/PersonAttribute.hbm.xml
        api/src/main/resources/org/openmrs/api/db/hibernate/PersonName.hbm.xml
        api/src/main/resources/org/openmrs/api/db/hibernate/Role.hbm.xml

Tests

New test failures 4
Status Test View job Duration
Collapse Failed AuthorizationAdviceTest before_shouldNotifyListenersAboutCheckedPrivileges History
Build and Test < 1 sec
java.lang.AssertionError: listener1 Expected: iterable over ["Manage Concepts", "Get Observations"] in any order      but: No item matches: "Get Observations" in ["Manage Concepts"]
java.lang.AssertionError: listener1
Expected: iterable over ["Manage Concepts", "Get Observations"] in any order
     but: No item matches: "Get Observations" in ["Manage Concepts"]
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:865)
	at org.openmrs.aop.AuthorizationAdviceTest.before_shouldNotifyListenersAboutCheckedPrivileges(AuthorizationAdviceTest.java:66)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
(34 more lines...)
Collapse Failed ConceptServiceTest saveConcept_shouldKeepIdForNewConceptIfOneIsSpecified History
Build and Test < 1 sec
java.lang.NullPointerException
	at org.openmrs.api.impl.ConceptServiceImpl.hasDatatypeChanged(ConceptServiceImpl.java:1475)
	at org.openmrs.api.impl.ConceptServiceImpl.checkIfDatatypeCanBeChanged(ConceptServiceImpl.java:1454)
	at org.openmrs.api.impl.ConceptServiceImpl.saveConcept(ConceptServiceImpl.java:179)
	at sun.reflect.GeneratedMethodAccessor897.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
(60 more lines...)
Collapse Failed ConceptServiceImplTest saveConcept_shouldReturnTheConceptWithSameConceptIDIfUpdatingExistingConcept History
Build and Test < 1 sec
java.lang.NullPointerException
	at org.openmrs.api.impl.ConceptServiceImpl.hasDatatypeChanged(ConceptServiceImpl.java:1475)
	at org.openmrs.api.impl.ConceptServiceImpl.checkIfDatatypeCanBeChanged(ConceptServiceImpl.java:1454)
	at org.openmrs.api.impl.ConceptServiceImpl.saveConcept(ConceptServiceImpl.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
(60 more lines...)
Collapse Failed ConceptServiceImplTest saveConcept_shouldSetDefaultPreferredNameToFullySpecifiedFirst History
Build and Test < 1 sec
java.lang.NullPointerException
	at org.openmrs.api.impl.ConceptServiceImpl.hasDatatypeChanged(ConceptServiceImpl.java:1475)
	at org.openmrs.api.impl.ConceptServiceImpl.checkIfDatatypeCanBeChanged(ConceptServiceImpl.java:1454)
	at org.openmrs.api.impl.ConceptServiceImpl.saveConcept(ConceptServiceImpl.java:179)
	at sun.reflect.GeneratedMethodAccessor897.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
(58 more lines...)

Jira issues

IssueDescriptionStatus
Unknown Issue TypeTRUNK-4758Could not obtain issue details from Jira
Unknown Issue TypeTRUNK-4771Could not obtain issue details from Jira