Build: #356 failed Changes by Wyclif Luyima

Stages & jobs

  1. Build and Tests

Build result summary

Details

Completed
Queue duration
3 seconds
Duration
14 minutes
Labels
None
Revision
0e07d05cc1524432e02dcf97c0c758c600afdc80 0e07d05cc1524432e02dcf97c0c758c600afdc80
Total tests
5164
Fixed in
#358 (Changes by Wyclif Luyima)

Tests

Responsible

Code commits

Author Commit Message Commit date
Wyclif Luyima Wyclif Luyima 0e07d05cc1524432e02dcf97c0c758c600afdc80 0e07d05cc1524432e02dcf97c0c758c600afdc80 TRUNK-4445 Added support for custom dosing type for DrugOrders. Changed the current dosing type enum to a string, while keeping the support for SIMPLE and FREE_TEXT dosing types using constants
TRUNK-4445 Made doing type of type class <? extends dosinginstructions>

TRUNK-4445 Adding validation to the the dosing instructions class, and removing them from drugordervalidator

TRUNK-4445 changing the shoulds and verifies in the required places, renamed dosinginstructionsobject to dosinginstructionsinstance. Catching exceptions inside the getter now. Updated the message.properties with suitable messages for dosingIntructions Free Text

Adding java doc for DosingInstructions and removing unused import

Follow up to clean up unit tests and the liquibase update file   - TRUNK-4445

Conflicts:
        api/src/main/resources/liquibase-update-to-latest.xml
        api/src/test/resources/org/openmrs/include/standardTestDataset.xml

Tests

New test failures 1
Status Test View job Duration
Collapse Failed ExistingVisitAssignmentHandlerTest beforeCreateEncounter_shouldNotAssignVisitWhichStoppedBeforeEncounterDate History
Unit and Component Tests < 1 sec
java.lang.NullPointerException
	at org.openmrs.api.handler.OpenmrsObjectSaveHandler.handle(OpenmrsObjectSaveHandler.java:82)
	at org.openmrs.aop.RequiredDataAdvice.recursivelyHandle(RequiredDataAdvice.java:270)
	at org.openmrs.aop.RequiredDataAdvice.recursivelyHandle(RequiredDataAdvice.java:234)
	at org.openmrs.aop.RequiredDataAdvice.before(RequiredDataAdvice.java:139)
	at org.springframework.aop.framework.adapter.MethodBeforeAdviceInterceptor.invoke(MethodBeforeAdviceInterceptor.java:49)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
	at org.springframework.aop.framework.adapter.MethodBeforeAdviceInterceptor.invoke(MethodBeforeAdviceInterceptor.java:50)
(39 more lines...)

Jira issues

IssueDescriptionStatus
Unknown Issue TypeTRUNK-4445Could not obtain issue details from Jira