Build: #363 failed Changes by Wyclif Luyima

Stages & jobs

  1. Build and Tests

Build result summary

Details

Completed
Queue duration
2 seconds
Duration
13 minutes
Labels
None
Revision
36cf42d698d28856623b1bbbc5315c966a12d452 36cf42d698d28856623b1bbbc5315c966a12d452
Total tests
5252
Fixed in
#364 (Manual run by Wyclif Luyima)

Tests

Responsible

Code commits

Author Commit Message Commit date
Wyclif Luyima Wyclif Luyima 36cf42d698d28856623b1bbbc5315c966a12d452 36cf42d698d28856623b1bbbc5315c966a12d452 Support deriving auto_expire_date from duration and duration units for Drug Orders - TRUNK-4446
TRUNK-4446: Infer drug order auto expire date based on duration and frequency

TRUNK-4446: Use uuid for comparision. Improved javadoc for ISO8601Duration

TRUNK-4446: Changes based on PR comments

* Remove unused constants in map type
* Use uuid of concept source
* Exception when duration code is unknown
* Exception when frequency not provide for recurring interval
* Fix uuid, dates in change set.
* New change set for alter column
* Check for duration and units before infering expire date
* Use getEffectiveStartDate to handle scheduled order

TRUNK-4446: Add preconditions for inserting concept source and reference terms

TRUNK-4446: Move migrations from liquibase-core-data.xml to liquibase-update-to-latest.xml

TRUNK-4446: Validate duration units is mapped to ISO 8601 duration when auto expire date is not set

Follow up to remove concept map uuid restriction and moved logic that checks for durations mappings to DrugOrderValidator - TRUNK-4446

Follow up to fix failing tests - TRUNK-4446

Conflicts:
        api/src/main/resources/liquibase-update-to-latest.xml

Tests

New test failures 1
Status Test View job Duration
Collapse Failed ExistingVisitAssignmentHandlerTest beforeCreateEncounter_shouldNotAssignVisitWhichStoppedBeforeEncounterDate History
Integration Tests < 1 sec
java.lang.NullPointerException
	at org.openmrs.api.handler.OpenmrsObjectSaveHandler.handle(OpenmrsObjectSaveHandler.java:82)
	at org.openmrs.aop.RequiredDataAdvice.recursivelyHandle(RequiredDataAdvice.java:270)
	at org.openmrs.aop.RequiredDataAdvice.recursivelyHandle(RequiredDataAdvice.java:234)
	at org.openmrs.aop.RequiredDataAdvice.before(RequiredDataAdvice.java:139)
	at org.springframework.aop.framework.adapter.MethodBeforeAdviceInterceptor.invoke(MethodBeforeAdviceInterceptor.java:49)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
	at org.springframework.aop.framework.adapter.MethodBeforeAdviceInterceptor.invoke(MethodBeforeAdviceInterceptor.java:50)
(39 more lines...)

Jira issues

IssueDescriptionStatus
Unknown Issue TypeTRUNK-4446Could not obtain issue details from Jira