Build: #1161 was successful Scheduled with changes by teleivo <mrteleivo@gmail.com> and Daniel Kayiwa

Build result summary

Details

Completed
Queue duration
1 minute
Duration
1 minute
Labels
None
Revision
571f3080b3d870dd7c1d3a00a01aab1fd3fe2295 571f3080b3d870dd7c1d3a00a01aab1fd3fe2295
Successful since
#784 ()

Code commits

Author Commit Message Commit date
Daniel Kayiwa Daniel Kayiwa 571f3080b3d870dd7c1d3a00a01aab1fd3fe2295 571f3080b3d870dd7c1d3a00a01aab1fd3fe2295 Merge pull request #2069 from teleivo/TRUNK-5114
TRUNK-5114 Using different logging implementations instead of facade
teleivo <mrteleivo@gmail.com> teleivo <mrteleivo@gmail.com> d43ce19c062232b9aa3065d4b7e5a4804db18c3c d43ce19c062232b9aa3065d4b7e5a4804db18c3c TRUNK-5114 Using different logging implementations instead of facade
we exclude the apache commons-logging dependency coming from springframework
and configure the slf4j facade with the log4j implementation but still
use commons-logging or log4j directly.

* replace usages by using the slf4j facade
* add "org.apache.commons.logging" to checkstyle's IllegalImport rule
so we get notified of anyone trying to use it
* replace log.fatal("message", exception)

with

log.error(MarkerFactory.getMarker("FATAL"), "message", e);

since slf4j does not provide the level FATAL and suggests the use of
markers instead

Jira issues

IssueDescriptionStatus
Unknown Issue TypeTRUNK-5114Could not obtain issue details from Jira