Stages & jobs

  1. Default Stage

  2. Release

    Requires a user to start manually

Build result summary

Details

Completed
Queue duration
1 second
Duration
2 minutes
Labels
None
Revisions
Git
f919efbbd8f6940a86659fe594216857f615aae6 f919efbbd8f6940a86659fe594216857f615aae6
Release scripts
a72ca16daff268573032d8bd52a15be883f08322 a72ca16daff268573032d8bd52a15be883f08322
Total tests
406
Successful since
#305 ()

Tests

  • 0 New failures
  • 0 Existing failures
  • 0 Fixed

Code commits

Git
Author Commit Message Commit date
Ivo Ulrich <teleivo@users.noreply.github.com> Ivo Ulrich <teleivo@users.noreply.github.com> f919efbbd8f6940a86659fe594216857f615aae6 f919efbbd8f6940a86659fe594216857f615aae6 Merge pull request #412 from teleivo/RAD-303
RAD-303 Rethink exceptions of API
teleivo <mrteleivo@gmail.com> teleivo <mrteleivo@gmail.com> 42199881d858a646c1afd092b48622063bbfb0fb 42199881d858a646c1afd092b48622063bbfb0fb RAD-303 Rethink exceptions of API
throw openmrs APIException in service methods for cases violating business rules, and IllegalArgumentException for cases that are programming errors.
APIExceptions are thrown using message codes from the message properties files, so the client code can catch those and display the error message to the user.

* RadiologyStudyService.saveRadiologyStudy() does not allow saving existing
* use throw APIException in RadiologyOrderServie.placeRadiologyOrder() and
discontinueRadiologyOrder()
* catch APIException in RadiologyOrderFormController.saveRadiologyOrder()
* reduce code in catch block in
RadiologyOrderFormController.saveRadiologyOrder() only to the service call
* return in save/discontinueRadiologyOrder in controller after redirect since
model objects in model and view will not be used.

Jira issues

IssueDescriptionStatus
Unknown Issue TypeRAD-303Could not obtain issue details from Jira