Build #344

Plan branch:

Stages & jobs

  1. Default Stage

  2. Release

    Requires a user to start manually

Code commits

Git

  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> 246580e78ecdd925d90d6790ae82059250e03d3c

    Merge pull request #427 from teleivo/RAD-354
    RAD-354 Overhaul ReportService

  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> 239fab8ea59295812522c4a73d489ef563d53df7

    RAD-354 Overhaul ReportService
    * rename createAndClaimRadiologyReport to createRadiologyReport (in service and
    controller)
    * rename saveRadiologyReport to saveRadiologyReportDraft
    * prevent saveRadiologyReportDraft if radiologyReport.reportId is null
    * prevent saveRadiologyReportDraft if order already has a completed report
    * harmonize tests and javadoc of Service methods
    * make createRadiologyReport/saveDraft/complete synchronized
    * add class javadoc to RadiologyReportService
    * make tests cleaner
    * throw APIExceptions using message property codes in RadiologyReportService
    * catch APIExceptions in controller
    * set session attribute on success/err in controller

    • api/src/main/java/org/openmrs/module/radiology/report/HibernateRadiologyReportDAO.java (version 239fab8ea59295812522c4a73d489ef563d53df7)
    • api/src/main/java/org/openmrs/module/radiology/report/RadiologyReportDAO.java (version 239fab8ea59295812522c4a73d489ef563d53df7)
    • api/src/main/java/org/openmrs/module/radiology/report/RadiologyReportService.java (version 239fab8ea59295812522c4a73d489ef563d53df7)
    • api/src/main/java/org/openmrs/module/radiology/report/RadiologyReportServiceImpl.java (version 239fab8ea59295812522c4a73d489ef563d53df7)
    • api/src/test/java/org/openmrs/module/radiology/report/RadiologyReportServiceComponentTest.java (version 239fab8ea59295812522c4a73d489ef563d53df7)
    • omod/src/main/java/org/openmrs/module/radiology/report/web/RadiologyReportFormController.java (version 239fab8ea59295812522c4a73d489ef563d53df7)
    • omod/src/main/resources/messages.properties (version 239fab8ea59295812522c4a73d489ef563d53df7)
    • omod/src/main/webapp/reports/radiologyReportForm.jsp (version 239fab8ea59295812522c4a73d489ef563d53df7)
    • omod/src/test/java/org/openmrs/module/radiology/report/web/RadiologyReportFormControllerTest.java (version 239fab8ea59295812522c4a73d489ef563d53df7)