Build #394

Plan branch:

Stages & jobs

  1. Default Stage

  2. Release

    Requires a user to start manually

Code commits

Git

  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> fbb7f49f49c3e180c73831204ac3ab2de1657ac3

    Merge pull request #478 from teleivo/RAD-359-engine
    RAD-359 Improve validation error messages on mrrt import

  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> 5390c87a977ee70f48bb1cba529e57d69393bcb5

    RAD-359 Improve validation error messages on mrrt import
    use a Production Rule System style approach to validate the mrrt meta
    tag rules which are checked using jsoup in the
    XsdMrrtReportTemplateValidator

    * add validation engine interface which runs validation on given type
    and returns a ValidationResult containing the ValidationError's
    * add MetaTagsValidationEngine containing the ValidationRule's which
    are checked when run
    * add ValidationRule interface with ElementsExpressionValidationRule
    impl which selects elements via jsoup and tests the condition Predicate
    * catch MrrtReportTemplateValidationException in the
    RadiologyDashboardReportTemplatesTabController and add the violations
    into the model and view for display
    * show violations in an <ul> to the user

    • api/src/main/java/org/openmrs/module/radiology/report/template/ElementsExpressionValidationRule.java (version 5390c87a977ee70f48bb1cba529e57d69393bcb5)
    • api/src/main/java/org/openmrs/module/radiology/report/template/MetaTagsValidationEngine.java (version 5390c87a977ee70f48bb1cba529e57d69393bcb5)
    • api/src/main/java/org/openmrs/module/radiology/report/template/MrrtReportTemplateValidationException.java (version 5390c87a977ee70f48bb1cba529e57d69393bcb5)
    • api/src/main/java/org/openmrs/module/radiology/report/template/ValidationEngine.java (version 5390c87a977ee70f48bb1cba529e57d69393bcb5)
    • api/src/main/java/org/openmrs/module/radiology/report/template/ValidationError.java (version 5390c87a977ee70f48bb1cba529e57d69393bcb5)
    • api/src/main/java/org/openmrs/module/radiology/report/template/ValidationResult.java (version 5390c87a977ee70f48bb1cba529e57d69393bcb5)
    • api/src/main/java/org/openmrs/module/radiology/report/template/ValidationRule.java (version 5390c87a977ee70f48bb1cba529e57d69393bcb5)
    • api/src/main/java/org/openmrs/module/radiology/report/template/XsdMrrtReportTemplateValidator.java (version 5390c87a977ee70f48bb1cba529e57d69393bcb5)
    • api/src/main/resources/moduleApplicationContext.xml (version 5390c87a977ee70f48bb1cba529e57d69393bcb5)
    • api/src/test/java/org/openmrs/module/radiology/report/template/MetaTagsValidationEngineTest.java (version 5390c87a977ee70f48bb1cba529e57d69393bcb5)
    • api/src/test/java/org/openmrs/module/radiology/report/template/MrrtReportTemplateValidatorTest.java (version 5390c87a977ee70f48bb1cba529e57d69393bcb5)
    • api/src/test/java/org/openmrs/module/radiology/report/template/ValidationResultTest.java (version 5390c87a977ee70f48bb1cba529e57d69393bcb5)
    • omod/src/main/java/org/openmrs/module/radiology/report/template/web/RadiologyDashboardReportTemplatesTabController.java (version 5390c87a977ee70f48bb1cba529e57d69393bcb5)
    • omod/src/main/resources/messages.properties (version 5390c87a977ee70f48bb1cba529e57d69393bcb5)
    • omod/src/main/webapp/radiologyDashboardReportTemplatesTab.jsp (version 5390c87a977ee70f48bb1cba529e57d69393bcb5)
    • omod/src/test/java/org/openmrs/module/radiology/report/template/web/RadiologyDashboardReportTemplatesTabControllerTest.java (version 5390c87a977ee70f48bb1cba529e57d69393bcb5)