More details of the release in https://wiki.openmrs.org/x/i4DTAw

Build: #241 failed Changes by Michael Seaton <mseaton@pih.org>

Build result summary

Details

Completed
Duration
3 minutes
Labels
None
Revision
20b710d2217f13129c84767c05566194aacca6b2 20b710d2217f13129c84767c05566194aacca6b2
Total tests
503
Fixed in
#242 (Changes by Michael Seaton <mseaton@pih.org>)

Tests

Code commits

Author Commit Message Commit date
Michael Seaton <mseaton@pih.org> Michael Seaton <mseaton@pih.org> 20b710d2217f13129c84767c05566194aacca6b2 20b710d2217f13129c84767c05566194aacca6b2 REPORT-253: Localize Date parameters when rendering reports
Commit includes:
* Some clean up of global property management, including caching, convenience methods, constants, and adding missing entries to config.xml
* Adding the ability to specify the default date format for reports as a global property
* Adding localization of displayed dates, using either the passed in locale, global property default locale for reporting, or context locale, in that order.

Tests

New test failures 5
Status Test View job Duration
Collapse Failed ObjectUtilTest shouldFormatDateWithAppropriateFormat History
Default Job < 1 sec
junit.framework.ComparisonFailure: null expected:<14-[Jan]-2014> but was:<14-[ene]-2014>
	at junit.framework.Assert.assertEquals(Assert.java:81)
	at junit.framework.Assert.assertEquals(Assert.java:87)
	at org.openmrs.module.reporting.common.ObjectUtilTest.shouldFormatDateWithAppropriateFormat(ObjectUtilTest.java:304)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:622)
(23 more lines...)
Collapse Failed BirthdateConverterTest convert_shouldConvertABirthdateToAFormattedString History
Default Job < 1 sec
junit.framework.ComparisonFailure: null expected:<08/[Ap]r/1975> but was:<08/[ab]r/1975>
	at junit.framework.Assert.assertEquals(Assert.java:81)
	at junit.framework.Assert.assertEquals(Assert.java:87)
	at org.openmrs.module.reporting.data.converter.BirthdateConverterTest.convert_shouldConvertABirthdateToAFormattedString(BirthdateConverterTest.java:20)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:622)
(23 more lines...)
Collapse Failed PatientDataSetEvaluatorTest evaluate_shouldExportConvertedData History
Default Job < 1 sec
org.junit.ComparisonFailure: expected:<08/[Ap]r/1975> but was:<08/[ab]r/1975>
	at org.junit.Assert.assertEquals(Assert.java:99)
	at org.junit.Assert.assertEquals(Assert.java:117)
	at org.openmrs.module.reporting.dataset.definition.evaluator.PatientDataSetEvaluatorTest.evaluate_shouldExportConvertedData(PatientDataSetEvaluatorTest.java:102)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:622)
(23 more lines...)
Collapse Failed TextTemplateRendererTest shouldRenderGroovyTemplate History
Default Job < 1 sec
org.junit.ComparisonFailure: expected:<...ender><birthdate>08/[Apr/1975</birthdate></row><row><patientId>6</patientId><gender>M</gender><birthdate>27/May/2007</birthdate></row><row><patientId>7</patientId><gender>F</gender><birthdate>25/Aug]/1976</birthdate></r...> but was:<...ender><birthdate>08/[abr/1975</birthdate></row><row><patientId>6</patientId><gender>M</gender><birthdate>27/may/2007</birthdate></row><row><patientId>7</patientId><gender>F</gender><birthdate>25/ago]/1976</birthdate></r...>
	at org.junit.Assert.assertEquals(Assert.java:99)
	at org.junit.Assert.assertEquals(Assert.java:117)
	at org.openmrs.module.reporting.report.renderer.TextTemplateRendererTest.shouldRenderTemplate(TextTemplateRendererTest.java:118)
	at org.openmrs.module.reporting.report.renderer.TextTemplateRendererTest.shouldRenderGroovyTemplate(TextTemplateRendererTest.java:48)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
(24 more lines...)
Collapse Failed TextTemplateRendererTest shouldRenderVelocityTemplate History
Default Job < 1 sec
org.junit.ComparisonFailure: expected:<...ender><birthdate>08/[Apr/1975</birthdate></row><row><patientId>6</patientId><gender>M</gender><birthdate>27/May/2007</birthdate></row><row><patientId>7</patientId><gender>F</gender><birthdate>25/Aug]/1976</birthdate></r...> but was:<...ender><birthdate>08/[abr/1975</birthdate></row><row><patientId>6</patientId><gender>M</gender><birthdate>27/may/2007</birthdate></row><row><patientId>7</patientId><gender>F</gender><birthdate>25/ago]/1976</birthdate></r...>
	at org.junit.Assert.assertEquals(Assert.java:99)
	at org.junit.Assert.assertEquals(Assert.java:117)
	at org.openmrs.module.reporting.report.renderer.TextTemplateRendererTest.shouldRenderTemplate(TextTemplateRendererTest.java:118)
	at org.openmrs.module.reporting.report.renderer.TextTemplateRendererTest.shouldRenderVelocityTemplate(TextTemplateRendererTest.java:53)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
(24 more lines...)

Jira issues

IssueDescriptionStatus
Unknown Issue TypeREPORT-253Could not obtain issue details from Jira