Build #348

Plan branch:
More details of the release in https://wiki.openmrs.org/x/i4DTAw

Build: #348 failed Changes by Mike Seaton

Build result summary

Details

Completed
Queue duration
2 seconds
Duration
6 minutes
Labels
None
Revision
a904baaa23e89b8fb9d5eef1932ac4a9b84fabb4 a904baaa23e89b8fb9d5eef1932ac4a9b84fabb4
Total tests
575
Fixed in
#349 (Changes by Mike Seaton)

Tests

Responsible

No one has taken responsibility for this failure

Code commits

Author Commit Message Commit date
Mike Seaton Mike Seaton a904baaa23e89b8fb9d5eef1932ac4a9b84fabb4 a904baaa23e89b8fb9d5eef1932ac4a9b84fabb4 Significant commit intended to accomplish the following objectives: * Remove the use of the reporting_idset table which was proven to not be necessary * Merge the EvaluationLogger and EvaluationProfiler classes.  Change EvaluationProfiler from AOP to direct invocation.  Use EvaluationProfiler to log DB query performance. * Clean-up the QueryBuilder interface, move the Query execution into EvaluationService * Add evaluationId and evaluationLevel onto EvaluationContext, pass EvaluationContext into the EvaluationService query methods, use these properties for logging * Refactor ReportServiceImpl such that only ReportData is cached in memory, no rendered output or error logs.  These are written to disk synchronously so they will be in place if the evaluation completes.

Tests

New test failures 2
Status Test View job Duration
Collapse Failed SqlCohortDefinitionEvaluatorTest shouldProtectSqlQueryAgainstDatabaseModifications History
Default Job < 1 sec 
java.lang.Exception: Unexpected exception, expected<org.openmrs.module.reporting.IllegalDatabaseAccessException> but was<org.openmrs.module.reporting.evaluation.EvaluationException>
	at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:28)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:74)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:82)
	at org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:72)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:240)
(104 more lines...)
Collapse Failed SqlDataSetEvaluatorTest evaluate_shouldProtectSQLQueryAgainstDatabaseModifications History
Default Job < 1 sec 
java.lang.Exception: Unexpected exception, expected<org.openmrs.module.reporting.IllegalDatabaseAccessException> but was<org.openmrs.module.reporting.evaluation.EvaluationException>
	at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:28)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:74)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:82)
	at org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:72)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:240)
(64 more lines...)