Sonar metrics for OpenMRS Core Master

Build: #1213 failed Scheduled with changes by 6 people

Build result summary

Details

Completed
Duration
15 minutes
Labels
None
Revision
6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6
Total tests
3476
Fixed in
#1214 (Scheduled with changes by teleivo <mrteleivo@gmail.com> and Ivo Ulrich <teleivo@users.noreply.github.com>)

Responsible

No one has taken responsibility for this failure

Code commits

Author Commit Message Commit date
Lluis Martinez <lluismf@gmail.com> Lluis Martinez <lluismf@gmail.com> 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6 6d52835bada49c5c8ca9ff5b9a6e83b48ef3d7f6 More throws Exception removed
Ivo Ulrich <teleivo@users.noreply.github.com> Ivo Ulrich <teleivo@users.noreply.github.com> 88b8255073ba16c1072403462f4736134c3b23c9 88b8255073ba16c1072403462f4736134c3b23c9 Merge pull request #2120 from teleivo/globalerrors-matcher
TRUNK-5137 Add custom hamcrest matcher HasGlobalError
Ivo Ulrich <teleivo@users.noreply.github.com> Ivo Ulrich <teleivo@users.noreply.github.com> e58f93aa310ddce0ab59d481fec48e72391eddfb e58f93aa310ddce0ab59d481fec48e72391eddfb Merge pull request #2119 from DataMinerUK/TRUNK-248
TRUNK-248 Add tests for junit TODOs
teleivo <mrteleivo@gmail.com> teleivo <mrteleivo@gmail.com> ab5b9ac57be9a7935262a0ba62852c957445f1fe ab5b9ac57be9a7935262a0ba62852c957445f1fe TRUNK-5137 Add custom hamcrest matcher HasGlobalError
Add a custom hamcrest matcher HasGlobalErrors which enables

assertThat(errors, hasGlobalErrors());
assertThat(errors, hasGlobalErrors("error.null"));

Provide factories which enables the above after static imports of
the matcher.

Show use of matcher in PersonNameValidatorTest and ConceptValidatorTest
Nicola Hughes <nihughes@thoughtworks.com> Nicola Hughes <nihughes@thoughtworks.com> 8d9af2c31a96860ca5c3e68acdd461defb0668a2 8d9af2c31a96860ca5c3e68acdd461defb0668a2 TRUNK-248 Refactoring LocationEditor to get text if text not null and improving test coverage
Authors: @DataMinerUK @matmoore

Tests

New test failures 1
Status Test View job Duration
Collapse Failed ConceptValidatorTest validate_shouldFailIfAnyNameIsAnEmptyString History
Sonar Full Analysis < 1 sec
java.lang.AssertionError: 
Expected: to have global error of code 'Concept.name.empty'
     but: was <org.springframework.validation.BindException: org.springframework.validation.BeanPropertyBindingResult: 2 errors
Field error in object 'concept' on field 'datatype': rejected value [null]; codes [Concept.datatype.empty.concept.datatype,Concept.datatype.empty.datatype,Concept.datatype.empty.org.openmrs.ConceptDatatype,Concept.datatype.empty]; arguments []; default message [null]
Field error in object 'concept' on field 'conceptClass': rejected value [null]; codes [Concept.conceptClass.empty.concept.conceptClass,Concept.conceptClass.empty.conceptClass,Concept.conceptClass.empty.org.openmrs.ConceptClass,Concept.conceptClass.empty]; arguments []; default message [null]>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8)
	at org.openmrs.validator.ConceptValidatorTest.validate_shouldFailIfAnyNameIsAnEmptyString(ConceptValidatorTest.java:85)

JIRA issues

IssueDescriptionStatus
Unknown Issue TypeTRUNK-248Could not obtain issue details from JIRA
Unknown Issue TypeTRUNK-5137Could not obtain issue details from JIRA