Build #1,568

Plan branch:
OpenMRS Core Master

Build: #1568 was successful

Job: Build and Test was successful

Stages & jobs

  1. Build and Test

  2. Deploy

  3. Release

    Requires a user to start manually

Code commits

openmrs-core

  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> 0bae18e5ddfbb9d01825de58b4c89a0a246b92c6

    Merge pull request #2123 from teleivo/fix-conceptvalidatortest
    Fix and clean ConceptValidatorTest

  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> e4cb346ee8c63915c1261e8412340b8d0eb6ae16

    Fix and clean ConceptValidatorTest
    * fix failing test validate_shouldFailIfAnyNameIsAnEmptyString
    had wrong assertion
    * extract duplicate test setup into setUp method
    * make conceptService a member and autowire it
    * make concept cd4Count and weight members since they are used multiple
    times
    * arrange tests in arrange, act, assert way so reading is easier
    * add test for when getNames() returns empty list
    * fix validate_shouldFailIfTheObjectParameterIsNull
    which expects an IAE but from the validator. However the call to
    new BindException(null, "concept");

    fails since the target object must not be null

    • api/src/test/java/org/openmrs/validator/ConceptValidatorTest.java (version e4cb346ee8c63915c1261e8412340b8d0eb6ae16)